Re: [PATCH][gdb/tdep] Use pid to choose x86_64 process 64/32-bitness

[Simon Marchi <simon.marchi@polymtl.ca>]

>> diff --git a/gdb/target.h b/gdb/target.h
>> index d867a58e2a8..51139042691 100644
>> --- a/gdb/target.h
>> +++ b/gdb/target.h
>> @@ -841,7 +841,10 @@ struct target_ops
>>      /* Describe the architecture-specific features of this target.  If
>>         OPS doesn't have a description, this should delegate to the
>>         "beneath" target.  Returns the description found, or NULL if no
>> -       description was available.  */
>> +       description was available.  This should return something that
>> +       describes a whole process, and if there are things that are
>> +       thread-specific, target_thread_architecture should be used for
>> +       that.  */

Haha, that sounds like the way I said it, which is a bit too informal
for a comment I think.  Here's what I suggest:

    /* Describe the architecture-specific features of the current
       inferior.

       Returns the description found, or nullptr if no description was
       available.

       If some target features differ between threads, the description
       returned by read_description (and the resulting gdbarch) won't
       accurately describe all threads.  In this case, the
       thread_architecture method can be used to obtain gdbarches that
       accurately describe each thread.  */

The patch LGTM with that.

Simon