From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2073.outbound.protection.outlook.com [40.107.7.73]) by sourceware.org (Postfix) with ESMTPS id ED7143858D39 for ; Tue, 19 Sep 2023 20:03:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED7143858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4bVNfK7VrkLUDOjAvdNjtizOPDV2WjIMv5KYjKxOUHM=; b=t2GM3Ax0QVymIdE5ooDo0tXMn2FaxjZ4XHmkTOx9cNhPm7FnwbeiCKN6s9c7EgobAqhalO0LjL+nJkIUEfF1YKZ55lnVRnZGWp+y/O7qMaYpQ8NTham7aic0oozH9Diq0X50DKd82fbGKZPxVkSzp0zqkTNfk9vhkaY9ykrMBKo= Received: from DB9PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:10:1d9::26) by AS8PR08MB6615.eurprd08.prod.outlook.com (2603:10a6:20b:335::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Tue, 19 Sep 2023 20:03:24 +0000 Received: from DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::25) by DB9PR02CA0021.outlook.office365.com (2603:10a6:10:1d9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27 via Frontend Transport; Tue, 19 Sep 2023 20:03:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT029.mail.protection.outlook.com (100.127.142.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.17 via Frontend Transport; Tue, 19 Sep 2023 20:03:23 +0000 Received: ("Tessian outbound b5a0f4347031:v175"); Tue, 19 Sep 2023 20:03:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 40aacdbc73e4602f X-CR-MTA-TID: 64aa7808 Received: from ef84c39106aa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1D417375-2F11-491E-BFD8-3533BD23FD9B.1; Tue, 19 Sep 2023 20:03:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef84c39106aa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Sep 2023 20:03:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXmiV90yEW7fuBcL1C8fyTo03CQTd4w+WkePkkb7y/OE0EvNlBa8naClGbs4sz5GxWWwojHs3CX42dYzL+KSDJxcSCq+yeUbDIQuZXwL+oYsWY4Q+lU5fW/qoMIP1VACWsNjpIy+qdpbLmGLdJguMX7oIqBp3NxqqLmtNSkpCt3sl+Pws0bP0XoGj2WNha7cFGA3P1/Xt6BdfhYCCQlQgvy0vQmixtOiwfI+C0QY7e9MhCUCqnqqg7qQmfy5GdhzdufQ/IlFoEUEmnzZiyN01NMDLedqHy/8GESjAmn+zU4sLWhOZ/34G1r8Ogz/ApvmbBFYphB3vNd4JGOdQbbIJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4bVNfK7VrkLUDOjAvdNjtizOPDV2WjIMv5KYjKxOUHM=; b=RHcaYIwn29DB1Ery8+LVuh5C5j/B6V14hQtMShm9nVXsEeuC6ZaVbDYf8aAaxP70ZCTjWCJOCJQSu3HZoc+KIS0LOnuZqr2UU/8XSzx/uaRjDh9yqBpR8nJgNULMOZb6QWf3jAQd5ljYkQCtHITWyKtsAIsXokcV8GSe+qjlP6jNniMD3wCA+aghRT9Pb/DG2dBaew45S27a2rS7aiZ2KIh/fAvHytUWNN0DOU5EcZBGyOV8+Pp7wE123QRKH8vaVZ3tS695QSgrQ9jgfc3ruV+1zTACBtbkUZ5n68OuoUNyGwGre1T61tj/C2e6I1m2yhtlt1hDI1RKDB0kc63ULA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4bVNfK7VrkLUDOjAvdNjtizOPDV2WjIMv5KYjKxOUHM=; b=t2GM3Ax0QVymIdE5ooDo0tXMn2FaxjZ4XHmkTOx9cNhPm7FnwbeiCKN6s9c7EgobAqhalO0LjL+nJkIUEfF1YKZ55lnVRnZGWp+y/O7qMaYpQ8NTham7aic0oozH9Diq0X50DKd82fbGKZPxVkSzp0zqkTNfk9vhkaY9ykrMBKo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB10127.eurprd08.prod.outlook.com (2603:10a6:20b:642::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Tue, 19 Sep 2023 20:03:15 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2%6]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 20:03:13 +0000 Message-ID: <172da09d-7814-e644-acca-7751736154b4@arm.com> Date: Tue, 19 Sep 2023 21:02:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v7 17/18] [gdb/testsuite] sme: Add SVE/SME testcases Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20230918212651.660141-1-luis.machado@arm.com> <20230918212651.660141-18-luis.machado@arm.com> <313fd82d-4827-4493-b278-be5172f799d4@polymtl.ca> From: Luis Machado In-Reply-To: <313fd82d-4827-4493-b278-be5172f799d4@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR06CA0092.namprd06.prod.outlook.com (2603:10b6:5:336::25) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB10127:EE_|DBAEUR03FT029:EE_|AS8PR08MB6615:EE_ X-MS-Office365-Filtering-Correlation-Id: 3189fb18-bf7a-4d28-e7a2-08dbb94b7ae5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 91BtMc2AK8HOG2WaSDpL0PHlN6K8P5FF5qbyMdoxCeobn2R/l79gvkP3TvrUZNCIzDGXeAl52exW4AouIoAnFyylNFGJIkBD7RKBpU3BOZrTdKww7SS+Vd8MP4X96JI5A36N0+UP0unGQWs0Hzvzkk/ZC7DbzdqEPrUkQRJ43GwvP6gYcmjv7ftSFHEMveFvJR9nR35Ijz6n03yV8KbxR/C3rqiA5pkcbFWp8fv0i1IeScElBXpsSnn4AB9pkhzFPIabhQ6ENBZxknpbBkjEIxZmQ3z66SuzGeZZBIDc3S0wG+q1L0XVmn6i1v3+rKGdDLyEbfXwgAd/VJUeXNa3s9HaSVwyiBbD3AkRbvwV3srwevyPUQrIPp9pA+Pk1e+v1jGDcOK2F4LUwjqzQHHxVJrcXFJ/XbID/XnB/JNYcTkCwubCh/ZSLutj00dr5b6VyzG6VS7LVgVGoNcWMGmM2s858Dnib8ca0S0qb7xbhApRhV0bxMxqveW7csAuxAAcHn7d65QqzT0vUjaOYDdT56ZwhpXG6vBvAS4DUpx9le1Z/DLUngsZGYtVIPfx1WeVFdOkkBwAPo91usmvlGYe6eyLuCLfLU8AZw8/84UJMg2GbMyAm2Lin0VhC4O5j5q3JEu4LDjldNYL/TqJelK25w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(39860400002)(366004)(346002)(136003)(396003)(1800799009)(186009)(451199024)(26005)(2616005)(6486002)(6506007)(53546011)(6512007)(36756003)(38100700002)(86362001)(31696002)(83380400001)(41300700001)(478600001)(5660300002)(44832011)(316002)(66556008)(66476007)(66946007)(31686004)(4326008)(8676002)(6666004)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10127 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f0c86991-fe5b-4fe6-bbdd-08dbb94b72f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hukbU6IKfuX1uNvhY4ydvLS3glbtxBIx7ytTD7v5JwQNqLPOHxKFZJtx+R8JVP6KXUSMWkkff7+HEaDCKTPWcwYIZjSy4thDS88H0BLx/h6ScqDvT5mS1A3yk7gxv2YiQMdmF7Qw+piMS2kLhHxDvrmBKybYbDjWK+6bLWqsRaAL0jIgcnWLY5bgoxEsnU52XupzyKejvksQC5kXD5uafyn6tIApGpDVSvkfZZ3nszi/WUSbxm+Fp89ndk8DUB692UVCczq6QTPGN94eZgrVEjfWOnu6kpkSEcHlDi+67Zi9QalPKkQTA3AAFkWQaVBKDrw0osNhzNzBPLiGqauTj8rkxTYt0gAvZ6c0x6Ec2MqIbBkin/ODHhL9v1qyX2tOVHpn0cPL659OTF9xDNZb0aIMjs5649K89Z/LwaQ9yRdn1csd6xSwUDZGHuYI453x0QFONm6xnyZOII3BJAh7s8CqFXgIHIqwewXQkrhbt16PnTQwy5DgEG34v9StoqKu9AoweDi+TMV4n/qs/2d/tkjaNGTjktOajF1eS0N3F1Fy2TZQEs6t1ld39aUE29w+CxjzrD2JOVgX+HhhhhOG3ny1XGutxuExOZDfzb33j8G01RMFnKNNVsaZq0BVJgiogCD62bdbrw9MXaQCtOglmA+H6FIzK6S0vaMSLvS4pAMGPiYoPtT7OwIQVnGiCynnX8dx3D7lxrN4u5eoDSxXd6+YBrMcDFsNHUBFKhNBz5CATCEq4VwinwNEHDqNusG9oFHnIlx9tQ8T8/w5wnjxxg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(39860400002)(376002)(396003)(136003)(1800799009)(82310400011)(186009)(451199024)(36840700001)(40470700004)(46966006)(70586007)(70206006)(40480700001)(316002)(478600001)(6666004)(81166007)(40460700003)(2906002)(36756003)(86362001)(31696002)(41300700001)(44832011)(5660300002)(8676002)(8936002)(4326008)(47076005)(2616005)(31686004)(26005)(336012)(107886003)(83380400001)(6512007)(6506007)(53546011)(82740400003)(356005)(6486002)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 20:03:23.8630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3189fb18-bf7a-4d28-e7a2-08dbb94b7ae5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6615 X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On 9/19/23 20:12, Simon Marchi wrote: > On 9/18/23 17:26, Luis Machado wrote: >> v7: >> >> - Bail out from sme tests if we have a remote target, due to lack of >> support in the RSP. >> >> v3: >> >> - Additional documentation for some testcases based on upstream reviews. >> - Addressed upstream review comments. >> >> v2: >> - Introduced a couple helper functions to determine the available SVE and SME >> vector lengths. >> >> - Before running a batch of tests, validate that the target supports a certain >> SVE vector length or SME streaming vector length. If not supported, skip >> that batch of tests. >> >> - Fixed up native core file testing to remove generation of a spurious core >> file, which later would be reported as unexpected by the testsuite. >> >> - Fixed tpidr2 dump in core file tests. >> -- >> >> Add 5 SVE/SME tests to exercise all the new features like reading/writing >> registers, pseudo-registers, signal frames and core files. >> >> - Sanity check for SME: Gives a brief smoke test to make sure the most basic >> of features are working correctly. >> >> - ZA unavailability tests: Validates the behavior/content of the ZA register >> is correct when no payload is available. It also exercises changing the >> vector lengths. >> >> - ZA Availability tests: These tests exercise reading/writing to all the >> possible ZA pseudo-registers, and validates the state is correct. >> >> - Core file tests: Validates that core file reading and writing works >> correctly and that all state dumped/loaded is sane. This is exercised for >> both Linux Kernel core files and gcore core files. >> >> - Signal frame tests: Validates the correct restoration of SME/SVE/FPSIMD >> values across signal frames. >> >> Since some of these tests are very lengthy and take a little while to run >> (under QEMU at the moment), I decided to parallelize them into smaller >> chunks so we can throw some more CPU power at them so they run faster. >> >> I'd still like to add a few more tests to give the testsuite more coverage >> in the areas of SME/SVE. Hopefully in the near future that will happen. >> >> Just a reminder that these SME tests are currently unsupported when gdb is >> connected to a remote target. That's because the RSP doesn't support >> communicating changes in vector lenghts mid-execution, so gdb will always >> get wrong state from the remote target. >> >> Co-Authored-By: Ezra Sitorus >> Reviewed-by: Thiago Jung Bauermann > > When applying the patch, git says: > > .git/rebase-apply/patch:796: indent with spaces. > unsupported "aarch64 sve/sme tests not supported for remote targets" > .git/rebase-apply/patch:1469: indent with spaces. > unsupported "aarch64 sve/sme tests not supported for remote targets" > .git/rebase-apply/patch:2133: indent with spaces. > unsupported "aarch64 sve/sme tests not supported for remote targets" > .git/rebase-apply/patch:2870: indent with spaces. > unsupported "aarch64 sve/sme tests not supported for remote targets" > .git/rebase-apply/patch:3539: new blank line at EOF. > + > warning: 5 lines add whitespace errors. > > Can you please fix them? Indeed. I remember checked things, but maybe I introduced some new whitespaces somewhere. As you may have guessed, setting up KFAIL's was a bit of a burden, as there are a lot of potentially failing tests. It seemed best to just make gdbserver-based testing unsupported for now > > Otherwise, I did a quick check on the newly added conditions to skip the > tests on remote, they LGTM. So with the whitespaces issue fixed: > > Approved-By: Simon Marchi Thanks for the review! > > Simon