From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic305-19.consmr.mail.ir2.yahoo.com (sonic305-19.consmr.mail.ir2.yahoo.com [77.238.177.81]) by sourceware.org (Postfix) with ESMTPS id DBD573858C3A for ; Wed, 13 Mar 2024 11:48:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBD573858C3A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBD573858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.177.81 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710330488; cv=none; b=NAIsCa1G/vuXfowqFOeeFrLwNPjwTooEDFetBlhU5onpwWrNTIuKPqq9dFpR2aMKxA6+Hynyi/DwQ1d4rR32lAKjcQZ61cbyKkqBXOYwq3wonEs6bBpGbLkk12UmsZQVMb1tXjpprBTUoopdakm3ulyZFFtHHLhp6XQgvUnxLD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710330488; c=relaxed/simple; bh=ieRaaCM0xEaApvoFHF8jzyiir3wSMYKRgBljXrK8+ZM=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=NtXTbsFLVre+vMqetLaD+iBsu63n2hAcW/RERZMjz2kWlGWhlo/0n+Wkpylkw0I87lAbo7bXmIe31Ch0m9eq8pXmtyyahshJCvgmMpoA5OU0wQ/81+3YgrixPKrBjcGi5dPft6Rxb/DpGfyCiIUwALrnuh9T5QMHKdaI1SZBGG4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1710330485; bh=ieRaaCM0xEaApvoFHF8jzyiir3wSMYKRgBljXrK8+ZM=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=Pp7BjjTTyeppc1l9FKXMhPDpmAQIkPWuUuivpYBvn0308IMJtfEXUWhseZ5LX5ZEXmTOTuoT2Ad9MerWsbvxm0i2n3pbCDGnnkiCIGrwif5+u6ePHRdd7wuuApRpbgnKzoOminu3G6sOP45T6FuZ4PJpusar7eVwb6NGyDBb1KPUoJPdEJyhxRJb/oEGAj5UMDJj4erplEcljWVel9JaLxIPb4bUt272glWvT4fij6yAjJXZn4EPsPQ4zrKXTXPf4qXSHizcIn53g8Vx3MIGO7v7bcsLsfnT5Z+38gzBs8cdWSW2bq5bupyTsPh9pGsxxn+9TF74Qt1mILlyvjTDqw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710330485; bh=xVWdBSJbMLLsKMAvY81aDZ30nBYr5j76wIEgM46c6wJ=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=tmI8/BYPI7fmdLjkOzc6KOXlpJjkBXr98nEi9dam7U9KBDaXGRZwqhvMPIjTq+3ElF3/OkzJzkNQatIXkuQngOq+4wU5CLTtaqi7vgWAqZRgr8Z8euI4X4oxwmbv099b70ho+59kltTqoDXwo/FX/sd3L/8rcSuPXln0ciXglZtzKal+kKTexcMQdD6yqWY/sg9lxuhqyqUCC2D0RIakzHQKgvZ5kAPmet6P+F38uvFbpoCuL5W14mFqgTF35RjfnTbwPF1dE9XIETNH7UaWKSUzUUQxK6/SwmdnJZ46XkKES7kZz0L0be0rXHoAxCqlIaTRA8wPt/D37XeIkMOEuA== X-YMail-OSG: 07N0ecoVM1mdn_2PNNBB6cvQhY_gh5sghwTwlNE9QC5uKLD5d1SHDytZDK8EeYv ObydWv0HgiLEmlxqISsl14fHlFRtFHT6n8BHNT0GZWq_v_OjysU015wbdyaLwkLYi3BbV_QpynvG 4YubVKpyJNr_RIMY_arMfKi_aVhiFT6LAzgaysfJwcqUSTbosIvMt2nxNBWCujHAM5fEA1Osz8bp oSH0Qp7rinZbA9VjNdZvEWWPxul4rHtAkW9zxWpAqcSf1H4RQoRhgd2AYfV7rU4c9QnughGX2a86 xzrf57iLwA9o.MyczM6q3oGSBrz4QRw1FhrTi27sjIFTH0587ZtccCe4sBWQIrPA6sPQDxOmI416 UBoCGRxOY4PHBxK5KvtbaL63LsXjH.9qY75MVv7IyI9faAeDYhr75azGWNLufyByOzvVNJoRIR03 Sl2y4hC6rLVOY_dd3hyb6Ywepr1d9hCQpkJZSnvofpB.Xuiwppn93qmJv0r0ddBX_U4IE3HG0Cky t00UWQWigxupEEFCXLooZat96aJ1ihofY8ZSORrT9MxutMBB1CSK6brQWdtHi48kPxN3yttMMDOK FW8ENRhAMicW06rSe_xZ34cmB_Z81_XhB490_YVvVoRneGkgihbzSmfQCXFT0x4b3Qo1vurFfo4u ZJRV.seftnbBGdZde25tKsIR9TPDrZ15xw_JfxJgCtOa34UODOyUX1K9xYYXd406We5pw4R4NGA8 q1hs4rU693n2PIha_eQMRtmny50fsYO9r3qoJQNtd9yr.bYkgzQsUmOIwiZwG_PSs1Z8b1T4z86W haN_OO0htZUzvcRuuq4puSYmPhZtxk47f81LQFCiKnrpjy4YcPFOBgSXMuerWyS3cX733Rkgs1h2 Mfqm9FC.lOTKdH9WbhHk3sihQjcLvqh.da9nOWxfyfknA8tyckki17epPPUvE6ajFiX0A._.CzBB jpAN9Qd3rn.DY1Ic5c6EqdFAOqHFfISWD1WfMhwjy6YdoV7_4SDxMwnLMgzw3vwIAb8WVZGQ13sj 0c05h.VxG6Joogd276con2du1gHsYzsv392c4tJcNtXfTrm1OyxxLKhUJhr9ib1eK8qMXYqfxJ38 hq.SZckjG_tzreOiOjf2dwwK6FhFgh4L846XHpIdtavMu9fvnP66L82aAuuaGatV2UGtM2Jr3DYr M5d2sbSnsAuhtw9mqt7QW_bpIj_FfGt3PHF7apr_jaUBrB5JJLWzSxccUlODPf06KJvaGjZWW3UG r7wIfj0swXwRJQBw7J7Gu5cUmhr9rJPIkJnosq3alQURADoasNlrqSuu_3gVR.EpMQ.veiSMwU0g lxsp3mHZc.Sp_6qDgeOk7jtjC5qcjx1ewVNTnPeBfEi4a.IEv6rFGtQRTZShvPF3_VPNolOmJPHL d1gmbtsIwhlvZQ1pjDc1lF06jlXWOvyW4wrwZFZ1FQqL7pbQf672C3rRb3RJC3Kpr0MtcJtDQ4ty kqo.jl7gqNmmbm2WnTwVz6nkJjCx15s0HdxUHgYbu.6Xo1pblGOhbqIYowyc.SwJjnJi4JnD0BP3 70RbvruPVYX2wvctgDUiHXuLuCvhJsBi8qiVlzxdBA7T7mJJEF0vUKwXvU4f_iuS5RWnhrWyH9Kn dhjDgORwcHmr5eMHZdNi6moZ8uwx.xAPIFWhfJy5IDdOPTFOouegugveaItKXjpRlRptwqZLbg77 ZCgIyyJXbAIMR5db1QGB2XTe0fD50TNL5Pcnu0IFzJPtHQ3xv4CU_WZgzPHmEErKZVeMZ0oIenIr FThsK96_hpF_E3SWYaKz_r3qHW47Mdd_u1.wrDh4KhfqsPsSUEpLlNw2J6Xf0qnDchzx__4XEFEi RfGTSk7s2q2EYLjC70V5jOqIXaKZAN1Jah4X_1tTUQUrgq1qiwtlAulfyuAbH4FV_WgOwtSNLA5H wYD4zDXTkVo1bfWZtWLHhzBuWcm.mjrS8_HAakCRDilmAYpbtPSZeT329p_eXU2w1h5BtL1hl0Oe HBSzSidjyCEY_kFpIkMKQiMchDMh.PfSkSCBpd0oZgO15TQJ6nywGQgm3OJLsB_fQjHhjooqlJ5. w_p9h1.tHrUXsk7vJMG6sZ5XJIZqLzo7i.NjA36oGcBjpDaAvl.hsVG0F19Yfprt39uZFvFbAcw9 ZNoipGptglSbnQkPEvB_HHC1TMENdUJzoM70pNkF3D5db0E6c6SnbTUNJMDLzoma1DOkeujQrrYl zEE3G2WXwyN_SaHMAYl8uRJwl5GiAnIzswo7o3Q-- X-Sonic-MF: X-Sonic-ID: cedd3e79-24b0-4473-b95e-a436e18061d8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Wed, 13 Mar 2024 11:48:05 +0000 Date: Wed, 13 Mar 2024 11:47:58 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Markus Metzger Message-ID: <1742234353.6194591.1710330478254@mail.yahoo.com> In-Reply-To: <257133230.5318577.1710244567184@mail.yahoo.com> References: <20240312113423.3543956-1-markus.t.metzger@intel.com> <20240312113423.3543956-2-markus.t.metzger@intel.com> <257133230.5318577.1710244567184@mail.yahoo.com> Subject: Re: [PATCH v4 1/4] gdb, infrun, btrace: fix reverse/replay stepping at end of execution history MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22129 YMailNorrin X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Dienstag, 12. M=C3=A4rz 2024 um 12:56:39 MEZ hat Hannes Domani Folgendes geschrieben: > Am Dienstag, 12. M=C3=A4rz 2024 um 12:35:10 MEZ hat Markus Metzger Folgendes geschrieben: > > > > When trying to step over a breakpoint at the end of the trace, the > > step-over will fail with no-history.=C2=A0 This does not clear step_ove= r_info > > so a subsequent resume will cause GDB to not resume the thread and expe= ct > > a SIGTRAP to complete the step-over.=C2=A0 This will never come causing= GDB to > > hang in the wait-for-event poll. > > > > That step-over failed after actually completing the step.=C2=A0 This is= wrong. > > The step-over itself should have failed and the step should not have > > completed.=C2=A0 Fix it by moving the end of execution history check to= before > > we are stepping. > > > > This exposes another issue, however.=C2=A0 When completing a step-over = at the > > end of the execution history, we implicitly stop replaying that thread.= =C2=A0 A > > continue command would resume after the step-over and, since we're no > > longer replaying, would continue recording. > > > > Fix that by recording the replay state in the thread's control state an= d > > failing with no-history in keep_going if we're switching from replay to > > recording. > > > That sounds a lot like https://sourceware.org/bugzilla/show_bug.cgi?id=3D= 31353. I've now tested this, it does not fix PR31353, but the next patch does: [PATCH v4 2/4] gdb, infrun, record: fix hang when step-over fails with no-h= istory Hannes