From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic308-18.consmr.mail.ir2.yahoo.com (sonic308-18.consmr.mail.ir2.yahoo.com [77.238.178.146]) by sourceware.org (Postfix) with ESMTPS id 5E5523858D39 for ; Mon, 20 Nov 2023 15:59:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E5523858D39 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E5523858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.178.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700495968; cv=none; b=JVXbEnjaCOABNbuQqnM9MnedCi6ISpEZadusUpTDapCCB94RuSJ3hXLIS1cm7FgUgKxqQLn7d2IQOTau7BSC5Ygj6O/d98p1Vcr9jXt2NBtHMq7Dr2pF0g7Fq0H+64qT9pO9agyyY2NmOcrVko/Pi/ba4+4PicTBaClXKvDCAzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700495968; c=relaxed/simple; bh=lZojgXZqptjkPkn6YWNmntczvtDIRvgVz2/1HQplHag=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=fU89B+faJRi5v8qsnhek988usLaA0jLVQqipW6mb4dD6IO7srPIfIT9mJBr6CePckCP6pbPDfRyb9PEqexqFv0PN87IN3CEadNz8bAS91fGkvqSA4ge9dr0pqzDjQVuyrbWvQTd5uHD+oXmF+8vzSDckf4mUtx750ZFUffFgPOU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1700495964; bh=lZojgXZqptjkPkn6YWNmntczvtDIRvgVz2/1HQplHag=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=QirzL8pcLN9fg2LCwW/amujj4GCaogeAL7rC2WB709YHfR2uQ+JdzwojAIc6fOvgLlyhSh4I83HuNZEXmW1ONYxqmmJRZl9LUz0jA5lYh4YXE7RmUzxM67WxpTDeVyOnh5HH/2000w/1CRjhZKlCf4OW2mHRyePTgyJ4zKjRBEM3+2Y9sy9rMf5KLN48x+8+iDIJeASVDKDDT883IR0ndFkcZnFA8Wdl0AlBu67bkY/pFVaP6rwal5yEwomAsgtyf3YCTPaxPQRH5RxS6nIqH7gS+UvCJy5b3SJlFHS8i7Wqv3GIaak8jSqxP5cUPsKTuK8+UBgb4SdkOSj8Zy46DQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1700495964; bh=+v5u2OnoTEyvd5xTVJNrp/A7mbb1KrVZrI3wduub43C=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=GjZxNip7qEBJ55p/VRv9/tKSlkFR/pMi4LEcBC4/pXmfDfRghmtdgKEO+1AoZ4KZf02wg36YaZGVIck1OTir1Fk6HvWT4wSt+WzJzZSSnqnsysY/nPckT2bMN8Oq4Kci9d+vejSuyknc0foONUHH6BSGRUGBQg3HeBSaGv5dfCdoVH5L9JK0ESzaf2hrccsdapLX0Ry81VQPiaPom8qoL23A06UXtoEkOZcNNlaGq18bRTzfhZ2xQJPaYHoKb+6bx1NcR2xGnZy4nRXICpoyAgD0O3SZ1OJCtSk9ipufeK7pp6RIV8QsSxJ5FV3MZjqT6eAaWWinQI4HOZMM3EVo6w== X-YMail-OSG: OYMdbHoVM1lVmMG9VTBSyH9lSvTIzfolIDpYuSfpGaKrb2N3SWwnUCb60lBeBzJ 8j8x5yqZaR7l1a08JLEB8_xIOoJZn9U7p.zH5u.E__wR1X6dY1p524CEzu4l2TTIo9yf1i214ZPe NlEFlIfIiiVo0wt9z10B_cSp3Fn_dBHMD2F_xcJM1NS4vtzxphukqNuck_Jpu.bMLszCwH45HJLC t7sQL0Y2Fyv_v0dR8ZX8lfkxKOvQc599d_gq8TNWcmGSdHo4cZ7BsJsLbPYNEMgeKH_8wdbgycQ1 8uSriK1QoXhlXjqAmJT05WMIicH.L638pv2w1jWKcLSmgUJXYWXICzF6ZaBwpQ3nZrnFIoBU8mmu wFHTe0oBaW.V5CXcm5MKgcAFha7vrnsbmB_R.u1q38yNOBUyZvnNUYp0YATaSBtewFP2IOwGpt3U A9.N9fGvO_0s8.rb5xSBRBWlFojVOzWj05iPH.rcc5uy_zYq7uQaI3lQUT_Ph.QSM1W0FwP4zwjk l3meEVWxiGXg72vMi38jIPH6LkIdoAcqD80GuAjF6Y3zEPRJ_sKk7CgcJ.3lXwcfUEimgfo2CsOb 9tXKg_mOpIRjkYOrAJMInXSPNT9shrTOt.1HOyGyg2fSGf6VuRnoSG7JaWcU9buI0Z97x4gA1pLt lkXbyFhM.Iub2YbXDE9NrHibT2VSeYykhzwn.VxYuxsTzwVEXuz74nVJS.NgzrXcV5wf.OELYLd2 a721CVg3TJf.WqMwXdvxtjUlFCjtDad5utSMHV7HPxTvH9n3NbfAH5jyWupoTqEASzMGiIb15lOu uKbQI1OHJKO2P83PhRukDRDcibqhx.IFC86YFn6hsbOnMhpbXtV3fUlgWVt_0OAroemBTncsy77m aOFx91_TAwSZ2FfIPzpCaiFN1zDG0U6boVTnkiJ47AEyqS__W69ulI92QIMWrKYU4BPC0h4bi4H9 IyhtOooXCNIA.krQqbzErQnIcethK66oiEvhNNkfFaHeexJgj4BoJy61IPE6z6ffMnfeIsOJgsor .88eRLZfWRVsn3wFDushEmleXq4Rr4F.u8m2nYb65YE56W1ilNGdhHHna1lgTBE_.hjNQx_YACsM gQOXwGECUv8fJ6uXww92uEclqqAfVoj62x2iE_jNhmrzuwXsIy2v0NJK8amMm5kAagSxg_mxSshV 5knn0BtOTCzVmk.BFVKwwvGhh.Y6BIiQryqu8xYX8LHX.rXIfysAeAA4LSzFtzoee__O4wYmGH_P wkt.C6D8hxB8S2XuEZBwrsCYWejZFCOqxLQTmal8Yy45pegyP6iUG2Xxhx800HoMWlbZlb3MKLMv 0EqfgVCnnuPma9KGiUJ.GBrMFzNGhDk.uyfDUk5nMoch0uUYantV4BWfTPJ_vKLY0cbTzesNTNCh yqSqD_B1D7nHsI.ca2.LvZHIAJ3RiSi2.W_IdN7iICMRA4i76HBZDbxEo1rX3.c_rvWgGXKWiqoX ot.B3Xk.4vGnvfrNh5YArvZQzOv9SP1sNrgxOsAmtFeS7cFPnB91e72d7gzi59UryBfAcQ0YjKke HE_EqF.u9eULD9plH_QbWNcCrChm5BiHImhxR9LkxPPjwtMT1nmaP26ICDctV3PW_MrgvAq8QeLk eK4ZQrqTufiSYlWBX9CpuyBcodJbz7YgAUfnnXU9h1F6M3LBH.TzZCXz3XwlxwOOgKT2qzJLbf1g wksOve1wIa.LzByu787x4pauvREFeoTkNLOIKDtsZbL1Afppu15cQIcprzHNmBUsdWT2KRH4kbeJ UgUDfN0Hgojxr4TD6s4H8BISv0YufJGp.2cm9QqjS_zogsqd7N251zMRIXop70yzUogcNb.zVzHp NUoFBUFmgX.VgjHohRo2sRZS7OVY7RzApD3Q3PzTq1yW.GRc9BCj84cukf0VGORF1af9F.NNyqUJ lJhNkeZfFBvcZ3kj0ZnN2ZvsUon9iQqswbgmsI_vBDUAknlwvq10j5Wo4IPQUdgNukAqQOoDOEqY vzItr3RhRa.I7JW3RH7Z4EnAkUWUcuFXvrRs_Zih8EkAGdAhr3B2jyTlmEsN8cu8J6Agkkqmhgn3 z4sZSPW5mYLzeli31.WXn2wwg57hBMjrr2XgBFErTAtpBL8zH1c1rhGEUf.C6oSZiuP_NcUFKnEH bQjvsCwYVIwDBjOJHDlyoMsr1Kf4.TEk4ttLsUNiWay9aBg4VTRIN543LcebdayTeE8nnxfCTGv3 ytuqlf0vkmk1Fq71OhiEhP2gFnTl5qIslqzAlUKk- X-Sonic-MF: X-Sonic-ID: 83367e14-bed5-41dd-8f9a-c70b56d585d7 Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Mon, 20 Nov 2023 15:59:24 +0000 Date: Mon, 20 Nov 2023 15:59:22 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Guinevere Larsen Message-ID: <175805758.9196163.1700495962988@mail.yahoo.com> In-Reply-To: <05d3b3e1-fb3c-4a1d-c5c1-75975c2af367@redhat.com> References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> <05d3b3e1-fb3c-4a1d-c5c1-75975c2af367@redhat.com> Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21896 YMailNorrin X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Montag, 20. November 2023, 14:09:34 MEZ hat Guinevere Larsen Folgendes geschrieben: > On 14/09/2023 18:27, Hannes Domani via Gdb-patches wrote: > > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > > caused a regression that meant hardware watchpoint stops would not > > trigger in reverse execution or replay mode.=C2=A0 This was documented = in > > PR breakpoints/21969. > > The problem is that record_check_stopped_by_breakpoint always overwrite= s > > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT > > value which would be checked afterwards. > > > > This commit fixes that by checking if record_full_stop_reason is > > TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. > > > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > > --- > I have sent a review to this patch. Your spam filter must have catched > it or something similar. If you can't find it, here's the link for the > public inbox: > https://inbox.sourceware.org/gdb-patches/2eb65a2d-aa80-5930-3033-bfd82baa= 2ed9@redhat.com/ I saw that, but it doesn't really make clear what I should do now. And from what I can remember of our discussion on IRC, you wanted to wait i= f Pedro had anything to add. Regards Hannes