From: Hannes Domani <ssbssa@yahoo.de>
To: Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix debugging of WOW64 processes
Date: Fri, 10 Apr 2020 11:03:22 +0000 (UTC) [thread overview]
Message-ID: <1760610942.6303427.1586516602588@mail.yahoo.com> (raw)
In-Reply-To: <87lfn42wdv.fsf@tromey.com>
Am Donnerstag, 9. April 2020, 23:15:59 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> Also, ignore_first_breakpoint is used now in nat/windows-nat.c as well,
> Hannes> but was not available there.
>
> Sorry about that.
>
> Hannes> 2020-04-09 Hannes Domani <ssbssa@yahoo.de>
>
> Hannes> * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
> Hannes> Move to...
> Hannes> * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
> Hannes> ... here.
> Hannes> * windows-nat.c (windows_nat_target::get_windows_debug_event):
> Hannes> Check for STATUS_WX86_BREAKPOINT.
> Hannes> (windows_nat_target::wait): Same.
>
> Hannes> && (current_event.u.Exception.ExceptionRecord.ExceptionCode
> Hannes> - == EXCEPTION_BREAKPOINT)
> Hannes> + == EXCEPTION_BREAKPOINT
> Hannes> + || current_event.u.Exception.ExceptionRecord.ExceptionCode
> Hannes> + == STATUS_WX86_BREAKPOINT)
>
> This needs extra parens and indentation like
>
>
> && (current_event.u.Exception.ExceptionRecord.ExceptionCode
> == EXCEPTION_BREAKPOINT)
> == EXCEPTION_BREAKPOINT
> || (current_event.u.Exception.ExceptionRecord.ExceptionCode
> == STATUS_WX86_BREAKPOINT)
>
>
> Hannes> && (current_event.u.Exception.ExceptionRecord.ExceptionCode
> Hannes> - == EXCEPTION_BREAKPOINT)
> Hannes> + == EXCEPTION_BREAKPOINT
> Hannes> + || current_event.u.Exception.ExceptionRecord.ExceptionCode
> Hannes> + == STATUS_WX86_BREAKPOINT)
>
> Likewise. Ok with this fix.
Pushed with these changes, thanks.
Hannes
prev parent reply other threads:[~2020-04-10 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200409145201.18111-1-ssbssa.ref@yahoo.de>
2020-04-09 14:52 ` Hannes Domani
2020-04-09 21:15 ` Tom Tromey
2020-04-10 11:03 ` Hannes Domani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1760610942.6303427.1586516602588@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).