From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 81BFD384AB7E for ; Fri, 19 Apr 2024 15:26:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81BFD384AB7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81BFD384AB7E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713540414; cv=none; b=ClrgqotCW8PYZd+Ac5pJhxnozfLCIyctxeL5oIqV1KGYpH7mCJViboBCEIIdEyzkTNAdFI/UIgzuwfWgiP74UzvePkjts7MnQcokLkbtOdxhVaKudcgyWDypSGTvbCAyyjvH671dE8dpE9FxVr/wZkNF3KITIk77gcP5SLOhV/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713540414; c=relaxed/simple; bh=20Gbs4eWleGoNHrWMDsCc1NzXjuamO9LpRsLniP9na8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=q4SZdnfSy28k/7XFGXkvyaD/R8sYUqAAKrVtl8+4KrGVA3YUXEPgm1p9A/Q9IJe8pObBhYs1OImiBK5kZOPieKF/TWn6F57zs67M8KZ5P6jGiI8qcZxDyog3eUbf/2a35WHS7eXG9t1wJZXqudBupsCArsVDIGubmmdtZagvHCo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1713540412; bh=20Gbs4eWleGoNHrWMDsCc1NzXjuamO9LpRsLniP9na8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=orBOivOQ6tuIPErmpyeuxO++hEoI+5+Ds5o8C66W0jdbLrjQaMaAeyamX4SXTzmd3 er7r6B/YzS7a6Ahe8vFWnDkrxPgM0s2gg6XvueIUIFdZZbHJQuTiX0m64EHgT84pc+ 73xjSpOXJVSXol7A7m0vhG5kGzLbqw7CBdRwaMDM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 050B41E092; Fri, 19 Apr 2024 11:26:51 -0400 (EDT) Message-ID: <177261d7-e29f-477b-9716-f76a919fe1a4@simark.ca> Date: Fri, 19 Apr 2024 11:26:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Add include guard checker and reformatter To: Tom Tromey , gdb-patches@sourceware.org References: <20240419150427.897379-1-tromey@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20240419150427.897379-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 11:03, Tom Tromey wrote: > Here's v4 of the include guard checker / reformatter. > > It's really just v2, but this time not sent using b4, which was > sending the wrong patches. > > Tom > So, after patch 4/4, your script doesn't need to handle the the `defined(FOO_H)` style (OLDDEF in your script). I think you could remove support for that, it would simplify it a little bit. Either way: Approved-By: Simon Marchi Simon