From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53368 invoked by alias); 19 Jan 2016 16:02:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53225 invoked by uid 89); 19 Jan 2016 16:02:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-Greylist:succeeded, HX-Greylist:SMTP, HX-Greylist:AUTH, HX-Greylist:Jan X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 19 Jan 2016 16:02:55 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A102EB946; Tue, 19 Jan 2016 11:02:53 -0500 (EST) From: John Baldwin To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 4/7] Display per-thread information for threads in FreeBSD cores. Date: Tue, 19 Jan 2016 16:02:00 -0000 Message-ID: <1773088.JmbCx2r5te@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <569E1257.4040805@redhat.com> References: <1453142254-20266-1-git-send-email-jhb@FreeBSD.org> <1453142254-20266-5-git-send-email-jhb@FreeBSD.org> <569E1257.4040805@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00433.txt.bz2 On Tuesday, January 19, 2016 10:39:19 AM Pedro Alves wrote: > This is OK. > > On 01/18/2016 06:37 PM, John Baldwin wrote: > > > + /* Note that each thread will report the process command > > + as its thread name instead of an empty name if a name > > + has not been set explicitly. Return a NULL name in > > + that case. */ > > + if (strcmp (buf, elf_tdata (core_bfd)->core->program) != 0) > > + return buf; > > (Not sure, but I think the alignment of that return is odd.) Oops, it is, fixed. -- John Baldwin