Re: [PATCH v2 5/5] Adapt and integrate string_view tests

[Pedro Alves <palves@redhat.com>]

On 03/30/2018 10:46 PM, Simon Marchi wrote:

> -  try
> +
> +  bool threw = false;
> +  TRY
>    {
>      str01.at(csz01);
>      VERIFY( false ); // Should not get here, as exception thrown.
>    }
> -  catch (std::out_of_range& fail)
> -  {
> -    VERIFY( true );
> -  }
> -  catch (...)
> +  CATCH (ex, RETURN_MASK_ALL)

Do we really need to replace the try/catch with TRY/CATCH?
The latter must be used throughout GDB because the code inside
the try statement can use cleanups, but here nothing is ever
going to use cleanups.

> +
> +/* The actual tests live in separate files, which were originally
> +   copied over from libstdc++'s testsuite.  To preserve the structure
> +   and help with comparison with the original tests, the file names
> +   have been preserved, and only minimal modification was done to have
> +   them compile against gdb::optional instead of std::optional:
> +
> +     - std::optional->gdb:optional, etc.
> +     - ATTRIBUTE_UNUSED in a few places
> +     - wrap each file in a namespace so they can all be compiled as a
> +       single unit.
> +     - libstdc++'s license and formatting style was preserved.

copy/pasto, optional->string_view.  :-) 

Thanks,
Pedro Alves