From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope
Date: Mon, 4 Oct 2021 14:46:07 +0200 [thread overview]
Message-ID: <17aa014b-2500-14f0-81af-a5de2a98e657@suse.de> (raw)
In-Reply-To: <24809991-4982-9951-a7f7-514a2d01cd10@polymtl.ca>
On 10/4/21 2:05 PM, Simon Marchi wrote:
>>> Ah, I had not seen this comment. So it was on purpose. Still, I think
>>> that it makes it more confusing than anything. The patch LGTM.
>>
>> And, this follow-up commit reverts everything except the comment.
>>
>> Any comments?
>>
>> Thanks,
>> - Tom
>>
>
> Is there a problem with having the lookups done with just the pc?
Well, there's the problem that I describe in the commit message. I
don't known of any other problem.
> If we
> were to replace this with some C++ hash table, say std::unordered_map, it
> would be std::unordered_map<CORE_ADDR /* pc */, call_site>.
Right, because there's a separation between key and element.
> So doing
> the lookups using just the pc in the htab makes sense to me.
I'm sorry, I don't really understand what you're trying to say here.
Do you agree with the patch? Do you disagree with the patch. Are you
suggesting an alternative solution?
Thanks,
- Tom
next prev parent reply other threads:[~2021-10-04 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:33 Tom de Vries
2021-10-01 12:33 ` [PATCH 2/4] [gdb/symtab] Remove COMPUNIT_CALL_SITE_HTAB Tom de Vries
2021-10-01 13:13 ` Simon Marchi
2021-10-01 12:33 ` [PATCH 3/4] [gdb/symtab] Add call_site::pc () Tom de Vries
2021-10-01 18:10 ` Simon Marchi
2021-10-04 16:45 ` Tom de Vries
2021-10-01 12:33 ` [PATCH 4/4] [gdb/symtab] Use unrelocated addresses in call_site Tom de Vries
2021-10-01 20:56 ` Simon Marchi
2021-10-04 16:47 ` Tom de Vries
2021-10-01 13:09 ` [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope Simon Marchi
2021-10-03 19:34 ` Tom de Vries
2021-10-04 12:05 ` Simon Marchi
2021-10-04 12:46 ` Tom de Vries [this message]
2021-10-04 15:41 ` Simon Marchi
2021-10-04 16:14 ` Tom de Vries
2021-10-04 16:34 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17aa014b-2500-14f0-81af-a5de2a98e657@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).