From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2084.outbound.protection.outlook.com [40.107.241.84]) by sourceware.org (Postfix) with ESMTPS id CE6DD3858D20; Wed, 10 Apr 2024 13:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE6DD3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE6DD3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.241.84 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712754062; cv=pass; b=BkQP19lpsNWr3+53wiGWvshJJUN1SKq8qfHG/QbV+hhG3Ps5SR5Rhc0yWBMtNDHArqcLrzPHvQO8Ach68K6ZSNpI9vq/OCLKp7Qm9MEFCIwAdK3IOKd2w01IK/9Egspvvv+2Vg3thX5ZIlc6tEEeNz1cj0SHUv6EzmVNF8OB0pM= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712754062; c=relaxed/simple; bh=vPU3h8i06cob+By3EKVpz0zEy93AtAhVNbqfRbMfNuw=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=vzWOkkF/dqIxj8TicOnhx9d93l210gaJC1NLVvbgsoHpbUprPnKo8s5k7xCxljTBuGl7fF5l9aceuwdLovNwtMfOjF4wTUivCYBcH5nPFuCbrjrSijCjwgNAIk7VIZKL4l5iNPctFSSO8SLsiK99rRNYv838VpuRiPKQ/NVkmCU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=c4YehABUJ3+tAjfJ38PHeOOTTZCJF8+oLMFgexgp/BeRWFaP1mrIWaOrttJ30EYNpxoZRhdUTnZT0hzMNBFNjE4tfqGle+Eckejxi0L/pnU3Oc7uzBlGu42XqoPL4kvPkqfLJHAJxuFYvyI9AYrPhuwfLJDHfL01+6FKl/eLXcQx8MrJ6nOhMlESY7QR5D5JGTbmEstoP/zqckt2pJwmZixhuGoG0LzgTW68l22mQzhpRYZrWuwyVFzo9qCHYnfjQW1ZmxMRwE6wjtumQHOmVeG8UPoVOw6GOFEsMxDJGxMwE/FiUTDbjTDTfsSNesaXGylFYdivQSi+M9V/G3RjMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QyNFsdIkPMttyfGv9z/oHFOxVsgtv6Zb2iqfUbfCeDA=; b=l1RPLVjhyvJF/2ftbZE/jrvu2PcBh4On/ADxxzgkP8C1zyWTGkS7YmIRKU6jfc+pGZccmpdrwN2n/zPKI64GLv9gko/0Voqsfbg2TXsIgtWhn8BvxSzTg5DaS9LkYBKCHUEHT8oY5DdvfrZE5B8J9QxmwDjVlqT0h8H5Be9kG227++TNheWRV1E6dGM66ha1rlovtxiFyRwCmWJLEp3vOgR/lSX36yG1b4km7a3d/NzzS33D+Q/Vd5tbqR3FUmZfsKx2U2itb42Y+1/MrnkEWlDHQARdZEX0fMec9CTUxVUr67f95IefeJOSNfPUWfT+j8jHRmC+dWZ5ypygEPF0Ew== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyNFsdIkPMttyfGv9z/oHFOxVsgtv6Zb2iqfUbfCeDA=; b=ZBF6+i9d/+uU06ceaka1Ye7EjpXYaaF1e5eisYn/0uwGnAOa+yD5fG6/fRmzrsruCvxFf6j3xmAvEo6MZvTvoLl0xJ+r9YL07dlrNFotuX9H+XPucq8EDzYEVjgD45nwR6uxx976+p3pld+faZKTZ2vw/t8KizfQv52bzlqyJm8= Received: from DUZPR01CA0101.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::22) by DU0PR08MB9558.eurprd08.prod.outlook.com (2603:10a6:10:44d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 13:00:54 +0000 Received: from DU2PEPF0001E9C4.eurprd03.prod.outlook.com (2603:10a6:10:4bb:cafe::9f) by DUZPR01CA0101.outlook.office365.com (2603:10a6:10:4bb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.29 via Frontend Transport; Wed, 10 Apr 2024 13:00:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF0001E9C4.mail.protection.outlook.com (10.167.8.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Wed, 10 Apr 2024 13:00:54 +0000 Received: ("Tessian outbound 1b0f2681ce6f:v300"); Wed, 10 Apr 2024 13:00:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 25e57a18f32e3697 X-CR-MTA-TID: 64aa7808 Received: from 0f637c236067.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 63C63F3B-95DE-4A48-9072-114885164703.1; Wed, 10 Apr 2024 13:00:48 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f637c236067.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Apr 2024 13:00:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nDdCJseheLDHevdsMIANzmRPZAWHkVwLsU8ODtTE7H5EKTiftfxKBt2kG+CRTh265UAf0uray8Lmn2/FTwvURh8khRDY+f2gerpIG/6GnFE7WmAJFiaSXZim1UJfNYnH7mncTW8kREYQwq+cc2VPqz42YMotpLt83Ro0iHixZl7hlfMPZybbvm69WWI9+8ICTWNgGRxsAE1pD5Ohid6RPjC1rCWLxjlXMUV6QTXzHIsESW5vqo7/heWRNjYVCcaTArZdo1Lfhq3cLsIi3EXPpWqdwAMz96TqYHjEz8Erel6I9JEhkARkmhasBqE1oj73iTnZZOf1c3oCjvjKP53+wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QyNFsdIkPMttyfGv9z/oHFOxVsgtv6Zb2iqfUbfCeDA=; b=RtvI/59sEfyoSf6dhNoiSx6s9tSiOlpcmX6GDlMcFNSUZ+rijVB6qDAqMKHr0kCvPo+GxHLfY6EtT33pC8I2aOjeNOE/faeu567NkyXM2Vo1kazXoURute+aNnPuCyG82zjPCpRwLHdYFBn2882a2CG/WLWZuq7Om2jOhX82zhmiQg1tNTQ0gQ/2uDbQuAFCMcz/w1Uuz0SFglv049CJrz1lgeHOLENhgDas94FKDQYpepwFothGXwQ5X2dH4MQIsr4hH1b4fDfo2T0B2az7VURRP2MBxuruVhkPhWy9GpvqVke/LsuldazE1m//+bei1ZO7mZ/f9ZzNqX0hZqZZ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyNFsdIkPMttyfGv9z/oHFOxVsgtv6Zb2iqfUbfCeDA=; b=ZBF6+i9d/+uU06ceaka1Ye7EjpXYaaF1e5eisYn/0uwGnAOa+yD5fG6/fRmzrsruCvxFf6j3xmAvEo6MZvTvoLl0xJ+r9YL07dlrNFotuX9H+XPucq8EDzYEVjgD45nwR6uxx976+p3pld+faZKTZ2vw/t8KizfQv52bzlqyJm8= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB9582.eurprd08.prod.outlook.com (2603:10a6:10:44a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 13:00:41 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.053; Wed, 10 Apr 2024 13:00:36 +0000 Message-ID: <17cbea3f-c385-4ca8-8623-dc2356c922f5@arm.com> Date: Wed, 10 Apr 2024 14:00:33 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb, gdbserver: Add missing install-dvi Makefile target Content-Language: en-US To: Christophe Lyon Cc: gdb-patches@sourceware.org, "binutils@sourceware.org" References: <20240407191027.118770-1-christophe.lyon@linaro.org> <50664a13-d38a-42f8-9fa7-19824afb64a4@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P189CA0043.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB9582:EE_|DU2PEPF0001E9C4:EE_|DU0PR08MB9558:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: obRq5r8FkMmi1IxrHzr5gK1di6osnF6VTg3n3K2aTc9uhoU/oYsFeNJtQuTHg3GCNuDTt0ocBqDHGwdAyS6TSfrPKdtOir5OOdRpHZQD3s4U0aSDVI7EDrbFqjizdS0iFm91yhkGMqOMAqZ1ooLEDL9xEYFcLB+yYGlfY/rtW7zR2Ay0OOY+6ovYmJafYC1EJXajDXyqLi9T4666OGWgd721+ASs3MgcRhwBsVWjYywF22Q2uBJyr6fcwpIZ8+ZqlODApt0DCzNil6GakNrBrB/yG2SUwj5Uy+5PnrV+CScB2RYypBuQ+kHpGR9VZxJaqc1zJkHuNRPN1qJ/82itPLcSMsOp0Mfwj6xOz5MJE2+eyTRDm+BAaYvfRruhKRjEKiMAhy0DEY2GkOJVF4Ctlk2yTsU7GGWV0v2LdN4/FZ9/3slHbemq5q4wi1XgSdaNnbN7JqKDiiaAWrUhpE1NSv86hnmGf1J7uI8QnUDfUAgymqF3uMYs1Uy7A+8kVDvncVN1hR+fgNm0x7jFFp0B9f7Ra9E1DsoJS3kchmlgMQkMTCemFfyJRWsVk+8JaDqyqm8Rdo48eG9pFgQxhmWKRXXxV7TG1xhXBCSaw13yYcltMqH3oYJtHm8x7iWCVTmZOTjNNTloN4CvVmQMrLBPknNQvfPp9+iM2TzFrWViQ08= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9582 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF0001E9C4.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7701f324-e7d8-4e8a-f8fd-08dc595e41dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1dcZs1kUl4ikBKBzbWGq8YEUReAK/pXrkK0l/+dX5K7XfSSGxz8B+MbDBUAlRpvm8TGFn04qfLVhV/sOeWS3YBZeij8qse4DB8dDz1Mfsn+m/oEw2+3aUWP47OxhjpLq3EcRbk323V1dH9o8L63HZbHob9OeIRQ3lfTGkUhHJKI2Fa37jBTskfQQ2Z6vnlSzDKgBZqDbbb0N26Mkk6yqWK99Xdab1g6kMRIruVy/17qt38wuok8ihsLsksHPxOZyZXq2WVjfRHUMnKLKPnKKoRVizPYc2MDBruJEH80AG+EEwhuJBiGMDWHCouLT66NP08ZIfEJs3eGggcxSDzjCvLxIfWRziuxhn/f4wKv5AgFF/iiJL7hxXnYv+FkKxFz+lnW21RYI8aRnIWblYp0XqqIGlhOz7B6fUyJx3D/zo1vzQiYTCojVVWLRKH2lYKILM3dPQyYKPheTzC8m2J1NLnbRECvmtLM5olptiSLBihMy8ND2PFAITTYaYK5dz5AARawiAVq0lpp8FxFJotsSGvgzk0SP9rcUq8/D3jn+ra/Pyca8SEpwHucEHKgVbpK3e6zD9I0LyRGyCnyQTQs6k4h9RmUgOBxO5bBa3IxPUke1syK0DD+Ut/hSVVEGFAggpgGe23l0b4adqxlqGegk2C3e00q3GNTlo4VFBvCylsTHbXiKPF4gLb65XC2gDF8vCftedPzKkjiUMVXpNCD/hwS1xYwLqAyz0cSndh39wsqoJ6pF3SvktrwNsxIdDBuv X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(1800799015)(376005)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:00:54.6475 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7701f324-e7d8-4e8a-f8fd-08dc595e41dd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C4.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9558 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/10/24 11:02, Christophe Lyon wrote: > On Wed, 10 Apr 2024 at 10:10, Christophe Lyon > wrote: >> >> On Wed, 10 Apr 2024 at 01:00, Luis Machado wrote: >>> >>> On 4/7/24 20:10, Christophe Lyon wrote: >>>> For some reason install-dvi is missing although other targets of the >>>> same family are present. This looks like an oversight. >>>> >>>> This enables calling 'make install-dvi' from the top-level build >>>> directory. >>>> >>>> Fix what looks like another oversight: include 'pdf' in 'all-doc' in >>>> gdb/doc/Makefile.in. >>>> --- >>>> gdb/Makefile.in | 2 +- >>>> gdb/data-directory/Makefile.in | 2 +- >>>> gdb/doc/Makefile.in | 19 +++++++++++++++++-- >>>> gdb/testsuite/Makefile.in | 1 + >>>> gdbserver/Makefile.in | 1 + >>>> 5 files changed, 21 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in >>>> index 40732cb2227..d001359539a 100644 >>>> --- a/gdb/Makefile.in >>>> +++ b/gdb/Makefile.in >>>> @@ -2035,7 +2035,7 @@ check-headers: >>>> done >>>> .PHONY: check-headers >>>> >>>> -info install-info clean-info dvi pdf install-pdf html install-html: force >>>> +info install-info clean-info dvi install-dvi pdf install-pdf html install-html: force >>>> @$(MAKE) $(FLAGS_TO_PASS) DO=$@ "DODIRS=$(SUBDIRS)" subdir_do >>>> >>>> # Traditionally "install" depends on "all". But it may be useful >>>> diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in >>>> index 2a40be4ade0..2db8706eba6 100644 >>>> --- a/gdb/data-directory/Makefile.in >>>> +++ b/gdb/data-directory/Makefile.in >>>> @@ -422,7 +422,7 @@ maintainer-clean realclean distclean: clean >>>> .PHONY: install-info install-pdf install-html clean-info >>>> check installcheck: >>>> info dvi pdf html: >>>> -install-info install-pdf install-html: >>>> +install-info install-dvi install-pdf install-html: >>>> clean-info: >>>> >>>> # GNU Make has an annoying habit of putting *all* the Makefile variables >>>> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in >>>> index 04f9dbd27f0..8007f6373d4 100644 >>>> --- a/gdb/doc/Makefile.in >>>> +++ b/gdb/doc/Makefile.in >>>> @@ -24,6 +24,7 @@ prefix = @prefix@ >>>> infodir = @infodir@ >>>> datarootdir = @datarootdir@ >>>> docdir = @docdir@ >>>> +dvidir = @dvidir@ >>>> pdfdir = @pdfdir@ >>>> htmldir = @htmldir@ >>>> mandir = @mandir@ >>>> @@ -87,6 +88,8 @@ SET_TEXINPUTS = \ >>>> # Files which should be generated via 'info' and installed by 'install-info' >>>> INFO_DEPS = gdb.info stabs.info annotate.info >>>> >>>> +# Files which should be generated via 'dvi' and installed by 'install-dvi' >>>> +DVIFILES = gdb.dvi stabs.dvi refcard.dvi annotate.dvi >>>> # Files which should be generated via 'pdf' and installed by 'install-pdf' >>>> PDFFILES = gdb.pdf stabs.pdf refcard.pdf annotate.pdf >>>> # Files which should be generated via 'html' and installed by 'install-html' >>>> @@ -191,7 +194,7 @@ HAVE_NATIVE_GCORE_HOST = @HAVE_NATIVE_GCORE_HOST@ >>>> all: info >>>> >>>> info: $(INFO_DEPS) >>>> -dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi >>>> +dvi: $(DVIFILES) >>>> ps: gdb.ps stabs.ps refcard.ps annotate.ps >>>> html: $(HTMLFILES) >>>> pdf: $(PDFFILES) >>>> @@ -233,7 +236,7 @@ Doxyfile-gdb-xref: $(srcdir)/Doxyfile-gdb-xref.in >>>> Doxyfile-gdbserver: $(srcdir)/Doxyfile-gdbserver.in >>>> $(doxyedit) $(srcdir)/Doxyfile-gdbserver.in >Doxyfile-gdbserver >>>> >>>> -all-doc: info dvi ps # pdf >>>> +all-doc: info dvi ps pdf >>>> diststuff: info man >>>> rm -f gdb-cfg.texi >>>> >>>> @@ -293,6 +296,18 @@ install-html: $(HTMLFILES) >>>> fi; \ >>>> done >>>> >>>> +dvi__strip_dir = `echo $$p | sed -e 's|^.*/||'`; >>>> + >>>> +install-dvi: $(DVIFILES) >>>> + @$(NORMAL_INSTALL) >>>> + test -z "$(dvidir)" || $(mkinstalldirs) "$(DESTDIR)$(dvidir)" >>>> + @list='$(DVIFILES)'; for p in $$list; do \ >>>> + if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \ >>>> + f=$(dvi__strip_dir) \ >>>> + echo " $(INSTALL_DATA) '$$d$$p' '$(DESTDIR)$(dvidir)/$$f'"; \ >>>> + $(INSTALL_DATA) "$$d$$p" "$(DESTDIR)$(dvidir)/$$f"; \ >>>> + done >>>> + >>>> pdf__strip_dir = `echo $$p | sed -e 's|^.*/||'`; >>>> >>>> install-pdf: $(PDFFILES) >>>> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in >>>> index f6603daf7fd..f799f16c2bb 100644 >>>> --- a/gdb/testsuite/Makefile.in >>>> +++ b/gdb/testsuite/Makefile.in >>>> @@ -105,6 +105,7 @@ INFODIRS=doc >>>> info: >>>> install-info: >>>> dvi: >>>> +install-dvi: >>>> pdf: >>>> install-pdf: >>>> html: >>>> diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in >>>> index d12f8746611..4eed8926f48 100644 >>>> --- a/gdbserver/Makefile.in >>>> +++ b/gdbserver/Makefile.in >>>> @@ -342,6 +342,7 @@ installcheck: >>>> check: >>>> info dvi pdf: >>>> install-info: >>>> +install-dvi: >>>> install-pdf: >>>> html: >>>> install-html: >>> >>> I gave this a try and install-dvi almost fully works from the top level, though it still fails for gprofng. >>> >>> Maybe something for the binutils folks? Otherwise this part looks OK to me. >> >> Thanks for checking. Yes IIUC gprofng is part of binutils, and I >> didn't notice because we don't build it ;-) >> > This patch should fix it: > https://sourceware.org/pipermail/binutils/2024-April/133528.html Indeed. I suppose the libdecnumber install-dvi failure will have to be addressed by the master copy. In any case, this looks good. Thanks for fixing it. Approved-By: Luis Machado Tested-By: Luis Machado