From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/9] Use htab_up in auto-load.c
Date: Sun, 19 Jul 2020 21:38:24 -0400 [thread overview]
Message-ID: <18040c91-e106-9047-c834-b16b2afe494d@simark.ca> (raw)
In-Reply-To: <20200718172915.6811-2-tom@tromey.com>
On 2020-07-18 1:29 p.m., Tom Tromey wrote:
> This changes auto-load.c to use htab_up, rather than manually calling
> htab_delete.
>
> gdb/ChangeLog
> 2020-07-18 Tom Tromey <tom@tromey.com>
>
> * auto-load.c (struct auto_load_pspace_info)
> <~auto_load_pspace_info>: Default.
> <loaded_script_files, loaded_script_texts>: Change type to
> htab_up.
> (~auto_load_pspace_info) Remove.
> (init_loaded_scripts_info, maybe_add_script_file)
> (maybe_add_script_text, auto_load_info_scripts): Update.
> ---
> gdb/ChangeLog | 10 ++++++++++
> gdb/auto-load.c | 40 +++++++++++++++++-----------------------
> 2 files changed, 27 insertions(+), 23 deletions(-)
>
> diff --git a/gdb/auto-load.c b/gdb/auto-load.c
> index c967261925a..e21788f481f 100644
> --- a/gdb/auto-load.c
> +++ b/gdb/auto-load.c
> @@ -530,12 +530,12 @@ For more information about this security protection see the\n\
> struct auto_load_pspace_info
> {
> auto_load_pspace_info () = default;
> - ~auto_load_pspace_info ();
> + ~auto_load_pspace_info () = default;
Can't these two just be removed?
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2020-07-20 1:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 17:29 [PATCH 0/9] Use htab_up in more places Tom Tromey
2020-07-18 17:29 ` [PATCH 1/9] Use htab_up in auto-load.c Tom Tromey
2020-07-20 1:38 ` Simon Marchi [this message]
2020-09-17 17:48 ` Tom Tromey
2020-07-18 17:29 ` [PATCH 2/9] Use htab_up in breakpoint.c Tom Tromey
2020-07-18 17:29 ` [PATCH 3/9] Use htab_up in completion_tracker Tom Tromey
2020-07-18 17:29 ` [PATCH 4/9] Use htab_up in filename_seen_cache Tom Tromey
2020-07-20 1:41 ` Simon Marchi
2020-07-18 17:29 ` [PATCH 5/9] Use htab_up in linespec.c Tom Tromey
2020-07-20 1:47 ` Simon Marchi
2020-07-21 0:55 ` Tom Tromey
2020-07-18 17:29 ` [PATCH 6/9] Use htab_up in target-descriptions.c Tom Tromey
2020-07-18 17:29 ` [PATCH 7/9] Use htab_up in typedef_hash_table Tom Tromey
2020-07-18 17:29 ` [PATCH 8/9] Use htab_up in type copying Tom Tromey
2020-09-18 17:32 ` Andrew Burgess
2020-09-18 18:03 ` Tom Tromey
2020-09-18 18:20 ` Andrew Burgess
2020-07-18 17:29 ` [PATCH 9/9] Use htab_up in dwarf2/read.c Tom Tromey
2020-09-17 17:58 ` [PATCH 0/9] Use htab_up in more places Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18040c91-e106-9047-c834-b16b2afe494d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).