From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8C4813857C7E for ; Mon, 20 Jul 2020 01:38:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8C4813857C7E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E66351E792; Sun, 19 Jul 2020 21:38:27 -0400 (EDT) Subject: Re: [PATCH 1/9] Use htab_up in auto-load.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200718172915.6811-1-tom@tromey.com> <20200718172915.6811-2-tom@tromey.com> From: Simon Marchi Message-ID: <18040c91-e106-9047-c834-b16b2afe494d@simark.ca> Date: Sun, 19 Jul 2020 21:38:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200718172915.6811-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 01:38:29 -0000 On 2020-07-18 1:29 p.m., Tom Tromey wrote: > This changes auto-load.c to use htab_up, rather than manually calling > htab_delete. > > gdb/ChangeLog > 2020-07-18 Tom Tromey > > * auto-load.c (struct auto_load_pspace_info) > <~auto_load_pspace_info>: Default. > : Change type to > htab_up. > (~auto_load_pspace_info) Remove. > (init_loaded_scripts_info, maybe_add_script_file) > (maybe_add_script_text, auto_load_info_scripts): Update. > --- > gdb/ChangeLog | 10 ++++++++++ > gdb/auto-load.c | 40 +++++++++++++++++----------------------- > 2 files changed, 27 insertions(+), 23 deletions(-) > > diff --git a/gdb/auto-load.c b/gdb/auto-load.c > index c967261925a..e21788f481f 100644 > --- a/gdb/auto-load.c > +++ b/gdb/auto-load.c > @@ -530,12 +530,12 @@ For more information about this security protection see the\n\ > struct auto_load_pspace_info > { > auto_load_pspace_info () = default; > - ~auto_load_pspace_info (); > + ~auto_load_pspace_info () = default; Can't these two just be removed? Otherwise, LGTM. Simon