From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic313-21.consmr.mail.ir2.yahoo.com (sonic313-21.consmr.mail.ir2.yahoo.com [77.238.179.188]) by sourceware.org (Postfix) with ESMTPS id 837413858409 for ; Mon, 2 Oct 2023 17:50:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 837413858409 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1696269035; bh=d30CMdOTRKIfl7nCI2tOnqLyNaBvVOvFAIehlHUZP1A=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=DyohcLAytZFXYzImTp28+INawiYj8yiXLWpJyMd0tmXywhYtyLML3E/hw22JA3y8FSpsH0ZL1/yvQxq2vZ5a9nzwlxFYN0DYz2gPGHpJBhSREZdgxLsJq1eWea0Xe6PWh7S/60awGaojjgLK9qkz8ZJwRxEL+NmfQgxVBDfmDT6fsToOfahcB47eqhxQdq3RuBbSjJFZwmX6gIZXqKpSL122yvTKUB24vVYBSAdsOZibi0F4/ukBvOcFioeneNc908xiJjJx43OFFSU39P+5PDpiN0RmvyIvniBlB3fERen5bl68ncNDBemfS4/qSYxZo4TjiolfvlzduzBVwqZJZw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1696269035; bh=B7tssI46hvsew1xvgqbWYM/YhBinGTx/Xt/NEMbBN9c=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=NhxgIRPo5/GT2xaae7d75iY4em7G+QmjhdIIJzc4kW/SGP0z8KUh7tQaVRCKcFE1fmoHIxcHzryqzGmP94HK6xwaWvapwOgaZ9Y7BXE5WcpY0tMxHNUa2sx0tcooGzgpdBD0OO5AVJZisNcvcGCdWt7MWLQ90VrDfg8JJ8pD5VKmoiC1u7j2SOG/UrlB2bb/YrwVDhWsoBk4508I6irnnYnf1I3SZGBrXjAKqE8WzR5zP2tmHq5VJaNq8oIcyFUZZfHJzNZm5O3iV9Lm4vCJnVEPh+WKrE2yQBbDSeTMcsbE6R74Q8jC7Lazj0k+NQo4Uct89/gBBlFDBu6Q3K2TyQ== X-YMail-OSG: uP.w3IgVM1lffsT_O9ukSmrvzmFB1TOLodl9iWCLl4ESqsHZa7owqSkh5Ni.Gmn .eBTYnTVhnMEpjIC4vpOhaxy2alLCiILcSkh7BY0XGT2dzQtuzAaK9akoBsWHCWyYVQ2NfWfAYMg VWLzyWcLwKN25F9oS3efGbmhlu1iWFy__qNhn3.mk3kHLQi7PudeQm7EJ2yyQMdWO3_X9J19tqDd 7KFHfkBX0F0OZllb_.di7OJn5A5WXVopNv3h.77vL_RP6Pth5Ac8re.ZMWeC6DM1vLzNqDzmEJBm h29CEwtbjgEfW34Omao0RRktpwW.XfosvOr1FUAY68.nXk.O1.5Xd.tw7TgT3eM2sz1BDiN7ztqU kXP79gLI5ZlP6n5CfoLam1enndBCPe_ZBVBhRg_FwQY3A3aVQ9pMTXaKnM1adpkko6ZBPM8VgbxU rR1UnP8.CV4KabUiEgROj1PqZCJlXb.5H_tEljKgJPlBWMCO6QaGIFzlEySuBBWhDLr5gP3WXrlh KLYRmS1cigQA..Ie_G6FUEEZabayli4NMdpOcrFELEKI2K4QZZXEgen3oq85VUvroaLGPQ1JsP8Z Ya3No0fJL3L4uyABD5TscnfnpwiRh6eJxyfcQDaOBysBuewoEl_ZHVE1NjyVrxG9LpuLAXBKZ1RI EmLzCP7vya3ziG3BEunTbZk.QLDFJA7.nV2fVpxGCYMgunU18QRfoGnJSxwF9VwhtfSuXlir.89Z zC9SLxFPwmffIfEZLTLJJ2rmJvwxD1i_5NyXLaJ6NOrYv_x4GzNYFyh_qmcdpg6snY9iaOQtTdla pW_SAM3KxCpvBKyRuWSTMyfJiLy4CVpI6hsfaycIrn58OckhPyAhxHGUR_mTGvSF8buYuzXt_XNM m5Urtkq4IU7c1I7CaOib2ybiu39ER9sd12nOAoK.BiAorDbozwPt6DId9wg896LedSvyzS9fexCR n.ycil6YF4SpxoHn3X5r_GWIy_fFETUf0TRq8zfEt5hXR21vsKe7JZe8eFAtu3T0_47zTXm_7zEQ Xl17SlW3alISBFzMr0ee5VYyxMSuttj4xR_ZbyioZV3XC9rdBl0mcW5hg6ZA4cDO_.pnhav2BTG2 ecqnr.BRgBk9p5exyX9laWTTf7aoXTz1EVNCaQLs_omB.erSeSVCOZGhdc.8cTwZysK6CRvuT8ck KrLVBzjQzC3hKeYAvsgqB5GwVj071UlXuWt40DdDFFXiWg5yAsJjv67_7mHw3Iyn0urxqpj8YUSX Z.Gaxa7So92qhT00EkX1mzBfn8kswWICPGfx_DWgCJg9RgEkG0TSpjV.zYdjg_0cR2sFc.H_RwVa yrAvdNUQwrni5OXWxQz5Qz.SrsQunJjocBc5Mty4yLHxP4PphpoLeoj2TjqgaR2UemA8JJwt72qJ pttN3yD8YkhDi7RmHzk.jZA5vmfjWEAzcr77FdqG2aI57caKZYrMOT6m2BDlk2SDBOb6jrRK9uKO mSCAQ.5U1Qi1e__z8hxZpG7Uuq2xL_3wtjuUgdrQiE1pkUJSQ7nn93d_rUdBK4LuVKqgqeara44D 7wGwDS8cSuWI95dyjpt13cjnnFs6ZxxGul.CWyeNeqKcPE2oMcWk3d1__rY0zgy55YAkdHDKNYcP VMizsBvzjwMHppx21_wnkVn9iu7s7T9p2BatQ_DUyluECFU4nPMIaE_d1Bg0U1UKojftDFlppOJG D7Ak.OegZdArwPYQ8LjNhm4Pbh0Gan.csSNO9e6Ia7FYdhlISn.qaokSNqle0mX1kmY8gt9V_Z1L _svK77QDEO3vPUog51fTk9Eri6InH5yMyl4lCTyoBy9Tgifm3aDuIBL42Ztq6BbHht8R8Ab0wXiv lMMqQjJPBFBxr96_nXcYa_R2RG26yFQToiN5k3lUq1bNHceIDgc1iYztGowlIOhkHswJjA3YR76u pMH1BQO4JhoiJeM2xuJi84F1Zzt6.7b6Vtc8eCSCIqbMt9aBAtNaqZCjSawxkRD71YEKbQyZkX4e 76isF6LEpoIqN3oOfBQ.sJt9B9E7R8Or78WaxKBxsqvX2rE.gvwu7swdQIVhB.NLJpzxxv_uH6WZ 7dIukAsCckclg70INBgOPkV0U2aEzvroeiWddiEp3WsgFDXy87BL7S7YUprbcn7qIipc2yFOpv4r zwY.Ff.bQ7wctwy5ZM_OyaxdBkllEVQ9OD0Hzl7.JR_Ovt1Kt6XnClLekjRRuPzstMEX0R0BLanv CHornhtEYg2mY8A-- X-Sonic-MF: X-Sonic-ID: 27d9b6ea-ec02-4ee0-ab5b-28485e5fe055 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Mon, 2 Oct 2023 17:50:35 +0000 Date: Mon, 2 Oct 2023 17:50:30 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" Message-ID: <1856017925.2892615.1696269030810@mail.yahoo.com> In-Reply-To: <20230914162732.2077-1-ssbssa@yahoo.de> References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 YMailNorrin X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. Am Donnerstag, 14. September 2023, 18:28:30 MESZ hat Hannes Domani via Gdb-= patches Folgendes geschrieben: > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > caused a regression that meant hardware watchpoint stops would not > trigger in reverse execution or replay mode.=C2=A0 This was documented in > PR breakpoints/21969. > The problem is that record_check_stopped_by_breakpoint always overwrites > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT > value which would be checked afterwards. > > This commit fixes that by checking if record_full_stop_reason is > TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > --- > gdb/record-full.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 4 +++- > gdb/testsuite/gdb.reverse/watch-reverse.exp | 4 ++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/record-full.c b/gdb/record-full.c > index faf8b595d22..da785ef4b2a 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -1382,7 +1382,9 @@ record_full_wait_1 (struct target_ops *ops, > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 /* check breakpoint */ >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 tmp_pc =3D regcache_read_pc (regcache); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (record_check_stopped_by_breakpoint > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (record_full_stop_reason > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 !=3D TARGET_STOPPED_BY_WATCHPOINT > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 && record_check_stopped_by_breakpoint >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (aspace, tmp_pc, &record_full_stop_reason)) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 if (record_debug) > diff --git a/gdb/testsuite/gdb.reverse/watch-reverse.exp b/gdb/testsuite/= gdb.reverse/watch-reverse.exp > index 6b81a6fdf88..a7126ac9b1d 100644 > --- a/gdb/testsuite/gdb.reverse/watch-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/watch-reverse.exp > @@ -118,8 +118,12 @@ gdb_test "continue" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*\[Ww\]atchpoint.*ival3.*Old value =3D 0.*New v= alue =3D -1.*ival3 =3D count; ival4 =3D count;.*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "watchpoint hit in reverse, fifth time" > > +gdb_test_no_output "disable \$bpnum" "disable non-hw watchpoint" > + > gdb_test_no_output "set can-use-hw-watchpoints 1" "enable hw watchpoints" > > +gdb_test_no_output "enable \$bpnum" "enable hw watchpoint" > + > ### > ### > ### > -- > 2.35.1