public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Always fix system DLL paths for 32bit programs
Date: Fri, 27 Mar 2020 21:50:28 +0000 (UTC)	[thread overview]
Message-ID: <1869776193.27888.1585345828777@mail.yahoo.com> (raw)
In-Reply-To: <83k1367wwq.fsf@gnu.org>

 Am Freitag, 27. März 2020, 16:08:03 MEZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:

> > Date: Fri, 27 Mar 2020 12:46:14 +0100
>
> > From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> >
> > GetModuleFileNameEx might also return the 64bit system directory for 32bit
> > programs even for a 32bit gdb:
> >
> > (gdb) info sharedlibrary
> > >From        To          Syms Read  Shared Object Library
> > 0x779d0000  0x77b34d20  Yes (*)    C:\Windows\SysWOW64\ntdll.dll
> > 0x76850000  0x7694ad9c  Yes (*)    C:\Windows\syswow64\kernel32.dll
> > 0x75421000  0x75466a18  Yes (*)    C:\Windows\syswow64\KernelBase.dll
> > 0x6fbe1000  0x6fcca1c0  Yes (*)    C:\Windows\system32\dbghelp.dll
> > 0x76d31000  0x76ddb2c4  Yes (*)    C:\Windows\syswow64\msvcrt.dll
> >
> > So this makes the path conversion for all 32bit programs.
> >
> > gdb/ChangeLog:
> >
> > 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
> >
> >     * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
>
>
> Thanks, this LGTM.

Pushed, thanks.


Regards
Hannes Domani

      reply	other threads:[~2020-03-27 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200327114614.5612-1-ssbssa.ref@yahoo.de>
2020-03-27 11:46 ` Hannes Domani
2020-03-27 13:24   ` Eli Zaretskii
2020-03-27 21:50     ` Hannes Domani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1869776193.27888.1585345828777@mail.yahoo.com \
    --to=ssbssa@yahoo.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).