* [PATCH v3 2/2] Add test for user context selection sync
2016-09-24 21:45 [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Simon Marchi
@ 2016-09-24 20:13 ` Simon Marchi
2016-10-03 17:10 ` Pedro Alves
2016-09-25 12:41 ` [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Eli Zaretskii
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Simon Marchi @ 2016-09-24 20:13 UTC (permalink / raw)
To: gdb-patches; +Cc: Antoine Tremblay
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
New in v3:
* No more sleeps in the C code, which makes the test a bit
faster to run.
* Use scheduler-locking to bring threads to their designated
position in all-stop.
* Consume MI output after "start" and many other places, so we
don't deadlock or wrongfully match a previous MI event (thanks
to Pedro for figuring this out).
* Use [^\r\n]* instead of .* in many places to avoid matching
too much.
* The CLI event test of "-thread-select --thread 2 2" is
commented out (to avoid having to wait the the timeout every
time when we know it will never arrive) and kfailed.
This patch adds a test to verify that events are sent properly to all
UIs when the user selection context (inferior, thread, frame) changes.
The goal of the C test file is to provide two threads that are stopped with the
same predictable backtrace (so that we can test frame switching). The barrier
helps us know when the child threads are started. Then, scheduler-locking is
used to bring each thread one by one to the position we expect them to be
during the test.
gdb/testsuite/ChangeLog:
YYYY-MM-DD Antoine Tremblay <antoine.tremblay@ericsson.com>
YYYY-MM-DD Simon Marchi <simon.marchi@ericsson.com>
PR gdb/20487
* gdb.mi/user-selected-context-sync.exp: New file.
* gdb.mi/user-selected-context-sync.c: New file.
---
gdb/testsuite/gdb.mi/user-selected-context-sync.c | 63 +
.../gdb.mi/user-selected-context-sync.exp | 1285 ++++++++++++++++++++
2 files changed, 1348 insertions(+)
create mode 100644 gdb/testsuite/gdb.mi/user-selected-context-sync.c
create mode 100644 gdb/testsuite/gdb.mi/user-selected-context-sync.exp
diff --git a/gdb/testsuite/gdb.mi/user-selected-context-sync.c b/gdb/testsuite/gdb.mi/user-selected-context-sync.c
new file mode 100644
index 0000000..2ef7437
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/user-selected-context-sync.c
@@ -0,0 +1,63 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2016 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+*/
+
+#include <pthread.h>
+#include <unistd.h>
+
+#define NUM_THREADS 2
+
+static pthread_barrier_t barrier;
+
+static void
+child_sub_function (void)
+{
+ while (1); /* thread loop line */
+}
+
+static void *
+child_function (void *args)
+{
+ pthread_barrier_wait (&barrier);
+
+ child_sub_function (); /* thread caller line */
+
+ return NULL;
+}
+
+int
+main (void)
+{
+ int i = 0;
+ pthread_t threads[NUM_THREADS];
+
+ /* Make the test exit eventually. */
+ alarm (20);
+
+ /* Initialize the barrier, NUM_THREADS plus the main thread. */
+ pthread_barrier_init (&barrier, NULL, NUM_THREADS + 1);
+
+ for (i = 0; i < NUM_THREADS; i++)
+ pthread_create (&threads[i], NULL, child_function, NULL);
+
+ pthread_barrier_wait (&barrier);
+
+ while (1); /* main break line */
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.mi/user-selected-context-sync.exp b/gdb/testsuite/gdb.mi/user-selected-context-sync.exp
new file mode 100644
index 0000000..9f5176b
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/user-selected-context-sync.exp
@@ -0,0 +1,1285 @@
+# Copyright 2016 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# This test checks that the "thread", "select-frame", "frame" and "inferior"
+# CLI commands, as well as the "-thread-select" and "-stack-select-frame" MI
+# commands send the appropriate user-selection-change events to all UIs.
+#
+# This test considers the case where console and MI are two different UIs,
+# and MI is created with the new-ui command.
+#
+# It also considers the case where the console commands are sent directly in
+# the MI channel as described in PR 20487.
+#
+# It does so by starting 2 inferiors with 3 threads each.
+# - Thread 1 of each inferior is the main thread, starting the others.
+# - Thread 2 of each inferior is stopped at /* thread loop line */.
+# - Thread 3 of each inferior is either stopped at /* thread loop line */, if we
+# are using all-stop, or running, if we are using non-stop.
+
+load_lib mi-support.exp
+
+standard_testfile
+
+# Multiple inferiors are needed, therefore only native gdb and extended
+# gdbserver modes are supported.
+if [use_gdb_stub] {
+ untested ${testfile}.exp
+ return
+}
+
+set compile_options "debug pthreads"
+if {[build_executable $testfile.exp $testfile ${srcfile} ${compile_options}] == -1} {
+ untested "failed to compile $testfile"
+ return -1
+}
+
+set main_break_line [gdb_get_line_number "main break line"]
+set thread_loop_line [gdb_get_line_number "thread loop line"]
+set thread_caller_line [gdb_get_line_number "thread caller line"]
+
+# Call PROCNAME with the given arguments, inside a with_test_prefix $procname
+# block.
+
+proc with_test_prefix_procname { procname args } {
+ with_test_prefix $procname {
+ # Note: this syntax requires TCL 8.5, if we need to support 8.4,
+ # we'll need to find an alternative.
+ $procname {*}$args
+ }
+}
+
+# Return whether we expect thread THREAD to be running in mode MODE.
+#
+# MODE can be either "all-stop" or "non-stop".
+# THREAD can be either a CLI thread id (e.g. 2.3) or an MI thread id (e.g. 6).
+
+proc thread_is_running { mode thread } {
+ if { $mode != "non-stop" } {
+ return 0
+ }
+
+ return [expr {
+ $thread == 1.3
+ || $thread == 2.3
+ || $thread == 3
+ || $thread == 6
+ }]
+}
+
+# Make a regular expression to match the various inferior/thread/frame selection
+# events for CLI.
+#
+# MODE can be either "all-stop" or "non-stop", indicating which one is currently
+# in use.
+# INF is the inferior number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce an inferior switch.
+# THREAD is the thread number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce a thread switch.
+# FRAME is the frame number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce a frame switch. See the FRAME_RE variable for
+# details.
+
+proc make_cli_re { mode inf thread frame } {
+ global srcfile
+ global thread_caller_line
+ global thread_loop_line
+ global main_break_line
+ global decimal
+
+ set any "\[^\r\n\]*"
+
+ set cli_re ""
+
+ set inf_re "\\\[Switching to inferior $inf${any}\\\]"
+ set all_stop_thread_re "\\\[Switching to thread [string_to_regexp $thread]${any}\\\]"
+
+ set frame_re(0) "#0${any}child_sub_function$any$srcfile:$thread_loop_line\r\n${any}thread loop line \\\*/"
+ set frame_re(1) "#1${any}child_function \\\(args=0x0\\\) at ${any}$srcfile:$thread_caller_line\r\n$thread_caller_line${any}/\\\* thread caller line \\\*/"
+
+ # Special frame for main thread.
+ set frame_re(2) "#0${any}\r\n${main_break_line}${any}"
+
+ if { $inf != -1 } {
+ append cli_re $inf_re
+ }
+
+ if { $thread != -1 } {
+ if { $inf != -1 } {
+ append cli_re "\r\n"
+ }
+ set thread_re $all_stop_thread_re
+
+ if [thread_is_running $mode $thread] {
+ set thread_re "$thread_re\\\(running\\\)"
+ }
+
+ append cli_re $thread_re
+ }
+
+ if { $frame != -1 } {
+ if { $thread != -1 } {
+ append cli_re "\r\n"
+ }
+ append cli_re $frame_re($frame)
+ }
+
+ return $cli_re
+}
+
+# Make a regular expression to match the various inferior/thread/frame selection
+# events for MI.
+#
+# MODE can be either "all-stop" or "non-stop", indicating which one is currently
+# in use.
+# THREAD is the thread number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce a thread switch.
+# If EVENT is 1, build a regex for an "=thread-selected" async event.
+# Otherwise, build a regex for a response to a command.
+# FRAME is the frame number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce a frame switch. See the FRAME_RE variable for
+# details.
+
+proc make_mi_re { mode thread frame type } {
+ global srcfile
+ global hex
+ global decimal
+ global thread_loop_line
+ global main_break_line
+ global thread_caller_line
+
+ set any "\[^\r\n\]*"
+
+ set mi_re ""
+
+ set thread_event_re "=thread-selected,id=\"$thread\""
+ set thread_answer_re "\\^done,new-thread-id=\"$thread\""
+
+ set frame_re(0) ",frame=\{level=\"0\",addr=\"$hex\",func=\"child_sub_function\",args=\\\[\\\],file=\"${any}${srcfile}\",fullname=\"${any}${srcfile}\",line=\"$thread_loop_line\"\}"
+ set frame_re(1) ",frame=\{level=\"1\",addr=\"$hex\",func=\"child_function\",args=\\\[\{name=\"args\",value=\"0x0\"\}\\\],file=\"${any}${srcfile}\",fullname=\"${any}${srcfile}\",line=\"$thread_caller_line\"\}"
+
+ # Special frame for main thread.
+ set frame_re(2) ",frame=\{level=\"0\",addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\"${any}${srcfile}\",fullname=\"${any}${srcfile}\",line=\"${main_break_line}\"\}"
+
+ if { $thread != -1 } {
+ if { $type == "event" } {
+ append mi_re $thread_event_re
+ } elseif { $type == "response" } {
+ append mi_re $thread_answer_re
+ } else {
+ error "Invalid value for EVENT."
+ }
+ }
+
+ if { $frame != -1 } {
+ append mi_re $frame_re($frame)
+ }
+
+ if { $type == "event" } {
+ append mi_re "\r\n"
+ }
+
+ return $mi_re
+}
+
+# Make a regular expression to match the various inferior/thread/frame selection
+# events when issuing CLI commands inside MI.
+#
+# COMMAND is the CLI command that was sent to GDB, which will be output in the
+# console output stream.
+# CLI_IN_MI_MODE indicates which method of CLI-in-MI command is used. It can be
+# either "direct" of "interpreter-exec".
+# MODE can be either "all-stop" or "non-stop", indicating which one is currently
+# in use.
+# If EVENT is 1, expect a =thread-select MI event.
+# INF is the inferior number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce an inferior switch.
+# CLI_THREAD is the thread number as seen in the CLI (inferior-qualified) we are
+# expecting GDB to switch to, or -1 if we are not expecting GDB to announce a
+# thread switch.
+# MI_THREAD is the thread number as seen in the MI (global number) we are
+# expecting GDB to switch to, or -1 if we are not expecting GDB to announce a
+# thread switch.
+# FRAME is the frame number we are expecting GDB to switch to, or -1 if we are
+# not expecting GDB to announce a frame switch. See the FRAME_RE variable for
+# details.
+
+proc make_cli_in_mi_re { command cli_in_mi_mode mode event inf cli_thread
+ mi_thread frame } {
+ global srcfile
+ global thread_loop_line
+ global main_break_line
+ global thread_caller_line
+
+ set any "\[^\r\n\]*"
+
+ set command_re [string_to_regexp $command]
+ set cli_in_mi_re "$command_re\r\n"
+
+ if { $cli_in_mi_mode == "direct" } {
+ append cli_in_mi_re "&\"$command_re\\\\n\"\r\n"
+ }
+
+ set frame_re(0) "~\"#0${any}child_sub_function${any}$srcfile:$thread_loop_line\\\\n\"\r\n~\"${thread_loop_line}${any}thread loop line \\\*/\\\\n\"\r\n"
+ set frame_re(1) "~\"#1${any}child_function \\\(args=0x0\\\) at ${any}$srcfile:$thread_caller_line\\\\n\"\r\n~\"$thread_caller_line${any}thread caller line \\\*/\\\\n\"\r\n"
+
+ # Special frame for main thread.
+ set frame_re(2) "~\"#0${any}main${any}\\\\n\"\r\n~\"${main_break_line}${any}\"\r\n"
+
+ if { $inf != -1 } {
+ append cli_in_mi_re "~\""
+ append cli_in_mi_re [make_cli_re $mode $inf -1 -1]
+ append cli_in_mi_re "\\\\n\"\r\n"
+ }
+
+ if { $cli_thread != "-1" } {
+ append cli_in_mi_re "~\""
+ append cli_in_mi_re [make_cli_re $mode -1 $cli_thread -1]
+ append cli_in_mi_re "\\\\n\"\r\n"
+ }
+
+ if { $frame != -1 } {
+ append cli_in_mi_re $frame_re($frame)
+ }
+
+ if { $event == 1 } {
+ append cli_in_mi_re [make_mi_re $mode $mi_thread $frame event]
+ }
+
+ append cli_in_mi_re "\\^done"
+
+ return $cli_in_mi_re
+}
+
+# Return the current value of the "scheduler-locking" parameter.
+
+proc show_scheduler_locking { } {
+ global gdb_prompt
+ global expect_out
+
+ set any "\[^\r\n\]*"
+
+ set test "show scheduler-locking"
+ gdb_test_multiple $test $test {
+ -re ".*Mode for locking scheduler during execution is \"(${any})\".\r\n$gdb_prompt " {
+ pass $test
+ return $expect_out(1,string)
+ }
+ }
+
+ error "Couldn't get current scheduler-locking value."
+}
+
+# Prepare inferior INF so it is in the state we expect (see comment at the top).
+
+proc test_continue_to_start { mode inf } {
+ global gdb_spawn_id
+ global mi_spawn_id
+ global gdb_main_spawn_id
+ global srcfile
+ global main_break_line
+ global thread_loop_line
+ global decimal
+ global gdb_prompt
+
+ set any "\[^\r\n\]*"
+
+ if { $gdb_spawn_id != $gdb_main_spawn_id } {
+ error "This should not happen."
+ }
+
+ with_test_prefix "inferior $inf" {
+ with_spawn_id $gdb_main_spawn_id {
+ # Continue to the point where we know for sure the threads are
+ # started.
+ gdb_test "tbreak $srcfile:$main_break_line" \
+ "Temporary breakpoint ${any}" \
+ "set breakpoint in main"
+
+ gdb_continue_to_breakpoint "main breakpoint"
+
+ # Consume MI event output.
+ with_spawn_id $mi_spawn_id {
+ mi_expect_stop "breakpoint-hit" "main" "" "$srcfile" \
+ "$decimal" {"" "disp=\"del\""} "stop at breakpoint in main"
+ }
+
+ if { $mode == "all-stop" } {
+ set previous_schedlock_val [show_scheduler_locking]
+
+ # Set scheduler-locking on, so that we can control threads
+ # independently.
+ gdb_test_no_output "set scheduler-locking on"
+
+ # Continue each child thread to the point we want them to be.
+ foreach thread { 2 3 } {
+ gdb_test "thread $inf.$thread" ".*" "select child thread $inf.$thread"
+
+ gdb_test "tbreak $srcfile:$thread_loop_line" \
+ "Temporary breakpoint ${any}" \
+ "set breakpoint for thread $inf.$thread"
+
+ gdb_continue_to_breakpoint "continue thread $inf.$thread to infinite loop breakpoint"
+
+ # Consume MI output.
+ with_spawn_id $mi_spawn_id {
+ mi_expect_stop "breakpoint-hit" "child_sub_function" \
+ "" "$srcfile" "$decimal" {"" "disp=\"del\""} \
+ "thread $inf.$thread stops MI"
+ }
+ }
+
+ # Restore scheduler-locking to its original value.
+ gdb_test_no_output "set scheduler-locking $previous_schedlock_val"
+ } else { # $mode == "non-stop"
+ # Put a thread-specific breakpoint for thread 2 of the current
+ # inferior. We don't put a breakpoint for thread 3, since we
+ # want to let it run.
+ set test "set thread-specific breakpoint, thread $inf.2"
+ gdb_test_multiple "tbreak $srcfile:$thread_loop_line thread $inf.2" $test {
+ -re "Temporary breakpoint ${any}\r\n$gdb_prompt " {
+ pass $test
+ }
+ }
+
+ # Confirm the stop of thread $inf.2.
+ set test "thread $inf.2 stops CLI"
+ gdb_test_multiple "" $test {
+ -re "Thread $inf.2 ${any} hit Temporary breakpoint ${any}\r\n$thread_loop_line${any}\r\n" {
+ pass $test
+ }
+ }
+
+ # Consume MI output.
+ with_spawn_id $mi_spawn_id {
+ mi_expect_stop "breakpoint-hit" "child_sub_function" \
+ "" "$srcfile" "$decimal" {"" "disp=\"del\""} \
+ "thread $inf.2 stops MI"
+ }
+ }
+ }
+ }
+}
+
+# Prepare the test environment.
+#
+# MODE can be either "all-stop" or "non-stop".
+
+proc test_setup { mode } {
+ global srcfile
+ global srcdir
+ global subdir
+ global gdb_main_spawn_id
+ global mi_spawn_id
+ global decimal
+ global binfile
+ global GDBFLAGS
+ global async
+
+ set any "\[^\r\n\]*"
+
+ mi_gdb_exit
+
+ save_vars { GDBFLAGS } {
+ if { $mode == "non-stop" } {
+ set GDBFLAGS [concat $GDBFLAGS " -ex \"set non-stop 1\""]
+ }
+
+ if { [mi_gdb_start "separate-mi-tty"] != 0 } {
+ return
+ }
+ }
+
+ mi_delete_breakpoints
+ mi_gdb_reinitialize_dir $srcdir/$subdir
+ mi_gdb_load $binfile
+
+ if { [mi_runto main] < 0 } {
+ fail "Can't run to main"
+ return
+ }
+
+ # When using mi_expect_stop, we don't expect a prompt after the *stopped
+ # event, since the blocking commands are done from the CLI. Seting async to
+ # 1 makes it not expect the prompt.
+ set async 1
+
+ with_spawn_id $gdb_main_spawn_id {
+ # Add the second inferior now. While this is not mandatory, it allows
+ # us to assume that per-inferior thread numbering will be used,
+ # simplifying test_continue_to_start a bit (Thread 1.2 and not Thread 2).
+ gdb_test "add-inferior" "Added inferior 2" "Add inferior 2"
+
+ # Prepare the first inferior for the test.
+ test_continue_to_start $mode 1
+
+ # Switch to and start the second inferior.
+ gdb_test "inferior 2" "\\\[Switching to inferior 2${any}\\\]" "switch to inferior 2"
+ gdb_load ${binfile}
+
+ # Doing "start" on the CLI generates a ton of MI output. At some point,
+ # if we don't consume/match it, the buffer between GDB's MI channel and
+ # Expect will get full, GDB will block on a write system call and we'll
+ # deadlock, waiting for CLI output that will never arrive. And then
+ # we're sad. So instead of using gdb_test and expect CLI output, send
+ # the start command first, then consume MI output, and finally consume
+ # CLI output.
+ send_gdb "start\n"
+
+ with_spawn_id $mi_spawn_id {
+ mi_expect_stop "breakpoint-hit" "main" "" "$srcfile" "$decimal" \
+ {"" "disp=\"del\""} "main stop"
+ }
+
+ # Consume CLI output.
+ gdb_test "" "Temporary breakpoint.*Starting program.*"
+
+ # Prepare the second inferior for the test.
+ test_continue_to_start $mode 2
+ }
+}
+
+# Reset the selection to frame #0 of thread THREAD.
+
+proc reset_selection { thread } {
+ global gdb_main_spawn_id
+
+ set any "\[^\r\n\]*"
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread $thread" \
+ "\\\[Switching to thread $thread ${any}\\\].*" \
+ "reset selection to thread $thread"
+ gdb_test "frame 0" ".*" "reset selection to frame 0"
+ }
+}
+
+# Flush Expect's internal buffers for both CLI and MI.
+#
+# The idea here is to send a command, and to consume all the characters that we
+# expect that command to output, including the following prompt. Using gdb_test
+# and mi_gdb_test should do that.
+
+proc flush_buffers { } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "print 444" "= 444" "flush CLI"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "555-data-evaluate-expression 666" ".*done,value=\"666\"" "flush MI"
+ }
+}
+
+# Run a command on the current spawn id, to confirm that no output is pending
+# in Expect's internal buffer. This is used to ensure that nothing was output
+# on the spawn id since the call to gdb_test/mi_gdb_test/flush_buffers.
+#
+# The key here is that the regexes use start-of-buffer anchors (^), ensuring
+# that they match the entire buffer, confirming that there was nothing in it
+# before.
+
+proc ensure_no_output { test } {
+ global gdb_spawn_id gdb_main_spawn_id mi_spawn_id
+ global decimal
+
+ if { $gdb_spawn_id == $gdb_main_spawn_id } {
+ # CLI
+ gdb_test "print 666" \
+ "^print 666\r\n\\\$$decimal = 666" \
+ "$test, ensure no output CLI"
+ } elseif { $gdb_spawn_id == $mi_spawn_id } {
+ # MI
+ mi_gdb_test "777-data-evaluate-expression 888" \
+ "^777-data-evaluate-expression 888\r\n777\\^done,value=\"888\"" \
+ "$test, ensure no output MI"
+ } else {
+ error "Unexpected gdb_spawn_id value."
+ }
+}
+
+# Match a regular expression, or ensure that there was no output.
+#
+# If RE is non-empty, try to match the content of the program output (using the
+# current spawn_id) and pass/fail TEST accordingly.
+# If RE is empty, ensure that the program did not output anything.
+
+proc match_re_or_ensure_not_output { re test } {
+ if { $re != "" } {
+ gdb_expect {
+ -re "$re" {
+ pass $test
+ }
+
+ default {
+ fail $test
+ }
+ }
+ } else {
+ ensure_no_output $test
+ }
+}
+
+# Test selecting an inferior from CLI.
+
+proc test_cli_inferior { mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ reset_selection "1.1"
+
+ set mi_re [make_mi_re $mode 4 2 event]
+ set cli_re [make_cli_re $mode 2 2.1 2]
+
+ flush_buffers
+
+ # Do the 'inferior' command.
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "inferior 2" $cli_re "CLI select inferior"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "event on MI"
+ }
+
+ # Do the 'inferior' command on the currently selected inferior. For now,
+ # GDB naively re-outputs everything.
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "inferior 2" $cli_re "CLI select inferior again"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "event on MI again"
+ }
+}
+
+# Test thread selection from CLI.
+
+proc test_cli_thread { mode } {
+ global gdb_main_spawn_id
+ global mi_spawn_id
+
+ set any "\[^\r\n\]*"
+
+ reset_selection "1.1"
+ flush_buffers
+
+ with_test_prefix "thread 1.2" {
+ # Do the 'thread' command to select a stopped thread.
+
+ set mi_re [make_mi_re $mode 2 0 event]
+ set cli_re [make_cli_re $mode -1 1.2 0]
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread 1.2" $cli_re "select thread"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select thread, event on MI "
+ }
+
+ # Do the 'thread' command to select the same thread. We shouldn't receive
+ # an event on MI, since we won't actually switch thread.
+
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread 1.2" $cli_re "select thread again"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select thread, event on MI again"
+ }
+
+ # Try the 'thread' command without arguments.
+
+ set cli_re "\\\[Current thread is 1\\.2.*\\\]"
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread" $cli_re "thread without args"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "thread without args, event on MI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Do the 'thread' command to select the third thread, stopped on all-stop,
+ # running on non-stop.
+
+ if { $mode == "all-stop" } {
+ set cli_re [make_cli_re $mode -1 1.3 0]
+ set mi_re [make_mi_re $mode 3 0 event]
+ } else {
+ set cli_re [make_cli_re $mode -1 1.3 -1]
+ set mi_re [make_mi_re $mode 3 -1 event]
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread 1.3" $cli_re "select thread"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select thread, event on MI"
+ }
+
+ # Do the 'thread' command to select the third thread again. Again, we
+ # shouldn't receive an event on MI.
+
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread 1.3" $cli_re "select thread again"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select thread again, event on MI"
+ }
+
+ # Try the 'thread' command without arguments.
+
+ set cli_re "\\\[Current thread is 1\\.3 ${any}\\\]"
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "thread" $cli_re "thread without args"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "thread without args, event on MI"
+ }
+ }
+
+ # Idea for the future: selecting a thread in a different inferior. For now,
+ # GDB doesn't show an inferior switch, but if it did, it would be a nice
+ # place to test it.
+}
+
+# Test frame selection from CLI.
+
+proc test_cli_frame { mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ with_test_prefix "thread 1.2" {
+ reset_selection "1.2"
+ flush_buffers
+
+ # Do the 'frame' command to select frame 1.
+
+ set mi_re [make_mi_re $mode 2 1 event]
+ set cli_re [make_cli_re $mode -1 -1 1]
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "frame 1" $cli_re "select frame 1"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1, event on MI"
+ }
+
+ # Do the 'frame' command to select the same frame. This time we don't
+ # expect an event on MI, since we won't actually change frame.
+
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "frame 1" $cli_re "select frame 1 again"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1 again, event on MI"
+ }
+
+ # Do the 'frame' command without arguments. We shouldn't see anything on MI.
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "frame" $cli_re "frame without args"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "frame without args, event on MI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Now, try the 'frame' command on thread 3, which is running if we are in
+ # non-stop mode.
+ reset_selection "1.3"
+ flush_buffers
+
+ if {$mode == "all-stop"} {
+ set mi_re [make_mi_re $mode 3 1 event]
+ set cli_re [make_cli_re $mode -1 -1 1]
+ } elseif {$mode == "non-stop"} {
+ set mi_re ""
+ set cli_re "Selected thread is running\\."
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "frame 1" $cli_re "select frame 1"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1, event on MI"
+ }
+
+ # Do the 'frame' command without arguments.
+
+ if { $mode == "non-stop" } {
+ set cli_re "No stack\\."
+ }
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "frame" $cli_re "frame without args"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "frame without args, event on MI"
+ }
+ }
+}
+
+# Test frame selection from CLI with the select-frame command.
+
+proc test_cli_select_frame { mode } {
+ global gdb_main_spawn_id mi_spawn_id expect_out
+
+ with_test_prefix "thread 1.2" {
+ reset_selection "1.2"
+ flush_buffers
+
+ # Do the 'select-frame' command to select frame 1.
+
+ set mi_re [make_mi_re $mode 2 1 event]
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test_no_output "select-frame 1" "select frame 1"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1, event on MI"
+ }
+
+ # Do the 'select-frame' command to select the same frame. This time we expect to
+ # event on MI, since we won't actually change frame.
+
+ set mi_re ""
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test_no_output "select-frame 1" "select frame 1 again"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1 again, event on MI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Now, try the 'select-frame' command on thread 3, which is running if we are in
+ # non-stop mode.
+ reset_selection "1.3"
+ flush_buffers
+
+ if {$mode == "all-stop"} {
+ set mi_re [make_mi_re $mode 3 1 event]
+ } elseif {$mode == "non-stop"} {
+ set mi-re ""
+ set cli_re "Selected thread is running\\."
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ if { $mode == "all-stop" } {
+ gdb_test_no_output "select-frame 1" "select frame 1"
+ } else {
+ gdb_test "select-frame 1" $cli_re "select frame 1"
+ }
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "select frame 1, event on MI"
+ }
+ }
+}
+
+# Test doing an up and then down command from CLI.
+
+proc test_cli_up_down { mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ reset_selection "1.2"
+ flush_buffers
+
+ # Try doing an 'up'.
+
+ set mi_re [make_mi_re $mode 2 1 event]
+ set cli_re [make_cli_re $mode -1 -1 1]
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "up" $cli_re "frame up"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "frame up, event on MI"
+ }
+
+ # Try doing a 'down'.
+
+ set mi_re [make_mi_re $mode 2 0 event]
+ set cli_re [make_cli_re $mode -1 -1 0]
+
+ with_spawn_id $gdb_main_spawn_id {
+ gdb_test "down" $cli_re "frame down"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ match_re_or_ensure_not_output $mi_re "frame down, event on MI"
+ }
+}
+
+# Test selecting a thread from MI.
+
+proc test_mi_thread_select { mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ reset_selection "1.1"
+ flush_buffers
+
+ with_test_prefix "thread 1.2" {
+ # Do the '-thread-select' command to select a stopped thread.
+
+ set mi_re [make_mi_re $mode 2 0 response]
+ set cli_re [make_cli_re $mode -1 1.2 0]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-thread-select 2" $mi_re "-thread-select"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "-thread-select, event on CLI"
+ }
+
+ # Do the '-thread-select' command to select the same thread. We
+ # shouldn't receive an event on CLI, since we won't actually switch
+ # thread.
+
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-thread-select 2" $mi_re "-thread-select again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "-thread-select again, event on CLI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Do the '-thread-select' command to select the third thread, stopped on all-stop,
+ # running on non-stop.
+
+ if { $mode == "all-stop" } {
+ set mi_re [make_mi_re $mode 3 0 response]
+ set cli_re [make_cli_re $mode -1 1.3 0]
+ } else {
+ set mi_re [make_mi_re $mode 3 -1 response]
+ set cli_re [make_cli_re $mode -1 1.3 -1]
+ }
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-thread-select 3" $mi_re "-thread-select"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "-thread-select, event on CLI"
+ }
+
+ # Do the 'thread' command to select the third thread again. Again, we
+ # shouldn't receive an event on MI.
+
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-thread-select 3" $mi_re "-thread-select again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "-thread-select again, event on CLI"
+ }
+ }
+
+ with_test_prefix "thread 1.2 with --thread" {
+ # Test selecting a thread from MI with a --thread option. This test
+ # verifies that even if the thread GDB would switch to is the same has
+ # the thread specified with --thread, an event is still sent to CLI.
+ # In this case this is thread 1.2
+
+ set mi_re [make_mi_re $mode 2 0 response]
+ set cli_re [make_cli_re $mode -1 1.2 0]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-thread-select --thread 2 2" $mi_re "-thread-select"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ # This doesn't work as of now, no event is sent on CLI. It is
+ # commented out so we don't have to wait for the timeout every time.
+ # match_re_or_ensure_not_output "$cli_re\r\n" "-thread-select, event on cli"
+ kfail "gdb/20631" "thread-select, event on cli"
+ }
+ }
+
+ # Idea for the future: selecting a thread in a different inferior. For now,
+ # GDB doesn't show an inferior switch, but if it did, it would be a nice
+ # place to test it.
+}
+
+proc test_mi_stack_select_frame { mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ with_test_prefix "thread 1.2" {
+ reset_selection "1.2"
+ flush_buffers
+
+ # Do the '-stack-select-frame' command to select frame 1.
+
+ set mi_re "\\^done"
+ set cli_re [make_cli_re $mode -1 -1 1]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-stack-select-frame 1" $mi_re "-stack-select-frame"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "-stack-select-frame, event on MI"
+ }
+
+ # Do the '-stack-select-frame' command to select the same frame. This time we don't
+ # expect an event on CLI, since we won't actually change frame.
+
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-stack-select-frame 1" $mi_re "-stack-select-frame again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "-stack-select-frame again, event on MI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Now, try the '-stack-select-frame' command on thread 3, which is
+ # running if we are in non-stop mode.
+ reset_selection "1.3"
+ flush_buffers
+
+ if {$mode == "all-stop"} {
+ set mi_re "\\^done"
+ set cli_re [make_cli_re $mode -1 -1 1]
+ append cli_re "\r\n"
+ } elseif {$mode == "non-stop"} {
+ set cli_re ""
+ set mi_re "\\^error,msg=\"Selected thread is running\\.\""
+ }
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test "-stack-select-frame 1" $mi_re "-stack-select-frame"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "-stack-select-frame, event on MI"
+ }
+ }
+}
+
+proc make_cli_in_mi_command { cli_in_mi_mode command } {
+ if { $cli_in_mi_mode == "direct" } {
+ return $command
+ } elseif { $cli_in_mi_mode == "interpreter-exec" } {
+ return "-interpreter-exec console \"$command\""
+ } else {
+ error "Invalid value for CLI_IN_MI_MODE."
+ }
+}
+
+# Test selecting the inferior using a CLI command in the MI channel.
+
+proc test_cli_in_mi_inferior { mode cli_in_mi_mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ reset_selection "1.1"
+ flush_buffers
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "inferior 2"]
+
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 2 2.1 4 2]
+ set cli_re [make_cli_re $mode 2 "2.1" 2]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select inferior"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "select inferior, event on CLI"
+ }
+
+ # Do the 'inferior' command on the currently selected inferior. For now,
+ # GDB naively re-outputs everything.
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select inferior again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "select inferior again, event on CLI"
+ }
+}
+
+# Test selecting the thread using a CLI command in the MI channel.
+
+proc test_cli_in_mi_thread { mode cli_in_mi_mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ reset_selection "1.1"
+ flush_buffers
+
+ with_test_prefix "thread 1.2" {
+ # Do the 'thread' command to select a stopped thread.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "thread 1.2"]
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 -1 1.2 2 0]
+ set cli_re [make_cli_re $mode -1 1.2 0]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select thread"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "select thread, event on CLI"
+ }
+
+ # Do the 'thread' command to select the same thread. We shouldn't
+ # receive an event on CLI, since we won't actually switch thread.
+
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 1.2 2 0]
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select thread again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "select thread again, event on CLI"
+ }
+
+ # Try the 'thread' command without arguments.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "thread"]
+
+ set mi_re "${command}.*~\"\\\[Current thread is 1\\.2.*\\\]\\\\n\".*\\^done"
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "thread without args"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "thread without args, event on CLI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Do the 'thread' command to select the third thread, stopped on
+ # all-stop, running on non-stop.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "thread 1.3"]
+ if { $mode == "all-stop" } {
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 -1 1.3 3 0]
+ set cli_re [make_cli_re $mode -1 "1.3" 0]
+ } else {
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 -1 1.3 3 -1]
+ set cli_re [make_cli_re $mode -1 "1.3" -1]
+ }
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select thread"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "select thread, event on CLI"
+ }
+
+ # Do the 'thread' command to select the third thread again. Again, we
+ # shouldn't receive an event on MI.
+
+ if { $mode == "all-stop" } {
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 1.3 3 0]
+ } else {
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 1.3 3 -1]
+ }
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select thread again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "select thread again, event on CLI"
+ }
+
+ # Try the 'thread' command without arguments.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "thread"]
+
+ set mi_re "${command}.*~\"\\\[Current thread is 1\\.3.*\\\]\\\\n\".*\\^done"
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "thread without args"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "thread without args, event on CLI"
+ }
+ }
+
+ # Idea for the future: selecting a thread in a different inferior. For now,
+ # GDB doesn't show an inferior switch, but if it did, it would be a nice
+ # place to test it.
+}
+
+# Test selecting the frame using a CLI command in the MI channel.
+
+proc test_cli_in_mi_frame { mode cli_in_mi_mode } {
+ global gdb_main_spawn_id mi_spawn_id
+
+ with_test_prefix "thread 1.2" {
+ reset_selection "1.2"
+ flush_buffers
+
+ # Do the 'frame' command to select frame 1.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "frame 1"]
+ set cli_re [make_cli_re $mode -1 -1 1]
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 -1 -1 2 1]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select frame 1"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output "$cli_re\r\n" "select frame 1, event on CLI"
+ }
+
+ # Do the 'frame' command to select the same frame. This time we don't
+ # expect an event on MI, since we won't actually change frame.
+
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 -1 2 1]
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select frame 1 again"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "select frame 1 again, event on CLI"
+ }
+
+ # Do the 'frame' command without arguments. We shouldn't see anything on MI.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "frame"]
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 -1 2 1]
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "frame without args"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "frame without args, event on CLI"
+ }
+ }
+
+ with_test_prefix "thread 1.3" {
+ # Now, try the 'frame' command on thread 3, which is running if we are in
+ # non-stop mode.
+ reset_selection "1.3"
+ flush_buffers
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "frame 1"]
+ if {$mode == "all-stop"} {
+ set cli_re [make_cli_re $mode -1 -1 1]
+ append cli_re "\r\n"
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 1 -1 -1 3 1]
+ } elseif {$mode == "non-stop"} {
+ set cli_re ""
+ set mi_re "\\^error,msg=\"Selected thread is running\\.\".*"
+ }
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "select frame 1"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "select frame 1, event on CLI"
+ }
+
+ # Do the 'frame' command without arguments.
+
+ set command [make_cli_in_mi_command $cli_in_mi_mode "frame"]
+ if { $mode == "all-stop" } {
+ set mi_re [make_cli_in_mi_re $command $cli_in_mi_mode $mode 0 -1 -1 -1 1]
+ } else {
+ set mi_re "\\^error,msg=\"No stack\\.\""
+ }
+ set cli_re ""
+
+ with_spawn_id $mi_spawn_id {
+ mi_gdb_test $command $mi_re "frame without args"
+ }
+
+ with_spawn_id $gdb_main_spawn_id {
+ match_re_or_ensure_not_output $cli_re "frame without args, event on CLI"
+ }
+ }
+}
+
+foreach_with_prefix mode { "all-stop" "non-stop" } {
+ with_test_prefix_procname test_setup $mode
+
+ # Test selecting inferior, thread and frame from CLI
+
+ with_test_prefix_procname test_cli_inferior $mode
+ with_test_prefix_procname test_cli_thread $mode
+ with_test_prefix_procname test_cli_frame $mode
+ with_test_prefix_procname test_cli_select_frame $mode
+ with_test_prefix_procname test_cli_up_down $mode
+
+ # Test selecting thread and frame from MI
+
+ with_test_prefix_procname test_mi_thread_select $mode
+ with_test_prefix_procname test_mi_stack_select_frame $mode
+
+ # Test some CLI commands sent through MI, both with a "direct" command,
+ # such as "thread 1", and with -interpreter-exec, such as
+ # '-interpreter-exec console "thread 1"'.
+
+ foreach_with_prefix exec_mode {"direct" "interpreter-exec"} {
+ with_test_prefix_procname test_cli_in_mi_inferior $mode $exec_mode
+ with_test_prefix_procname test_cli_in_mi_thread $mode $exec_mode
+ with_test_prefix_procname test_cli_in_mi_frame $mode $exec_mode
+ }
+}
--
2.10.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
@ 2016-09-24 21:45 Simon Marchi
2016-09-24 20:13 ` [PATCH v3 2/2] Add test for user context selection sync Simon Marchi
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Simon Marchi @ 2016-09-24 21:45 UTC (permalink / raw)
To: gdb-patches; +Cc: Antoine Tremblay
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
New in v3:
* Isolate the complicated =thread-selected printing logic from
mi_execute_command in command_notifies_uscc_observer. Add
comments to explain rationale.
With this patch, when an inferior, thread or frame is explicitly
selected by the user, notifications will appear on all CLI and MI UIs.
When a GDB console is integrated in a front-end, this allows the
front-end to follow a selection made by the user ont he CLI, and it
informs the user about selection changes made behind the scenes by the
front-end.
This patch addresses PR gdb/20487.
In order to communicate frame changes to the front-end, this patch adds
a new field to the =thread-selected event for the selected frame. The
idea is that since inferior/thread/frame can be seen as a composition,
it makes sense to send them together in the same event. The vision
would be to eventually send the inferior information as well, if we find
that it's needed, although the "=thread-selected" event would be
ill-named for that job.
Front-ends need to handle this new field if they want to follow the
frame selection changes that originate from the console. The format of
the frame attribute is the same as what is found in the *stopped events.
Here's a detailed example for each command and the events they generate:
thread
------
1. CLI command:
thread 1.3
MI event:
=thread-selected,id="3",frame={...}
2. MI command:
-thread-select 3
CLI event:
[Switching to thread 1.3 ...]
3. MI command (CLI-in-MI):
thread 1.3
MI event/reply:
&"thread 1.3\n"
~"#0 child_sub_function () ...
=thread-selected,id="3",frame={level="0",...}
^done
frame
-----
1. CLI command:
frame 1
MI event:
=thread-selected,id="3",frame={level="1",...}
2. MI command:
-stack-select-frame 1
CLI event:
#1 0x00000000004007f0 in child_function...
3. MI command (CLI-in-MI):
frame 1
MI event/reply:
&"frame 1\n"
~"#1 0x00000000004007f9 in ..."
=thread-selected,id="3",frame={level="1"...}
^done
inferior
--------
Inferior selection events only go from the console to MI, since there's
no way to select the inferior in pure MI.
1. CLI command:
inferior 2
MI event:
=thread-selected,id="3"
Note that if the user selects an inferior that is not started or exited,
the MI doesn't receive a notification. Since there is no threads to
select, the =thread-selected event does not apply...
2. MI command (CLI-in-MI):
inferior 2
MI event/reply:
&"inferior 2\n"
~"[Switching to inferior 2 ...]"
=thread-selected,id="4",frame={level="0"...}
^done
Internal implementation detail: this patch makes it possible to suppress
notifications caused by a CLI command, like what is done in mi-interp.c.
This means that it's now possible to use the
add_com_suppress_notification function to register a command with some
event suppressed. It is used to implement the select-frame command in
this patch.
The function command_notifies_uscc_observer was added to extract
the rather complicated logical expression from the if statement. It is
also now clearer what that logic does: if the command used by the user
already notifies the user_selected_context_changed observer, there is
not need to notify it again. It therefore protects again emitting the
event twice.
No regressions, tested on ubuntu 14.04 x86 with target boards unix and
native-extended-gdbserver.
gdb/ChangeLog:
YYYY-MM-DD Antoine Tremblay <antoine.tremblay@ericsson.com>
YYYY-MM-DD Simon Marchi <simon.marchi@ericsson.com>
PR gdb/20487
* NEWS: Mention new frame field of =thread-selected event.
* cli/cli-decode.c (add_cmd): Initialize c->suppress_notification.
(add_com_suppress_notification): New function definition.
(cmd_func): Set and restore the suppress_notification flag.
* cli/cli-deicode.h (struct cmd_list_element)
<suppress_notification>: New field.
* cli/cli-interp.c (cli_suppress_notification): New global variable.
(cli_on_user_selected_context_changed): New function.
(_initialize_cli_interp): Attach to user_selected_context_changed
observer.
* command.h (struct cli_suppress_notification): New structure.
(cli_suppress_notification): New global variable declaration.
(add_com_suppress_notification): New function declaration.
* defs.h (enum user_selected_what_flag): New enum.
(user_selected_what): New enum flag type.
* frame.h (print_stack_frame_to_uiout): New function declaration.
* gdbthread.h (print_selected_thread_frame): New function declaration.
* inferior.c (print_selected_inferior): New function definition.
(inferior_command): Remove printing of inferior/thread/frame switch
notifications, notify user_selected_context_changed observer.
* inferior.h (print_selected_inferior): New function declaration.
* mi/mi-cmds.c (struct mi_cmd): Add user_selected_context
suppression to stack-select-frame and thread-select commands.
* mi/mi-interp.c (struct mi_suppress_notification)
<user_selected_context>: Initialize.
(mi_user_selected_context_changed): New function definition.
(_initialize_mi_interp): Attach to user_selected_context_changed.
* mi/mi-main.c (mi_cmd_thread_select): Print thread selection reply.
(mi_execute_command): Handle notification suppression. Notify
user_selected_context_changed observer on thread change instead of printing
event directly. Don't send it if command already sends the notification.
(command_notifies_uscc_observer): New function.
(mi_cmd_execute): Don't handle notification suppression.
* mi/mi-main.h (struct mi_suppress_notification)
<user_selected_context>: New field.
* stack.c (print_stack_frame_to_uiout): New function definition.
(select_frame_command): Notify user_selected_context_changed
observer.
(frame_command): Call print_selected_thread_frame if there's no frame
change or notify user_selected_context_changed observer if there is.
(up_command): Notify user_selected_context_changed observer.
(down_command): Likewise.
(_initialize_stack): Suppress user_selected_context notification for
command select-frame.
* thread.c (thread_command): Notify
user_selected_context_changed if the thread has changed, print
thread info directly if it hasn't.
(do_captured_thread_select): Do not print thread switch event.
(print_selected_thread_frame): New function definition.
* tui/tui-interp.c (tui_on_user_selected_context_changed):
New function definition.
(_initialize_tui_interp): Attach to user_selected_context_changed
observer.
gdb/doc/ChangeLog:
PR gdb/20487
* gdb.texinfo (Context management): Update mention of frame
change notifications.
(gdb/mi Async Records): Document frame field in
=thread-select event.
* observer.texi (GDB Observers): New user_selected_context_changed
observer.
gdb/testsuite/ChangeLog:
PR gdb/20487
* gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Adapt
=thread-select-event check.
---
gdb/NEWS | 4 ++
gdb/cli/cli-decode.c | 32 +++++++++++++-
gdb/cli/cli-decode.h | 6 +++
gdb/cli/cli-interp.c | 38 ++++++++++++++++
gdb/command.h | 16 +++++++
gdb/defs.h | 16 +++++++
gdb/doc/gdb.texinfo | 33 ++++++++------
gdb/doc/observer.texi | 4 ++
gdb/frame.h | 8 ++++
gdb/gdbthread.h | 4 ++
gdb/inferior.c | 40 ++++++++++-------
gdb/inferior.h | 3 ++
gdb/mi/mi-cmds.c | 6 ++-
gdb/mi/mi-interp.c | 61 +++++++++++++++++++++++++
gdb/mi/mi-main.c | 76 ++++++++++++++++++++++---------
gdb/mi/mi-main.h | 2 +
gdb/stack.c | 42 +++++++++++++++---
gdb/testsuite/gdb.mi/mi-pthreads.exp | 4 +-
gdb/thread.c | 86 +++++++++++++++++++++++++++---------
gdb/tui/tui-interp.c | 33 ++++++++++++++
20 files changed, 426 insertions(+), 88 deletions(-)
diff --git a/gdb/NEWS b/gdb/NEWS
index 37eed94..741813f 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -152,6 +152,10 @@ signal-event EVENTID
=record-started,thread-group="i1",method="btrace",format="bts"
+* MI async record =thread-selected now includes the frame field. For example:
+
+ =thread-selected,id="3",frame={level="0",addr="0x00000000004007c0"}
+
* New targets
Andes NDS32 nds32*-*-elf
diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
index 0d2b137..1e4a438 100644
--- a/gdb/cli/cli-decode.c
+++ b/gdb/cli/cli-decode.c
@@ -253,6 +253,7 @@ add_cmd (const char *name, enum command_class theclass, cmd_cfunc_ftype *fun,
c->user_commands = NULL;
c->cmd_pointer = NULL;
c->alias_chain = NULL;
+ c->suppress_notification = NULL;
return c;
}
@@ -883,7 +884,22 @@ add_com_alias (const char *name, const char *oldname, enum command_class theclas
{
return add_alias_cmd (name, oldname, theclass, abbrev_flag, &cmdlist);
}
-\f
+
+/* Add an element with a suppress notification to the list of commands. */
+
+struct cmd_list_element *
+add_com_suppress_notification (const char *name, enum command_class theclass,
+ cmd_cfunc_ftype *fun, const char *doc,
+ int *suppress_notification)
+{
+ struct cmd_list_element *element;
+
+ element = add_cmd (name, theclass, fun, doc, &cmdlist);
+ element->suppress_notification = suppress_notification;
+
+ return element;
+}
+
/* Recursively walk the commandlist structures, and print out the
documentation of commands that match our regex in either their
name, or their documentation.
@@ -1885,7 +1901,19 @@ void
cmd_func (struct cmd_list_element *cmd, char *args, int from_tty)
{
if (cmd_func_p (cmd))
- (*cmd->func) (cmd, args, from_tty);
+ {
+ struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
+
+ if (cmd->suppress_notification != NULL)
+ {
+ cleanups = make_cleanup_restore_integer (cmd->suppress_notification);
+ *cmd->suppress_notification = 1;
+ }
+
+ (*cmd->func) (cmd, args, from_tty);
+
+ do_cleanups (cleanups);
+ }
else
error (_("Invalid command"));
}
diff --git a/gdb/cli/cli-decode.h b/gdb/cli/cli-decode.h
index 4ea8063..4ef2e1b 100644
--- a/gdb/cli/cli-decode.h
+++ b/gdb/cli/cli-decode.h
@@ -218,6 +218,12 @@ struct cmd_list_element
/* Link pointer for aliases on an alias list. */
struct cmd_list_element *alias_chain;
+
+ /* If non-null, the pointer to a field in 'struct
+ cli_suppress_notification', which will be set to true in cmd_func
+ when this command is being executed. It will be set back to false
+ when the command has been executed. */
+ int *suppress_notification;
};
extern void help_cmd_list (struct cmd_list_element *, enum command_class,
diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c
index 5d67ba4..cc556a4 100644
--- a/gdb/cli/cli-interp.c
+++ b/gdb/cli/cli-interp.c
@@ -37,6 +37,12 @@ struct cli_interp
struct ui_out *cli_uiout;
};
+/* Suppress notification struct. */
+struct cli_suppress_notification cli_suppress_notification =
+ {
+ 0 /* user_selected_context_changed */
+ };
+
/* Returns the INTERP's data cast as cli_interp if INTERP is a CLI,
and returns NULL otherwise. */
@@ -229,6 +235,36 @@ cli_on_command_error (void)
display_gdb_prompt (NULL);
}
+/* Observer for the user_selected_context_changed notification. */
+
+static void
+cli_on_user_selected_context_changed (user_selected_what selection)
+{
+ struct switch_thru_all_uis state;
+ struct thread_info *tp;
+
+ /* This event is suppressed. */
+ if (cli_suppress_notification.user_selected_context)
+ return;
+
+ tp = find_thread_ptid (inferior_ptid);
+
+ SWITCH_THRU_ALL_UIS (state)
+ {
+ struct cli_interp *cli = as_cli_interp (top_level_interpreter ());
+
+ if (cli == NULL)
+ continue;
+
+ if (selection & USER_SELECTED_INFERIOR)
+ print_selected_inferior (cli->cli_uiout);
+
+ if (tp != NULL
+ && ((selection & (USER_SELECTED_THREAD | USER_SELECTED_FRAME))))
+ print_selected_thread_frame (cli->cli_uiout, selection);
+ }
+}
+
/* pre_command_loop implementation. */
void
@@ -393,4 +429,6 @@ _initialize_cli_interp (void)
observer_attach_no_history (cli_on_no_history);
observer_attach_sync_execution_done (cli_on_sync_execution_done);
observer_attach_command_error (cli_on_command_error);
+ observer_attach_user_selected_context_changed
+ (cli_on_user_selected_context_changed);
}
diff --git a/gdb/command.h b/gdb/command.h
index ab62601..965d91f 100644
--- a/gdb/command.h
+++ b/gdb/command.h
@@ -115,6 +115,17 @@ struct cmd_list_element;
typedef void cmd_cfunc_ftype (char *args, int from_tty);
+/* This structure specifies notifications to be suppressed by a cli
+ command interpreter. */
+
+struct cli_suppress_notification
+{
+ /* Inferior, thread, frame selected notification suppressed? */
+ int user_selected_context;
+};
+
+extern struct cli_suppress_notification cli_suppress_notification;
+
/* Forward-declarations of the entry-points of cli/cli-decode.c. */
/* API to the manipulation of command lists. */
@@ -218,6 +229,11 @@ extern struct cmd_list_element *add_com (const char *, enum command_class,
extern struct cmd_list_element *add_com_alias (const char *, const char *,
enum command_class, int);
+extern struct cmd_list_element *add_com_suppress_notification
+ (const char *name, enum command_class theclass,
+ cmd_cfunc_ftype *fun, const char *doc,
+ int *supress_notification);
+
extern struct cmd_list_element *add_info (const char *,
cmd_cfunc_ftype *fun,
const char *);
diff --git a/gdb/defs.h b/gdb/defs.h
index 9bc354e..6c0215c 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -53,6 +53,7 @@
#include "ui-file.h"
#include "host-defs.h"
+#include "common/enum-flags.h"
/* Scope types enumerator. List the types of scopes the compiler will
accept. */
@@ -743,6 +744,21 @@ enum block_enum
FIRST_LOCAL_BLOCK = 2
};
+/* User selection used in observer.h and multiple print functions. */
+
+enum user_selected_what_flag
+ {
+ /* Inferior selected. */
+ USER_SELECTED_INFERIOR = 1 << 1,
+
+ /* Thread selected. */
+ USER_SELECTED_THREAD = 1 << 2,
+
+ /* Frame selected. */
+ USER_SELECTED_FRAME = 1 << 3
+ };
+DEF_ENUM_FLAGS_TYPE (enum user_selected_what_flag, user_selected_what);
+
#include "utils.h"
#endif /* #ifndef DEFS_H */
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 4bbe79e..7a31ef5 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -25832,13 +25832,13 @@ identifier for thread and frame to operate on.
Usually, each top-level window in a frontend allows the user to select
a thread and a frame, and remembers the user selection for further
operations. However, in some cases @value{GDBN} may suggest that the
-current thread be changed. For example, when stopping on a breakpoint
-it is reasonable to switch to the thread where breakpoint is hit. For
-another example, if the user issues the CLI @samp{thread} command via
-the frontend, it is desirable to change the frontend's selected thread to the
-one specified by user. @value{GDBN} communicates the suggestion to
-change current thread using the @samp{=thread-selected} notification.
-No such notification is available for the selected frame at the moment.
+current thread or frame be changed. For example, when stopping on a
+breakpoint it is reasonable to switch to the thread where breakpoint is
+hit. For another example, if the user issues the CLI @samp{thread} or
+@samp{frame} commands via the frontend, it is desirable to change the
+frontend's selection to the one specified by user. @value{GDBN}
+communicates the suggestion to change current thread and frame using the
+@samp{=thread-selected} notification.
Note that historically, MI shares the selected thread with CLI, so
frontends used the @code{-thread-select} to execute commands in the
@@ -26484,13 +26484,18 @@ A thread either was created, or has exited. The @var{id} field
contains the global @value{GDBN} identifier of the thread. The @var{gid}
field identifies the thread group this thread belongs to.
-@item =thread-selected,id="@var{id}"
-Informs that the selected thread was changed as result of the last
-command. This notification is not emitted as result of @code{-thread-select}
-command but is emitted whenever an MI command that is not documented
-to change the selected thread actually changes it. In particular,
-invoking, directly or indirectly (via user-defined command), the CLI
-@code{thread} command, will generate this notification.
+@item =thread-selected,id="@var{id}"[,frame="@var{frame}"]
+Informs that the selected thread or frame were changed. This notification
+is not emitted as result of the @code{-thread-select} or
+@code{-stack-select-frame} commands, but is emitted whenever an MI command
+that is not documented to change the selected thread and frame actually
+changes them. In particular, invoking, directly or indirectly
+(via user-defined command), the CLI @code{thread} or @code{frame} commands,
+will generate this notification. Changing the thread of frame from another
+user interface (see @ref{Interpreters}) will also generate this notification.
+
+The @var{frame} field is only present if the newly selected thread is
+stopped. See @ref{GDB/MI Frame Information} for the format of its value.
We suggest that in response to this notification, front ends
highlight the selected thread and cause subsequent commands to apply to
diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi
index fc7aac4..6ef27b7 100644
--- a/gdb/doc/observer.texi
+++ b/gdb/doc/observer.texi
@@ -307,3 +307,7 @@ This observer is used for internal testing. Do not use.
See testsuite/gdb.gdb/observer.exp.
@end deftypefun
+@deftypefun void user_selected_context_changed (user_selected_what @var{selection})
+The user-selected inferior, thread and/or frame has changed. The user_select_what
+flag specifies if the inferior, thread and/or frame has changed.
+@end deftypefun
diff --git a/gdb/frame.h b/gdb/frame.h
index 5f21bb8..de13e7d 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -704,6 +704,14 @@ extern CORE_ADDR get_pc_function_start (CORE_ADDR);
extern struct frame_info *find_relative_frame (struct frame_info *, int *);
+/* Wrapper over print_stack_frame modifying current_uiout with UIOUT for
+ the function call. */
+
+extern void print_stack_frame_to_uiout (struct ui_out *uiout,
+ struct frame_info *, int print_level,
+ enum print_what print_what,
+ int set_current_sal);
+
extern void print_stack_frame (struct frame_info *, int print_level,
enum print_what print_what,
int set_current_sal);
diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h
index af2dc86..8f37fbb 100644
--- a/gdb/gdbthread.h
+++ b/gdb/gdbthread.h
@@ -630,6 +630,10 @@ extern void validate_registers_access (void);
true iff we ever detected multiple threads. */
extern int show_thread_that_caused_stop (void);
+/* Print the message for a thread or/and frame selected. */
+extern void print_selected_thread_frame (struct ui_out *uiout,
+ user_selected_what selection);
+
extern struct thread_info *thread_list;
#endif /* GDBTHREAD_H */
diff --git a/gdb/inferior.c b/gdb/inferior.c
index 47d91c7..277b988 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -548,6 +548,24 @@ inferior_pid_to_str (int pid)
return _("<null>");
}
+/* See inferior.h. */
+
+void
+print_selected_inferior (struct ui_out *uiout)
+{
+ char buf[PATH_MAX + 256];
+ struct inferior *inf = current_inferior ();
+
+ xsnprintf (buf, sizeof (buf),
+ _("[Switching to inferior %d [%s] (%s)]\n"),
+ inf->num,
+ inferior_pid_to_str (inf->pid),
+ (inf->pspace->pspace_exec_filename != NULL
+ ? inf->pspace->pspace_exec_filename
+ : _("<noexec>")));
+ ui_out_text (uiout, buf);
+}
+
/* Prints the list of inferiors and their details on UIOUT. This is a
version of 'info_inferior_command' suitable for use from MI.
@@ -726,13 +744,6 @@ inferior_command (char *args, int from_tty)
if (inf == NULL)
error (_("Inferior ID %d not known."), num);
- printf_filtered (_("[Switching to inferior %d [%s] (%s)]\n"),
- inf->num,
- inferior_pid_to_str (inf->pid),
- (inf->pspace->pspace_exec_filename != NULL
- ? inf->pspace->pspace_exec_filename
- : _("<noexec>")));
-
if (inf->pid != 0)
{
if (inf->pid != ptid_get_pid (inferior_ptid))
@@ -746,9 +757,10 @@ inferior_command (char *args, int from_tty)
switch_to_thread (tp->ptid);
}
- printf_filtered (_("[Switching to thread %s (%s)] "),
- print_thread_id (inferior_thread ()),
- target_pid_to_str (inferior_ptid));
+ observer_notify_user_selected_context_changed
+ (USER_SELECTED_INFERIOR
+ | USER_SELECTED_THREAD
+ | USER_SELECTED_FRAME);
}
else
{
@@ -758,14 +770,8 @@ inferior_command (char *args, int from_tty)
set_current_inferior (inf);
switch_to_thread (null_ptid);
set_current_program_space (inf->pspace);
- }
- if (inf->pid != 0 && is_running (inferior_ptid))
- ui_out_text (current_uiout, "(running)\n");
- else if (inf->pid != 0)
- {
- ui_out_text (current_uiout, "\n");
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+ observer_notify_user_selected_context_changed (USER_SELECTED_INFERIOR);
}
}
diff --git a/gdb/inferior.h b/gdb/inferior.h
index 571d26a..54c6f65 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -523,4 +523,7 @@ extern int number_of_inferiors (void);
extern struct inferior *add_inferior_with_spaces (void);
+/* Print the current selected inferior. */
+extern void print_selected_inferior (struct ui_out *uiout);
+
#endif /* !defined (INFERIOR_H) */
diff --git a/gdb/mi/mi-cmds.c b/gdb/mi/mi-cmds.c
index 4779832..85c19c1 100644
--- a/gdb/mi/mi-cmds.c
+++ b/gdb/mi/mi-cmds.c
@@ -137,7 +137,8 @@ static struct mi_cmd mi_cmds[] =
DEF_MI_CMD_MI ("stack-list-frames", mi_cmd_stack_list_frames),
DEF_MI_CMD_MI ("stack-list-locals", mi_cmd_stack_list_locals),
DEF_MI_CMD_MI ("stack-list-variables", mi_cmd_stack_list_variables),
- DEF_MI_CMD_MI ("stack-select-frame", mi_cmd_stack_select_frame),
+ DEF_MI_CMD_MI_1 ("stack-select-frame", mi_cmd_stack_select_frame,
+ &mi_suppress_notification.user_selected_context),
DEF_MI_CMD_MI ("symbol-list-lines", mi_cmd_symbol_list_lines),
DEF_MI_CMD_CLI ("target-attach", "attach", 1),
DEF_MI_CMD_MI ("target-detach", mi_cmd_target_detach),
@@ -149,7 +150,8 @@ static struct mi_cmd mi_cmds[] =
DEF_MI_CMD_CLI ("target-select", "target", 1),
DEF_MI_CMD_MI ("thread-info", mi_cmd_thread_info),
DEF_MI_CMD_MI ("thread-list-ids", mi_cmd_thread_list_ids),
- DEF_MI_CMD_MI ("thread-select", mi_cmd_thread_select),
+ DEF_MI_CMD_MI_1 ("thread-select", mi_cmd_thread_select,
+ &mi_suppress_notification.user_selected_context),
DEF_MI_CMD_MI ("trace-define-variable", mi_cmd_trace_define_variable),
DEF_MI_CMD_MI_1 ("trace-find", mi_cmd_trace_find,
&mi_suppress_notification.traceframe),
diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
index e3c7dbd..d7db499 100644
--- a/gdb/mi/mi-interp.c
+++ b/gdb/mi/mi-interp.c
@@ -769,6 +769,7 @@ struct mi_suppress_notification mi_suppress_notification =
0,
0,
0,
+ 0,
};
/* Emit notification on changing a traceframe. */
@@ -1334,6 +1335,64 @@ mi_memory_changed (struct inferior *inferior, CORE_ADDR memaddr,
}
}
+/* Emit an event when the selection context (inferior, thread, frame)
+ changed. */
+
+static void
+mi_user_selected_context_changed (user_selected_what selection)
+{
+ struct switch_thru_all_uis state;
+ struct thread_info *tp;
+
+ /* Don't send an event if we're responding to an MI command. */
+ if (mi_suppress_notification.user_selected_context)
+ return;
+
+ tp = find_thread_ptid (inferior_ptid);
+
+ SWITCH_THRU_ALL_UIS (state)
+ {
+ struct mi_interp *mi = as_mi_interp (top_level_interpreter ());
+ struct ui_out *mi_uiout;
+ struct cleanup *old_chain;
+
+ if (mi == NULL)
+ continue;
+
+ mi_uiout = interp_ui_out (top_level_interpreter ());
+
+ ui_out_redirect (mi_uiout, mi->event_channel);
+
+ old_chain = make_cleanup_ui_out_redirect_pop (mi_uiout);
+
+ make_cleanup_restore_target_terminal ();
+ target_terminal_ours_for_output ();
+
+ if (selection & USER_SELECTED_INFERIOR)
+ print_selected_inferior (mi->cli_uiout);
+
+ if (tp != NULL
+ && (selection & (USER_SELECTED_THREAD | USER_SELECTED_FRAME)))
+ {
+ print_selected_thread_frame (mi->cli_uiout, selection);
+
+ fprintf_unfiltered (mi->event_channel,
+ "thread-selected,id=\"%d\"",
+ tp->global_num);
+
+ if (tp->state != THREAD_RUNNING)
+ {
+ if (has_stack_frames ())
+ print_stack_frame_to_uiout (mi_uiout, get_selected_frame (NULL),
+ 1, SRC_AND_LOC, 1);
+ }
+ }
+
+ gdb_flush (mi->event_channel);
+ do_cleanups (old_chain);
+ }
+}
+
static int
report_initial_inferior (struct inferior *inf, void *closure)
{
@@ -1466,4 +1525,6 @@ _initialize_mi_interp (void)
observer_attach_command_param_changed (mi_command_param_changed);
observer_attach_memory_changed (mi_memory_changed);
observer_attach_sync_execution_done (mi_on_sync_execution_done);
+ observer_attach_user_selected_context_changed
+ (mi_user_selected_context_changed);
}
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 1913157..0e065d7 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -53,6 +53,7 @@
#include "linespec.h"
#include "extension.h"
#include "gdbcmd.h"
+#include "observer.h"
#include <ctype.h>
#include "gdb_sys_time.h"
@@ -564,17 +565,29 @@ mi_cmd_thread_select (char *command, char **argv, int argc)
{
enum gdb_rc rc;
char *mi_error_message;
+ ptid_t previous_ptid = inferior_ptid;
if (argc != 1)
error (_("-thread-select: USAGE: threadnum."));
rc = gdb_thread_select (current_uiout, argv[0], &mi_error_message);
+ /* If thread switch did not succeed don't notify or print. */
if (rc == GDB_RC_FAIL)
{
make_cleanup (xfree, mi_error_message);
error ("%s", mi_error_message);
}
+
+ print_selected_thread_frame (current_uiout,
+ USER_SELECTED_THREAD | USER_SELECTED_FRAME);
+
+ /* Notify if the thread has effectively changed. */
+ if (!ptid_equal (inferior_ptid, previous_ptid))
+ {
+ observer_notify_user_selected_context_changed (USER_SELECTED_THREAD
+ | USER_SELECTED_FRAME);
+ }
}
void
@@ -2097,6 +2110,33 @@ mi_print_exception (const char *token, struct gdb_exception exception)
fputs_unfiltered ("\n", mi->raw_stdout);
}
+/* Determine whether the parsed command already notifies the
+ user_selected_context_changed observer. */
+
+static int
+command_notifies_uscc_observer (struct mi_parse *command)
+{
+ if (command->op == CLI_COMMAND)
+ {
+ /* CLI commands "thread" and "inferior" already send it. */
+ return (strncmp (command->command, "thread ", 7) == 0
+ || strncmp (command->command, "inferior ", 9) == 0);
+ }
+ else /* MI_COMMAND */
+ {
+ if (strcmp (command->command, "interpreter-exec") == 0
+ && command->argc > 1)
+
+ /* "thread" and "inferior" again, but through -interpreter-exec. */
+ return (strncmp (command->argv[1], "thread ", 7) == 0
+ || strncmp (command->argv[1], "inferior ", 9) == 0);
+
+ else
+ /* -thread-select already sends it. */
+ return strcmp (command->command, "thread-select") == 0;
+ }
+}
+
void
mi_execute_command (const char *cmd, int from_tty)
{
@@ -2124,9 +2164,16 @@ mi_execute_command (const char *cmd, int from_tty)
if (command != NULL)
{
ptid_t previous_ptid = inferior_ptid;
+ struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
command->token = token;
+ if (command->cmd != NULL && command->cmd->suppress_notification != NULL)
+ {
+ make_cleanup_restore_integer (command->cmd->suppress_notification);
+ *command->cmd->suppress_notification = 1;
+ }
+
if (do_timings)
{
command->cmd_start = XNEW (struct mi_timestamp);
@@ -2161,10 +2208,9 @@ mi_execute_command (const char *cmd, int from_tty)
/* Don't try report anything if there are no threads --
the program is dead. */
&& thread_count () != 0
- /* -thread-select explicitly changes thread. If frontend uses that
- internally, we don't want to emit =thread-selected, since
- =thread-selected is supposed to indicate user's intentions. */
- && strcmp (command->command, "thread-select") != 0)
+ /* If the command already reports the thread change, no need to do it
+ again. */
+ && !command_notifies_uscc_observer (command))
{
struct mi_interp *mi
= (struct mi_interp *) top_level_interpreter_data ();
@@ -2185,22 +2231,14 @@ mi_execute_command (const char *cmd, int from_tty)
if (report_change)
{
- struct thread_info *ti = inferior_thread ();
- struct cleanup *old_chain;
-
- old_chain = make_cleanup_restore_target_terminal ();
- target_terminal_ours_for_output ();
-
- fprintf_unfiltered (mi->event_channel,
- "thread-selected,id=\"%d\"",
- ti->global_num);
- gdb_flush (mi->event_channel);
-
- do_cleanups (old_chain);
+ observer_notify_user_selected_context_changed
+ (USER_SELECTED_THREAD | USER_SELECTED_FRAME);
}
}
mi_parse_free (command);
+
+ do_cleanups (cleanup);
}
}
@@ -2277,12 +2315,6 @@ mi_cmd_execute (struct mi_parse *parse)
current_context = parse;
- if (parse->cmd->suppress_notification != NULL)
- {
- make_cleanup_restore_integer (parse->cmd->suppress_notification);
- *parse->cmd->suppress_notification = 1;
- }
-
if (parse->cmd->argv_func != NULL)
{
parse->cmd->argv_func (parse->command, parse->argv, parse->argc);
diff --git a/gdb/mi/mi-main.h b/gdb/mi/mi-main.h
index 18000cf..bf4d1b6 100644
--- a/gdb/mi/mi-main.h
+++ b/gdb/mi/mi-main.h
@@ -49,6 +49,8 @@ struct mi_suppress_notification
int traceframe;
/* Memory changed notification suppressed? */
int memory;
+ /* User selected context changed notification suppressed? */
+ int user_selected_context;
};
extern struct mi_suppress_notification mi_suppress_notification;
diff --git a/gdb/stack.c b/gdb/stack.c
index 417e887..b719fcd 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -51,6 +51,7 @@
#include "safe-ctype.h"
#include "symfile.h"
#include "extension.h"
+#include "observer.h"
/* The possible choices of "set print frame-arguments", and the value
of this setting. */
@@ -141,6 +142,24 @@ frame_show_address (struct frame_info *frame,
return get_frame_pc (frame) != sal.pc;
}
+/* See frame.h. */
+
+void
+print_stack_frame_to_uiout (struct ui_out *uiout, struct frame_info *frame,
+ int print_level, enum print_what print_what,
+ int set_current_sal)
+{
+ struct cleanup *old_chain;
+
+ old_chain = make_cleanup_restore_current_uiout ();
+
+ current_uiout = uiout;
+
+ print_stack_frame (frame, print_level, print_what, set_current_sal);
+
+ do_cleanups (old_chain);
+}
+
/* Show or print a stack frame FRAME briefly. The output is formatted
according to PRINT_LEVEL and PRINT_WHAT printing the frame's
relative level, function name, argument list, and file name and
@@ -2302,7 +2321,11 @@ find_relative_frame (struct frame_info *frame, int *level_offset_ptr)
void
select_frame_command (char *level_exp, int from_tty)
{
+ struct frame_info *prev_frame = get_selected_frame_if_set ();
+
select_frame (parse_frame_specification (level_exp, NULL));
+ if (get_selected_frame_if_set () != prev_frame)
+ observer_notify_user_selected_context_changed (USER_SELECTED_FRAME);
}
/* The "frame" command. With no argument, print the selected frame
@@ -2312,8 +2335,13 @@ select_frame_command (char *level_exp, int from_tty)
static void
frame_command (char *level_exp, int from_tty)
{
- select_frame_command (level_exp, from_tty);
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+ struct frame_info *prev_frame = get_selected_frame_if_set ();
+
+ select_frame (parse_frame_specification (level_exp, NULL));
+ if (get_selected_frame_if_set () != prev_frame)
+ observer_notify_user_selected_context_changed (USER_SELECTED_FRAME);
+ else
+ print_selected_thread_frame (current_uiout, USER_SELECTED_FRAME);
}
/* Select the frame up one or COUNT_EXP stack levels from the
@@ -2344,7 +2372,7 @@ static void
up_command (char *count_exp, int from_tty)
{
up_silently_base (count_exp);
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+ observer_notify_user_selected_context_changed (USER_SELECTED_FRAME);
}
/* Select the frame down one or COUNT_EXP stack levels from the previously
@@ -2383,9 +2411,8 @@ static void
down_command (char *count_exp, int from_tty)
{
down_silently_base (count_exp);
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+ observer_notify_user_selected_context_changed (USER_SELECTED_FRAME);
}
-\f
void
return_command (char *retval_exp, int from_tty)
@@ -2616,10 +2643,11 @@ a command file or a user-defined command."));
add_com_alias ("f", "frame", class_stack, 1);
- add_com ("select-frame", class_stack, select_frame_command, _("\
+ add_com_suppress_notification ("select-frame", class_stack, select_frame_command, _("\
Select a stack frame without printing anything.\n\
An argument specifies the frame to select.\n\
-It can be a stack frame number or the address of the frame.\n"));
+It can be a stack frame number or the address of the frame.\n"),
+ &cli_suppress_notification.user_selected_context);
add_com ("backtrace", class_stack, backtrace_command, _("\
Print backtrace of all stack frames, or innermost COUNT frames.\n\
diff --git a/gdb/testsuite/gdb.mi/mi-pthreads.exp b/gdb/testsuite/gdb.mi/mi-pthreads.exp
index 88a600a..511f0ca 100644
--- a/gdb/testsuite/gdb.mi/mi-pthreads.exp
+++ b/gdb/testsuite/gdb.mi/mi-pthreads.exp
@@ -53,8 +53,8 @@ proc check_mi_thread_command_set {} {
foreach thread $thread_list {
mi_gdb_test "-interpreter-exec console \"thread $thread\"" \
- ".*\\^done\r\n=thread-selected,id=\"$thread\"" \
- "check =thread-selected: thread $thread"
+ ".*=thread-selected,id=\"$thread\".*\r\n\\^done" \
+ "check =thread-selected: thread $thread"
}
}
diff --git a/gdb/thread.c b/gdb/thread.c
index a66a2b5..13449a8 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1923,7 +1923,7 @@ thread_apply_command (char *tidlist, int from_tty)
void
thread_command (char *tidstr, int from_tty)
{
- if (!tidstr)
+ if (tidstr == NULL)
{
if (ptid_equal (inferior_ptid, null_ptid))
error (_("No thread selected"));
@@ -1943,10 +1943,31 @@ thread_command (char *tidstr, int from_tty)
}
else
error (_("No stack."));
- return;
}
+ else
+ {
+ ptid_t previous_ptid = inferior_ptid;
+ enum gdb_rc result;
+
+ result = gdb_thread_select (current_uiout, tidstr, NULL);
+
+ /* If thread switch did not succeed don't notify or print. */
+ if (result == GDB_RC_FAIL)
+ return;
- gdb_thread_select (current_uiout, tidstr, NULL);
+ /* Print if the thread has not changed, otherwise an event will be sent. */
+ if (ptid_equal (inferior_ptid, previous_ptid))
+ {
+ print_selected_thread_frame (current_uiout,
+ USER_SELECTED_THREAD
+ | USER_SELECTED_FRAME);
+ }
+ else
+ {
+ observer_notify_user_selected_context_changed (USER_SELECTED_THREAD
+ | USER_SELECTED_FRAME);
+ }
+ }
}
/* Implementation of `thread name'. */
@@ -2058,32 +2079,53 @@ do_captured_thread_select (struct ui_out *uiout, void *tidstr_v)
annotate_thread_changed ();
- if (ui_out_is_mi_like_p (uiout))
- ui_out_field_int (uiout, "new-thread-id", inferior_thread ()->global_num);
- else
+ /* Since the current thread may have changed, see if there is any
+ exited thread we can now delete. */
+ prune_threads ();
+
+ return GDB_RC_OK;
+}
+
+/* Print thread and frame switch command response. */
+
+void
+print_selected_thread_frame (struct ui_out *uiout,
+ user_selected_what selection)
+{
+ struct thread_info *tp = inferior_thread ();
+ struct inferior *inf = current_inferior ();
+
+ if (selection & USER_SELECTED_THREAD)
{
- ui_out_text (uiout, "[Switching to thread ");
- ui_out_field_string (uiout, "new-thread-id", print_thread_id (tp));
- ui_out_text (uiout, " (");
- ui_out_text (uiout, target_pid_to_str (inferior_ptid));
- ui_out_text (uiout, ")]");
+ if (ui_out_is_mi_like_p (uiout))
+ {
+ ui_out_field_int (uiout, "new-thread-id",
+ inferior_thread ()->global_num);
+ }
+ else
+ {
+ ui_out_text (uiout, "[Switching to thread ");
+ ui_out_field_string (uiout, "new-thread-id", print_thread_id (tp));
+ ui_out_text (uiout, " (");
+ ui_out_text (uiout, target_pid_to_str (inferior_ptid));
+ ui_out_text (uiout, ")]");
+ }
}
- /* Note that we can't reach this with an exited thread, due to the
- thread_alive check above. */
if (tp->state == THREAD_RUNNING)
- ui_out_text (uiout, "(running)\n");
- else
{
- ui_out_text (uiout, "\n");
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+ if (selection & USER_SELECTED_THREAD)
+ ui_out_text (uiout, "(running)\n");
}
+ else if (selection & USER_SELECTED_FRAME)
+ {
+ if (selection & USER_SELECTED_THREAD)
+ ui_out_text (uiout, "\n");
- /* Since the current thread may have changed, see if there is any
- exited thread we can now delete. */
- prune_threads ();
-
- return GDB_RC_OK;
+ if (has_stack_frames ())
+ print_stack_frame_to_uiout (uiout, get_selected_frame (NULL),
+ 1, SRC_AND_LOC, 1);
+ }
}
enum gdb_rc
diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c
index 3856382..e06d679 100644
--- a/gdb/tui/tui-interp.c
+++ b/gdb/tui/tui-interp.c
@@ -206,6 +206,37 @@ tui_on_command_error (void)
display_gdb_prompt (NULL);
}
+/* Observer for the user_selected_context_changed notification. */
+
+static void
+tui_on_user_selected_context_changed (user_selected_what selection)
+{
+ struct switch_thru_all_uis state;
+ struct thread_info *tp;
+
+ /* This event is suppressed. */
+ if (cli_suppress_notification.user_selected_context)
+ return;
+
+ tp = find_thread_ptid (inferior_ptid);
+
+ SWITCH_THRU_ALL_UIS (state)
+ {
+ struct interp *tui = as_tui_interp (top_level_interpreter ());
+
+ if (tui == NULL)
+ continue;
+
+ if (selection & USER_SELECTED_INFERIOR)
+ print_selected_inferior (tui_ui_out (tui));
+
+ if (tp != NULL
+ && ((selection & (USER_SELECTED_THREAD | USER_SELECTED_FRAME))))
+ print_selected_thread_frame (tui_ui_out (tui), selection);
+
+ }
+}
+
/* These implement the TUI interpreter. */
static void *
@@ -323,4 +354,6 @@ _initialize_tui_interp (void)
observer_attach_no_history (tui_on_no_history);
observer_attach_sync_execution_done (tui_on_sync_execution_done);
observer_attach_command_error (tui_on_command_error);
+ observer_attach_user_selected_context_changed
+ (tui_on_user_selected_context_changed);
}
--
2.10.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-09-24 21:45 [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Simon Marchi
2016-09-24 20:13 ` [PATCH v3 2/2] Add test for user context selection sync Simon Marchi
@ 2016-09-25 12:41 ` Eli Zaretskii
2016-09-26 2:25 ` Simon Marchi
2016-10-03 16:47 ` Pedro Alves
2016-12-08 12:02 ` Thomas Schwinge
3 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2016-09-25 12:41 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches, antoine.tremblay
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
> Date: Sat, 24 Sep 2016 16:13:30 -0400
>
> From: Antoine Tremblay <antoine.tremblay@ericsson.com>
>
> New in v3:
>
> * Isolate the complicated =thread-selected printing logic from
> mi_execute_command in command_notifies_uscc_observer. Add
> comments to explain rationale.
Thanks, the documentation parts are approved.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-09-25 12:41 ` [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Eli Zaretskii
@ 2016-09-26 2:25 ` Simon Marchi
0 siblings, 0 replies; 12+ messages in thread
From: Simon Marchi @ 2016-09-26 2:25 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches, antoine.tremblay
On 2016-09-24 22:34, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
>> Date: Sat, 24 Sep 2016 16:13:30 -0400
>>
>> From: Antoine Tremblay <antoine.tremblay@ericsson.com>
>>
>> New in v3:
>>
>> * Isolate the complicated =thread-selected printing logic from
>> mi_execute_command in command_notifies_uscc_observer. Add
>> comments to explain rationale.
>
> Thanks, the documentation parts are approved.
Thanks!
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-09-24 21:45 [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Simon Marchi
2016-09-24 20:13 ` [PATCH v3 2/2] Add test for user context selection sync Simon Marchi
2016-09-25 12:41 ` [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Eli Zaretskii
@ 2016-10-03 16:47 ` Pedro Alves
2016-10-03 17:40 ` Simon Marchi
2016-12-08 12:02 ` Thomas Schwinge
3 siblings, 1 reply; 12+ messages in thread
From: Pedro Alves @ 2016-10-03 16:47 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Antoine Tremblay
Hi Simon,
This looks good to me now, module a couple minor issues pointed out
below. Fix these and you're good to go.
On 09/24/2016 09:13 PM, Simon Marchi wrote:
> @@ -1885,7 +1901,19 @@ void
> cmd_func (struct cmd_list_element *cmd, char *args, int from_tty)
> {
> if (cmd_func_p (cmd))
> - (*cmd->func) (cmd, args, from_tty);
> + {
> + struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
> +
> + if (cmd->suppress_notification != NULL)
> + {
> + cleanups = make_cleanup_restore_integer (cmd->suppress_notification);
This will incorrectly leave the null_cleanup not run.
You should not overwrite "cleanups". Should be just:
+ make_cleanup_restore_integer (cmd->suppress_notification);
> + *cmd->suppress_notification = 1;
> + }
> +
> + (*cmd->func) (cmd, args, from_tty);
> +
> + do_cleanups (cleanups);
> + else /* MI_COMMAND */
> + {
> + if (strcmp (command->command, "interpreter-exec") == 0
> + && command->argc > 1)
> +
This empty line here made me pause and think that the code
looks suspicious. Better would be to wrap the then/else blocks
in {}s, since they're multi-line.
> + /* "thread" and "inferior" again, but through -interpreter-exec. */
> + return (strncmp (command->argv[1], "thread ", 7) == 0
> + || strncmp (command->argv[1], "inferior ", 9) == 0);
> +
> + else
> + /* -thread-select already sends it. */
> + return strcmp (command->command, "thread-select") == 0;
> + }
> +@item =thread-selected,id="@var{id}"[,frame="@var{frame}"]
> +Informs that the selected thread or frame were changed. This notification
> +is not emitted as result of the @code{-thread-select} or
> +@code{-stack-select-frame} commands, but is emitted whenever an MI command
> +that is not documented to change the selected thread and frame actually
> +changes them. In particular, invoking, directly or indirectly
> +(via user-defined command), the CLI @code{thread} or @code{frame} commands,
> +will generate this notification. Changing the thread of frame from another
> +user interface (see @ref{Interpreters}) will also generate this notification.
> +
Typo: s/thread of frame/thread or frame/
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] Add test for user context selection sync
2016-09-24 20:13 ` [PATCH v3 2/2] Add test for user context selection sync Simon Marchi
@ 2016-10-03 17:10 ` Pedro Alves
2016-10-03 17:48 ` Simon Marchi
0 siblings, 1 reply; 12+ messages in thread
From: Pedro Alves @ 2016-10-03 17:10 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Antoine Tremblay
On 09/24/2016 09:13 PM, Simon Marchi wrote:
> +set main_break_line [gdb_get_line_number "main break line"]
> +set thread_loop_line [gdb_get_line_number "thread loop line"]
> +set thread_caller_line [gdb_get_line_number "thread caller line"]
> +
> +# Call PROCNAME with the given arguments, inside a with_test_prefix $procname
> +# block.
> +
> +proc with_test_prefix_procname { procname args } {
> + with_test_prefix $procname {
> + # Note: this syntax requires TCL 8.5, if we need to support 8.4,
> + # we'll need to find an alternative.
> + $procname {*}$args
> + }
> +}
An alternative (not talking about TCL 8.5 here), would be to
go the gdb_caching_proc way. That is, something like:
proc prefixed_proc {name body} {
...
}
.. and then define the procs that you want to prefix with
prefixed_proc instead of proc.
But either way is fine with me.
I mildly dislike using the proc names as prefix strings as it feels
like implementation details leaking, but as long as the proc names are
clear enough, I won't really complain about it. Who knows, I may even
grow to like it. :-)
> + # When using mi_expect_stop, we don't expect a prompt after the *stopped
> + # event, since the blocking commands are done from the CLI. Seting async to
> + # 1 makes it not expect the prompt.
> + set async 1
"Setting".
This is OK as is with the typo fixed.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-10-03 16:47 ` Pedro Alves
@ 2016-10-03 17:40 ` Simon Marchi
2016-10-03 21:03 ` Simon Marchi
0 siblings, 1 reply; 12+ messages in thread
From: Simon Marchi @ 2016-10-03 17:40 UTC (permalink / raw)
To: Pedro Alves, Simon Marchi, gdb-patches; +Cc: Antoine Tremblay
On 16-10-03 12:47 PM, Pedro Alves wrote:
> Hi Simon,
>
> This looks good to me now, module a couple minor issues pointed out
> below. Fix these and you're good to go.
>
> On 09/24/2016 09:13 PM, Simon Marchi wrote:
>> @@ -1885,7 +1901,19 @@ void
>> cmd_func (struct cmd_list_element *cmd, char *args, int from_tty)
>> {
>> if (cmd_func_p (cmd))
>> - (*cmd->func) (cmd, args, from_tty);
>> + {
>> + struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
>> +
>> + if (cmd->suppress_notification != NULL)
>> + {
>> + cleanups = make_cleanup_restore_integer (cmd->suppress_notification);
>
> This will incorrectly leave the null_cleanup not run.
> You should not overwrite "cleanups". Should be just:
>
> + make_cleanup_restore_integer (cmd->suppress_notification);
Done, thanks.
>> + *cmd->suppress_notification = 1;
>> + }
>> +
>> + (*cmd->func) (cmd, args, from_tty);
>> +
>> + do_cleanups (cleanups);
>
>
>
>> + else /* MI_COMMAND */
>> + {
>> + if (strcmp (command->command, "interpreter-exec") == 0
>> + && command->argc > 1)
>> +
>
> This empty line here made me pause and think that the code
> looks suspicious. Better would be to wrap the then/else blocks
> in {}s, since they're multi-line.
Right, it's clearer.
>> +@item =thread-selected,id="@var{id}"[,frame="@var{frame}"]
>> +Informs that the selected thread or frame were changed. This notification
>> +is not emitted as result of the @code{-thread-select} or
>> +@code{-stack-select-frame} commands, but is emitted whenever an MI command
>> +that is not documented to change the selected thread and frame actually
>> +changes them. In particular, invoking, directly or indirectly
>> +(via user-defined command), the CLI @code{thread} or @code{frame} commands,
>> +will generate this notification. Changing the thread of frame from another
>> +user interface (see @ref{Interpreters}) will also generate this notification.
>> +
>
> Typo: s/thread of frame/thread or frame/
Woops, thanks.
I'll give it a last complete test run before pushing.
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] Add test for user context selection sync
2016-10-03 17:10 ` Pedro Alves
@ 2016-10-03 17:48 ` Simon Marchi
0 siblings, 0 replies; 12+ messages in thread
From: Simon Marchi @ 2016-10-03 17:48 UTC (permalink / raw)
To: Pedro Alves, Simon Marchi, gdb-patches; +Cc: Antoine Tremblay
On 16-10-03 01:10 PM, Pedro Alves wrote:
> On 09/24/2016 09:13 PM, Simon Marchi wrote:
>
>> +set main_break_line [gdb_get_line_number "main break line"]
>> +set thread_loop_line [gdb_get_line_number "thread loop line"]
>> +set thread_caller_line [gdb_get_line_number "thread caller line"]
>> +
>> +# Call PROCNAME with the given arguments, inside a with_test_prefix $procname
>> +# block.
>> +
>> +proc with_test_prefix_procname { procname args } {
>> + with_test_prefix $procname {
>> + # Note: this syntax requires TCL 8.5, if we need to support 8.4,
>> + # we'll need to find an alternative.
>> + $procname {*}$args
>> + }
>> +}
>
> An alternative (not talking about TCL 8.5 here), would be to
> go the gdb_caching_proc way. That is, something like:
>
> proc prefixed_proc {name body} {
> ...
> }
>
> .. and then define the procs that you want to prefix with
> prefixed_proc instead of proc.
Interesting, I hadn't thought of that.
> But either way is fine with me.
>
> I mildly dislike using the proc names as prefix strings as it feels
> like implementation details leaking, but as long as the proc names are
> clear enough, I won't really complain about it. Who knows, I may even
> grow to like it. :-)
I agree about the principle. While developing though, I found it was very
useful since it allowed to jump directly to the right procedure.
>> + # When using mi_expect_stop, we don't expect a prompt after the *stopped
>> + # event, since the blocking commands are done from the CLI. Seting async to
>> + # 1 makes it not expect the prompt.
>> + set async 1
>
> "Setting".
Fixed.
Thanks,
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-10-03 17:40 ` Simon Marchi
@ 2016-10-03 21:03 ` Simon Marchi
0 siblings, 0 replies; 12+ messages in thread
From: Simon Marchi @ 2016-10-03 21:03 UTC (permalink / raw)
To: Pedro Alves, Simon Marchi, gdb-patches; +Cc: Antoine Tremblay
On 16-10-03 01:39 PM, Simon Marchi wrote:
> I'll give it a last complete test run before pushing.
All right, I pushed both patches to both master and gdb-7.12-branch.
Thanks for the help and reviews!
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-09-24 21:45 [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Simon Marchi
` (2 preceding siblings ...)
2016-10-03 16:47 ` Pedro Alves
@ 2016-12-08 12:02 ` Thomas Schwinge
2016-12-08 15:25 ` Simon Marchi
3 siblings, 1 reply; 12+ messages in thread
From: Thomas Schwinge @ 2016-12-08 12:02 UTC (permalink / raw)
To: Antoine Tremblay, Simon Marchi, gdb-patches; +Cc: bug-hurd
Hi!
On Sat, 24 Sep 2016 16:13:30 -0400, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> --- a/gdb/inferior.c
> +++ b/gdb/inferior.c
> +void
> +print_selected_inferior (struct ui_out *uiout)
> +{
> + char buf[PATH_MAX + 256];
> + struct inferior *inf = current_inferior ();
> +
> + xsnprintf (buf, sizeof (buf),
> + _("[Switching to inferior %d [%s] (%s)]\n"),
> + inf->num,
> + inferior_pid_to_str (inf->pid),
> + (inf->pspace->pspace_exec_filename != NULL
> + ? inf->pspace->pspace_exec_filename
> + : _("<noexec>")));
> + ui_out_text (uiout, buf);
> +}
> +
On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build.
(I'm aware that there is other PATH_MAX usage in GDB sources, which we
ought to fix at some point, for example in gdbserver -- which is not yet
enabled for GNU/Hurd.)
Unless I miss something, this issue could be addressed by simply using
ui_out_message instead of ui_out_text with a temporary "buf" -- OK to
push the following?
--- gdb/inferior.c
+++ gdb/inferior.c
@@ -556,17 +556,15 @@ inferior_pid_to_str (int pid)
void
print_selected_inferior (struct ui_out *uiout)
{
- char buf[PATH_MAX + 256];
struct inferior *inf = current_inferior ();
- xsnprintf (buf, sizeof (buf),
- _("[Switching to inferior %d [%s] (%s)]\n"),
- inf->num,
- inferior_pid_to_str (inf->pid),
- (inf->pspace->pspace_exec_filename != NULL
- ? inf->pspace->pspace_exec_filename
- : _("<noexec>")));
- ui_out_text (uiout, buf);
+ ui_out_message (uiout,
+ _("[Switching to inferior %d [%s] (%s)]\n"),
+ inf->num,
+ inferior_pid_to_str (inf->pid),
+ (inf->pspace->pspace_exec_filename != NULL
+ ? inf->pspace->pspace_exec_filename
+ : _("<noexec>")));
}
/* Prints the list of inferiors and their details on UIOUT. This is a
Grüße
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-12-08 12:02 ` Thomas Schwinge
@ 2016-12-08 15:25 ` Simon Marchi
2016-12-09 6:22 ` Thomas Schwinge
0 siblings, 1 reply; 12+ messages in thread
From: Simon Marchi @ 2016-12-08 15:25 UTC (permalink / raw)
To: Thomas Schwinge; +Cc: Antoine Tremblay, gdb-patches, bug-hurd
On 2016-12-08 07:01, Thomas Schwinge wrote:
> On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build.
> (I'm aware that there is other PATH_MAX usage in GDB sources, which we
> ought to fix at some point, for example in gdbserver -- which is not
> yet
> enabled for GNU/Hurd.)
>
> Unless I miss something, this issue could be addressed by simply using
> ui_out_message instead of ui_out_text with a temporary "buf" -- OK to
> push the following?
>
> --- gdb/inferior.c
> +++ gdb/inferior.c
> @@ -556,17 +556,15 @@ inferior_pid_to_str (int pid)
> void
> print_selected_inferior (struct ui_out *uiout)
> {
> - char buf[PATH_MAX + 256];
> struct inferior *inf = current_inferior ();
>
> - xsnprintf (buf, sizeof (buf),
> - _("[Switching to inferior %d [%s] (%s)]\n"),
> - inf->num,
> - inferior_pid_to_str (inf->pid),
> - (inf->pspace->pspace_exec_filename != NULL
> - ? inf->pspace->pspace_exec_filename
> - : _("<noexec>")));
> - ui_out_text (uiout, buf);
> + ui_out_message (uiout,
> + _("[Switching to inferior %d [%s] (%s)]\n"),
> + inf->num,
> + inferior_pid_to_str (inf->pid),
> + (inf->pspace->pspace_exec_filename != NULL
> + ? inf->pspace->pspace_exec_filename
> + : _("<noexec>")));
> }
>
> /* Prints the list of inferiors and their details on UIOUT. This is a
Yeah it looks much better. Also, if you want to factor out complexity
from this big one liner by using temporary variables, I think it would
improve it further.
Thanks,
Simon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs
2016-12-08 15:25 ` Simon Marchi
@ 2016-12-09 6:22 ` Thomas Schwinge
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Schwinge @ 2016-12-09 6:22 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Antoine Tremblay, bug-hurd
Hi!
On Thu, 08 Dec 2016 10:25:53 -0500, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> On 2016-12-08 07:01, Thomas Schwinge wrote:
> > On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build.
> > --- gdb/inferior.c
> > +++ gdb/inferior.c
> > [...]
> Yeah it looks much better. Also, if you want to factor out complexity
> from this big one liner by using temporary variables, I think it would
> improve it further.
Pushed to master:
commit 53488a6e194af11c2528e5e284facb8a6171b695
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Thu Dec 8 18:42:03 2016 +0100
Avoid PATH_MAX usage
On GNU/Hurd, there is no "#define PATH_MAX", so this failed to build.
gdb/
* inferior.c (print_selected_inferior): Avoid PATH_MAX usage.
---
gdb/ChangeLog | 4 ++++
gdb/inferior.c | 15 +++++----------
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git gdb/ChangeLog gdb/ChangeLog
index 2bd99f1..302eb6e 100644
--- gdb/ChangeLog
+++ gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-12-09 Thomas Schwinge <thomas@codesourcery.com>
+
+ * inferior.c (print_selected_inferior): Avoid PATH_MAX usage.
+
2016-12-08 Simon Marchi <simon.marchi@ericsson.com>
Thomas Schwinge <thomas@codesourcery.com>
diff --git gdb/inferior.c gdb/inferior.c
index 9fcdbd3..af6f3af 100644
--- gdb/inferior.c
+++ gdb/inferior.c
@@ -556,17 +556,12 @@ inferior_pid_to_str (int pid)
void
print_selected_inferior (struct ui_out *uiout)
{
- char buf[PATH_MAX + 256];
struct inferior *inf = current_inferior ();
-
- xsnprintf (buf, sizeof (buf),
- _("[Switching to inferior %d [%s] (%s)]\n"),
- inf->num,
- inferior_pid_to_str (inf->pid),
- (inf->pspace->pspace_exec_filename != NULL
- ? inf->pspace->pspace_exec_filename
- : _("<noexec>")));
- ui_out_text (uiout, buf);
+ const char *filename = inf->pspace->pspace_exec_filename;
+ if (filename == NULL)
+ filename = _("<noexec>");
+ ui_out_message (uiout, _("[Switching to inferior %d [%s] (%s)]\n"),
+ inf->num, inferior_pid_to_str (inf->pid), filename);
}
/* Prints the list of inferiors and their details on UIOUT. This is a
Grüße
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-12-09 6:22 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-24 21:45 [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Simon Marchi
2016-09-24 20:13 ` [PATCH v3 2/2] Add test for user context selection sync Simon Marchi
2016-10-03 17:10 ` Pedro Alves
2016-10-03 17:48 ` Simon Marchi
2016-09-25 12:41 ` [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs Eli Zaretskii
2016-09-26 2:25 ` Simon Marchi
2016-10-03 16:47 ` Pedro Alves
2016-10-03 17:40 ` Simon Marchi
2016-10-03 21:03 ` Simon Marchi
2016-12-08 12:02 ` Thomas Schwinge
2016-12-08 15:25 ` Simon Marchi
2016-12-09 6:22 ` Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).