Re: [PATCH 02/22] Create/disable/enable/delete breakpoints in TUI with mouse

[Hannes Domani <ssbssa@yahoo.de>]

 Am Montag, 8. März 2021, 10:32:09 MEZ hat Andrew Burgess <andrew.burgess@embecosm.com> Folgendes geschrieben:

> * Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> [2021-03-06 18:33:57 +0100]:
>
> > Target area is the first 3 columns of the TUI source window, where the
> > breakpoint status is shown.
> >
> > On a left click, this either creates a new breakpoint, or if one already
> > exists, inverts the enabled state of it.
> > And a middle click deletes the breakpoint.
>
> Thanks for working on this feature, this looks really exciting.
>
> The same breakpoint markers are used for the source and assembler
> windows, both of which inherit from the tui_source_window_base class.
>
> It would be nice if this breakpoint/mouse toggling support was
> supported for both of these windows, possibly by moving the click
> detection up a level in the class hierarchy?

I agree, I just personally didn't have a need for this, usually when I have
the assembler window active, it's in addition with the source window.

So I will try to do this as well.


> The documentation for the TUI is not very extensive, but the
> source/assembler windows, and their breakpoint markers are discussed
> in the 'TUI Overview' section.  I think this change should be
> documented there, as well as mentioned in the NEWS file - this is
> certainly a note worthy new feature.

As I wrote in the series header mail [1], there is still a lot of cleanup
necessary.
And the first point I wrote there was "Add comments", I should have included
documentation (+NEWS) and commit messages.

[1] https://sourceware.org/pipermail/gdb-patches/2021-March/176816.html


> Finally, I think we should consider testing.  I don't know if it is
> possible to send ctrl sequences to the console to emulate mouse
> clicks, but if not then I would suggest this: add a new command
> 'maintenance tui click X Y BUTTON', which injects a button click into
> GDB, X/Y being the click coordinate within the whole GDB terminal, and
> BUTTON being the button number.
>
> Using this it should be possible to test the functionality in this
> patch.

This may be possible on Linux, but these kind of tests will not work on
Windows, where I do all my development.

I can run (most) tests in gdb.base and gdb.python, but e.g. the ones testing
colorized output are not working for me.


 I'm grateful you looked it over, but at this point I was more hoping for
comments on the usability of the new TUI windows and the overall design,
not yet for detailed code comments.


Hannes