From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic310-57.consmr.mail.ir2.yahoo.com (sonic310-57.consmr.mail.ir2.yahoo.com [77.238.177.30]) by sourceware.org (Postfix) with ESMTPS id 82280395042C for ; Mon, 8 Mar 2021 12:00:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 82280395042C X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1615204813; bh=RtpnKYV4xVEsaxKCW6wzyb0/EL64Zpgd+VvpuACoxyw=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=LKGcKt42m079zYS8phxBpk0fwP4ESs+8qRMRaiow5GP/vIt4s0wGHGU9CECQLUZsRq5Hza8n2Qr5VubZNNrgbTN62RwR0XT4AqItftoJhjjFBxUGiUZ9XwbnmxBrjhQJpQsNjKw1OUcg5xdWtjOL2hQ+Lhdzs0vjKwGKx5twkeTtF2VVcx+xz7EQuIUkk7x+pMNGWlp24lP+NfiR1Yv3wIL9eDRgZGqBuDn5HKcr2ymYpRuRX5Clzz1ggrchNWDevBRREnzourOGAV1f+SPhiNiVkZyhr/EzxUJEdIi7AK1q1xwz9q3fK+PjHz476lhtjbTi2Q+m+FscJOaoyzTF3A== X-YMail-OSG: OZSuuAUVM1kmTLqqVTAHmXJxG_ZRiaPAcHxywzJ20JPSWC8YPNBTszodF.yJ3ro NnjwAUcsEp6OvOdCPs8vwhPtIoDDmeZxVQQFYTWjHXOlV7R9eL98eg7rHgeDx3VRV9Mg4xLJ9gv3 FqHoLeVGjNUZ7DlM8uGulNXcH3W3ZxnV0yJuEpUT9LMKL6NsSVhw333m2TlccfZx_u7.XwfyIVso Sl02d4SFIDU17N_.H7DmaLPwvsWbNLEJN2C88cpH5yUCWlIKXf64lg4CRoMLLG1kSUyzMS8kXj_X UGBUwkh_hOmtoeD2l4H.ySO9PwfuW9yaeYQ8uIfEjgdwZJdZ7rbbXbH6aX.aSWZEweN2HTp.7dRt jpIOmdxwa2VLw_U.pR8q6G_PxPq3Kc1xtiymuIS71GhPuUgTgaz..bhv2kmjjVftfLv6582xdMzR sb1ILZM_PYmTSc1NyLh7Wz_OmiJeKYDGGri.NS7PFfR8rjc.kqOC.oTgOT5sgPw3BDsP4mEPBdEr tYCd9qHHjeO7QMroxR09z2GzlRg1pIDrN7GR73i8EaqLQmcT6xtM4zArPBftOUxS2R1oOKXU5FMH BCgnCXQXk8csMQ_flCUnbv8Qx_me1EHLA1y2tv3W6tcrApU4zDR0UFBMF8ixelwyRG2GMeTRIrlv EN_CJMfamwcSTLLKBRosLwM7eJro_OdTU4HHZsOXorGygYsRI0tWhz96tqQbQELPTvJdV0E2lGGG 6TKO7TqTdSWuO2GgI0EfzwQWpN1B_SWvs.zko0C299Hvm1lXxsh61hRUHJIuwDZNxohy.kp1KxOS 1m446TeDLCOoqqCvShJB0ngj9kgIJnMgQT5KRX_wSCx44BM0kQ4lX3XKEDl6hb5.2sYsKyIwYI0l 5o6DGo6b9v_YDLv4_E.19tz4gnOC8Co4EuTR8A8oj5OZVNmmA3TCh4dcWQne8yeX9lQQ8eztF3zW doFhCfvOiunUenO1oZMY3U_469cKbtAZSnBCoT_qN9xycz06MXwWl8F8P6TOkE0wIAlQMRNJPwbS w_JYv67X7CYPMamnsEKLyrKXkJOcI89_kO6I3RsNjFw5xH9IgD8nLtpqSKP6SluDIj2pH_pu4tZa LBZMIimF8xN89DqPtrQ4t.v2M611qy1Py.qa8urb_Ja8ti1KRpWvQvyS0S.wSAuv0e2ULuhbp6nd 6Q1v_4RoaMr6zejJ50dkw2dEz6WhmjbrvwWhQ4CUXLX2E6IuMqNwL04Nt6WB9iDqyrlO5Vfba0pV TfEliKpKU99J3PEElXmA688SGuW7zR1CXJI7bl76.Z3_9CrwbFUv7GfKvaa9Y64Yn.sDW0W1UzSp xbtGK9HpiZNcJHJQdlrsk7kZLXyXmsnt1a1OQQgz4c5rl8reCa0qEG9f81USiyJVMLGtxTq.On.N 3rTZGDgGJEobrCfNAzUGXqjZXwwPIcgQWAZdebS3GBqXTOyMKyARNYdrdDswfQQGFdKkAfjaumqX 3jsZa3_7Snsav7BFmYIsNS4vImYhNfnfF_QneSwCZsFjQ_CWcuGir0ity2NpaqWXxp3P19ZJJ_Bx jCzbTtRKN70CDSAff8ZMqMDFpMcCJm0Mm4.XX5tozH_38hTuwNP8JeOSmMnOcdt8m595JITM5IWe DhJHL0unGpxvum3_pqbPrxNeTt9_lnmk5opVJVj690p0TTG8tDO252uD9Qw3kxfTatmgY9AYRBCl .oW2heL0tT1SfJsTMDv0pxSXOEzy0L.Q24Y0.sIiIZrZD4wY04JiuLL0RVeYGq2tHxStHfOjTBqo sZM.ZiJ1AlQRY8lLEItN3T.8uLuMdsIa5AzWWktQwog3EGYjGqSNbYGjmv2ik4U6LWVCCMdCB00. RnhpfpMRoqFrShfrNLiXIBe7RhjUWDEma7w3Yb5OqmAOXxeR6hW5YbW0LUBaSc4XPuqcIoOvU4AI gtE9hUYxFGh1wWhkzwaDdBmTgFriiaRBZDbOau.pjlNqf.T3DdMAwAp3R06ujOlowzQzCyplpVoY arqmi42FFCWWX8a6dIbtu.g5wZywrgszeeyPk0KHtgj7Y8CLVrhNj2rfhIoRjoE.tg0W57Qyt5RZ ICNie13YvuOrsUVwCBYWdhYs6Yiu_5_W.ThP20oqCVHDDBgIpac91UOkdxgj7XQYuu1xxG_FG2oz NZVfQZDb86SJ8vsoVK3XXQ4M3z8EmNhuYSigEXx80ziIGwYH.HUpj6JbTpbtM4_ZSzw9H7dNi9DI Z8WKXf2FSUGFZ5Th0qV9ZYjZtHnwbrhWvjIhiE9UOzRka3Rr1yoXECjDyYceafNMdlqte_Vi12Z7 SB6uV_EA3CHjt5o5NZZOa4J1PIKj9KkcVzvTcUPIeZDZmvv_2bpLhf8xAQNveWL0wsdZh_OHtF4P M14lxQeV4AgWR7Ct9ldzkT8EnE8Bp4I1piHHkp7ZK9n_SBGmw.XnxmnosFWUdesBRA.3q7auDqhf d6ElFDWCPXeGfUMqtGEsBpgJKm0hsyBrZDaiYnqHUYybeykhGZJ5_RZBxApBBQB0ZJOCimETdKWL WVCuck2DTv5RQt_Q7pY7Nx15g7Q9_QGYNWF49Ddz2jKNi6ORYIfFwlCFspu1y4UqzXVRsUVJA7na 7iw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Mon, 8 Mar 2021 12:00:13 +0000 Date: Mon, 8 Mar 2021 12:00:08 +0000 (UTC) From: Hannes Domani To: Andrew Burgess Cc: "gdb-patches@sourceware.org" Message-ID: <1882367403.1043481.1615204808474@mail.yahoo.com> In-Reply-To: <20210308093206.GI1720904@embecosm.com> References: <20210306173417.21528-1-ssbssa@yahoo.de> <20210306173417.21528-3-ssbssa@yahoo.de> <20210308093206.GI1720904@embecosm.com> Subject: Re: [PATCH 02/22] Create/disable/enable/delete breakpoints in TUI with mouse MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17872 YMailNorrin Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 12:00:16 -0000 Am Montag, 8. M=C3=A4rz 2021, 10:32:09 MEZ hat Andrew Burgess Folgendes geschrieben: > * Hannes Domani via Gdb-patches [2021-03-06 = 18:33:57 +0100]: > > > Target area is the first 3 columns of the TUI source window, where the > > breakpoint status is shown. > > > > On a left click, this either creates a new breakpoint, or if one alread= y > > exists, inverts the enabled state of it. > > And a middle click deletes the breakpoint. > > Thanks for working on this feature, this looks really exciting. > > The same breakpoint markers are used for the source and assembler > windows, both of which inherit from the tui_source_window_base class. > > It would be nice if this breakpoint/mouse toggling support was > supported for both of these windows, possibly by moving the click > detection up a level in the class hierarchy? I agree, I just personally didn't have a need for this, usually when I have the assembler window active, it's in addition with the source window. So I will try to do this as well. > The documentation for the TUI is not very extensive, but the > source/assembler windows, and their breakpoint markers are discussed > in the 'TUI Overview' section.=C2=A0 I think this change should be > documented there, as well as mentioned in the NEWS file - this is > certainly a note worthy new feature. As I wrote in the series header mail [1], there is still a lot of cleanup necessary. And the first point I wrote there was "Add comments", I should have include= d documentation (+NEWS) and commit messages. [1] https://sourceware.org/pipermail/gdb-patches/2021-March/176816.html > Finally, I think we should consider testing.=C2=A0 I don't know if it is > possible to send ctrl sequences to the console to emulate mouse > clicks, but if not then I would suggest this: add a new command > 'maintenance tui click X Y BUTTON', which injects a button click into > GDB, X/Y being the click coordinate within the whole GDB terminal, and > BUTTON being the button number. > > Using this it should be possible to test the functionality in this > patch. This may be possible on Linux, but these kind of tests will not work on Windows, where I do all my development. I can run (most) tests in gdb.base and gdb.python, but e.g. the ones testin= g colorized output are not working for me. I'm grateful you looked it over, but at this point I was more hoping for comments on the usability of the new TUI windows and the overall design, not yet for detailed code comments. Hannes