From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic301-21.consmr.mail.ir2.yahoo.com (sonic301-21.consmr.mail.ir2.yahoo.com [77.238.176.98]) by sourceware.org (Postfix) with ESMTPS id 9E9B1384190A for ; Tue, 14 Nov 2023 10:53:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E9B1384190A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E9B1384190A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.176.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699959222; cv=none; b=f9qRN6HCmHOml5gVNavkAbTyHnlmuyl0rkSeZhwba0A+YiuyDno/puSrC3IGYCVOGfXCoVujmDJoojvlJxBXrM7K57S6Pt27fGPmWeXG1tWWA6d9w3vDDWtLFR1ktLOrbIGa/7uwAvbL30SEI87YdFvvOxRScyonmbcON6iHPwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699959222; c=relaxed/simple; bh=dI5vGvmvQ5W+qXSr0BOuZHPt8gnqPT2cYcRZRU6/IIY=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=YLCRvKHZ7DfMy5NASJ1ZWsrTY+nezluD8pwTtNF+Gzn+gpA9XGkO3bkn8BpVVFpefiLvOOBwNGQMFJx637ddvKVd5/siKThUQoATcnqUli6j5CmOn4kvmWqMuKKEzkgtkytrQ6QouLbSL9wIUqczf/VQ3hg8aG9Q042mgac/oLI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1699959219; bh=dI5vGvmvQ5W+qXSr0BOuZHPt8gnqPT2cYcRZRU6/IIY=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=CSi/3qa0iSGwuJnFPPqDonjfw+pXrJ9vUr9IV85/njExWYSl7cUqWRGg7e9p9LNLoIJQtzlrbW2bhOVe4hUEWQNaqYIXsoEk+ybZXHXraCLxF2eDd3Jy9x0aVJg7uNODlXY8j8mY/OLRzqpXR/bRb1S0fw9+s4CkgIBgch9YymMn8t7xdAiI87ca+3tv0pa+JTzHdpqEEd/jUq9jKdhQmMjbpNGw+MAkbS7z1K5OpNhHEoZOYXlzSu5iEPGDVDfQId+CQm5NOFKMVNFvk0qIwLqbTYdyen4UMbg1D1eqX8w5P4RM3Dn+2lvu9twXaMDGoSBVekklJqVKpF7zQrqx2Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1699959219; bh=QlSs4BhlI3ip09sa9Ohe6V1FHH5Yy1cJlucSC9+KO1a=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=nYVR/PA7Ym4cWwg4so5tyV5i3p4ri9zXN+n2iMmw1AQhUU6U2m+nxxR7erp7EgRJaJ/OD9MkgXYh67qSyhtXHexFIdT4KbDvqSmsAEa/RK4vqzpIb8Aw9mgwX/yKXK7m8iFhCkVFkCvDgFd52dDP8sbDyQTwJj43uHyLa7QlWImZ2MxHXkgBh0Atl8hurHbgEucYBhJ2iO3wQ/SZE0NVQB3x8yzULe/F6JCQ7y3uxAmgF5JaEPoBjBBLzEjhPe3k/UyTGV8zcnefpqKFuiCRsmSy2g1aMQpOhEzbKd6OyXRo4MFnIt/fXn7QHsz+tpQhdCtP9UnK0h/h0woSsKHDpA== X-YMail-OSG: GRnvmKsVM1kYi8o0yaVy2FjkT8biiAJRABdAbRLXn28ivfJWLMEnt4Xwikt1CDY DAeZ1U_QG2nOc4wUrCRQiknyEGD52Q1X9HN_cjW2TRZiyPMkpPenykdfqNlol6tLRa5xlJCo4wmP rLKFqGHZIrqtgvsj55MQMPNWggmE.6nZClMAHLkYdwPx7TO6fqlDbjbNAl.WY4dAO5RCgNhQGqsN MkEzPPDGNGFjF3GRV4iNn2pV4YwQ1r.YXSwme3dqDuksrxmCMFm3yma60gTJefdEH0g5lWO157im Mlh8lzWhoP4UVp5uNNwMw27mbSGpaRbesCX7KrcWJ6nAiRbYsCigKG3h4.UzOJWkrw8nU8GO_TDl vvZ84OSgPBglQjhbFzviCMBHdAhpfm6JFWCrygZiE57Fgu5ylBoTbYpSO.F6CEU2WEafNzan08Gc MoozdeV2d7_Vdl9gm8NKkOxqTCJEOTsFnpxhfTbyYjtni0_tjH9C7vlyCiv7bwr0gRJkVGw6kwiO cEWG6xOAOsk5wNwZ1WCqBsHCm1XLA6WCK1791_gGvATbD9LeAW_8nJZf8AOtyLvbmvS5zZD3SIg4 hWmRMYw95XbkeA4Im8n9PSqCXbFsyMtbmGDawCSY782XAAybwhLIaaQn_vrbwkhRRe.4fuOdzVuj 3UqZYko_.dBX5OwYcvGfdrd3lcnyJqgMBaVtsfLooaFYNQwonw8z0i.4Lnbhh2DoSNx9u4aBhN7V JqDCY4EQsvA1LtGAsugg2haZrvw8PKiugjHAzJ.6CfVxkbLUvOJdSheeKG6VQ_8j4purrMaLab53 YdR_Rpgil7kRMnL27fRBznxsuQoTDgdSCmMYldUoGWFKQzIiH1bB.XhGvimQKJ5wNXqyWW5vfHjk eMlTufDLSIIYUuXzBXuuGyMJR4o_viuEPicLE3xv1lhHfMrNAqcSJCf4AZHgEqKebgQqm..bh53f S8nFO4_MorwsxOQBK.w6pFVdTFv3SOEyn6QMzyAl0N9HzbKHiTWzDGA81qeBY.n1eizqC9rodBuq 40Q5IdeOeEhdFvtBq2lb5icNWLlKqckr2xeuqUXxRjzVHvn1KBtcZQnPSTu2LM6pfqjZyGPCqJSD vl2UDFZUc1SJYQIC2FlVUteeQVaxVNmMra0RnBDu0xpo3AyeXJrlyY__KiuckE4AII2VROprWRVy Zue.Hzsuvg5PPL7wak7nBmAX7I6lEKeqRwakyrHBlBQoKTqB.Ein5VlvIG01lsY.6.2vHdtSZ30y 57.0KCMzS1LsLKOTuvXUk1HgAxi5JQDxstAFxNJgwpmI0ML9VmPvYPoT1uyVDbh3InjRk7.LBPeR R0s7YbgwzfbnK10M_wRdRPtA_04YhCW9t3eLhZflq.xj9.0HQRV4vJjpTmiXRqmbUEuadTQQXe4L 7.XzS72XAzkF9E5K0f88jdd6fgdN1Ra97YQLIwnwatSY7DJPi4YHzNksvRNIGIAyS3kT7exavuvV nI0azKvIsUfBoAaI3DnmEfiJxaRJXP2DMQjQsbrLfEo.7Ln_3KJDhZwz9Bi2Wp1L214csgpaoxxo 79VJ2xp7YqrqpWKpJ3ShWRkCyrSmxe.K2rw3gTF9AQf4yzZ5xs2g4rSLiPKqUgMagsgGkkk_9T3Y .ARpgcbhRyLxKVq6y62jdfL2C9wcyU1VAEicHUhuLY5dz9Byu9SrESTlG8yNw2_GIMWhNUcRxVpy u7vb71zDw4up25Jx2NOr.TuFna5vE5R5WJ5ExJw9Kx1rmVwXgiEunJ.Z9.JWs4ZVFCRWmirt6ufo YxCyK5rCnIjz7jAQfR5PkChg1aDT6mFqhTvqOXOYwUK_K0nsGpRazap2rsUE09l.b6UiDz647SV5 .fTaDu0lqBiQnN7gtpkXexLiUKRk.nDX8wAMWOljeYTmBTD_mQi3irEqjklZZTMyHbPSdG7fWZcg LaSpHJvWkSpbu17HQQlszKUroXJI25cryhyfg8m2_MxP70Mqc.3C3sQxZgjfaOtdwInsP_Hj.M3t LIxlccckOpIfYFk4BfmcLOvlk0DSLu3avEw_r.HrngHxOVMA4X8_cGIz6jLHSymmxKudb7qUDVFj 1rjGRMjuzijIF7T_hHbV.QRlwzHyUEthU9Dg8Y.5fJVl021JfRyHaUdLtvzH42izhrbGzGEnsvBL QgEod2BPaOZGlxkMruOp4ARhognaGRemRR1L319gQZIF2eFFIdh2CPLN27jzxei6rNgGivUuuG3d MemI- X-Sonic-MF: X-Sonic-ID: 73717655-e5c4-49d5-a0db-b9fec027cb5d Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Tue, 14 Nov 2023 10:53:39 +0000 Date: Tue, 14 Nov 2023 10:53:35 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" Message-ID: <1892245673.5086609.1699959215414@mail.yahoo.com> In-Reply-To: <1686556384.2549191.1698847056400@mail.yahoo.com> References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> <1856017925.2892615.1696269030810@mail.yahoo.com> <1686556384.2549191.1698847056400@mail.yahoo.com> Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21896 YMailNorrin X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. Am Mittwoch, 1. November 2023, 14:58:05 MEZ hat Hannes Domani Folgendes geschrieben: > Ping. > > > Am Montag, 2. Oktober 2023, 19:51:03 MESZ hat Hannes Domani via Gdb-patch= es Folgendes geschrieben: > > Ping. > > > Am Donnerstag, 14. September 2023, 18:28:30 MESZ hat Hannes Domani via Gd= b-patches Folgendes geschrieben: > > > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > > caused a regression that meant hardware watchpoint stops would not > > trigger in reverse execution or replay mode.=C2=A0 This was documented = in > > PR breakpoints/21969. > > The problem is that record_check_stopped_by_breakpoint always overwrite= s > > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT > > value which would be checked afterwards. > > > > This commit fixes that by checking if record_full_stop_reason is > > TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. > > > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > > --- > > gdb/record-full.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 4 +++- > > gdb/testsuite/gdb.reverse/watch-reverse.exp | 4 ++++ > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/record-full.c b/gdb/record-full.c > > index faf8b595d22..da785ef4b2a 100644 > > --- a/gdb/record-full.c > > +++ b/gdb/record-full.c > > @@ -1382,7 +1382,9 @@ record_full_wait_1 (struct target_ops *ops, > > > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 /* check breakpoint */ > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 tmp_pc =3D regcache_read_pc (regcache); > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 if (record_check_stopped_by_breakpoint > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 if (record_full_stop_reason > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 !=3D TARGET_STOPPED_BY_WATCHPOINT > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 && record_check_stopped_by_breakpoint > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (aspace, tmp_pc, &record_full_stop_reason)) > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= { > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 if (record_debug) > > diff --git a/gdb/testsuite/gdb.reverse/watch-reverse.exp b/gdb/testsuit= e/gdb.reverse/watch-reverse.exp > > index 6b81a6fdf88..a7126ac9b1d 100644 > > --- a/gdb/testsuite/gdb.reverse/watch-reverse.exp > > +++ b/gdb/testsuite/gdb.reverse/watch-reverse.exp > > @@ -118,8 +118,12 @@ gdb_test "continue" \ > >=C2=A0=C2=A0=C2=A0=C2=A0 ".*\[Ww\]atchpoint.*ival3.*Old value =3D 0.*New= value =3D -1.*ival3 =3D count; ival4 =3D count;.*" \ > >=C2=A0=C2=A0=C2=A0=C2=A0 "watchpoint hit in reverse, fifth time" > > > > +gdb_test_no_output "disable \$bpnum" "disable non-hw watchpoint" > > + > > gdb_test_no_output "set can-use-hw-watchpoints 1" "enable hw watchpoint= s" > > > > +gdb_test_no_output "enable \$bpnum" "enable hw watchpoint" > > + > > ### > > ### > > ### > > -- > > 2.35.1 >