From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by sourceware.org (Postfix) with ESMTPS id D5216386F027 for ; Tue, 23 Feb 2021 14:38:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5216386F027 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OphtGXU1NfwJXxvPp+AAnZ4vsURFxQlZHyJYnFHWaRh6cDxWy3qQ8lvzSx9Dzsmi2c+xcVD8DvJvozpmF+X5Kix7RVPN62nBX9N4TiWZC3qcf0tkqYIZkOhLF/ruFj07FO/FmPcIgJ1CX9+wUYHHOReG/Bq9QN343FxFiYdAXextl4QHm5Zy730BCC+VffXMNNGSZ1v1gd7scy55I4/ov9lzbK05Fud3b5qHa5Gw92sr/Weh4xhugf/sbTe9kSKlYPSZe74UnUJ5GK2YVSVAFVdu7vqApJRQD1olxfhdW0d9dnBrkOYqBwtkPCqSc9UpIZTU/9e8KOYkYPXWo2uWcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UIToC7L8hXNMrQS44XCedWtkfY10cupi+uZnt9wK7/c=; b=le/HBGHyGNdlOhDvfmy4VUxqUcTLK/W0JbJADHhyMoIv62CWgNpT8EoodVaTVr86QwgKIl+3Gst+VXuJ6O98JExL3HYMVWLrE/ajViqh5ZEVe3d9tOicQLhfAA6fqzVXGvFPAUHAV6tfBnM6TYcowukU51AGaXB47vcUOlKml5SZUcTzxLNXFrXXTzDdgCdg9sY1p3yK/LnDbR7xgsgrQpOLRDOY0VUs3vNCCLo2tRyeqAk+MlbkvCCZv240PBnTVpDZeB/LatGF0cCas5YXUk6hfAeFoS/K6hzoCwaYz5IvRPtjme7qSTtUel0TARDSemxtBCwWmF/yGuTYKq1DEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4974.namprd12.prod.outlook.com (2603:10b6:5:1bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32; Tue, 23 Feb 2021 14:38:51 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 14:38:51 +0000 Subject: Re: [PATCH 14/30] Simplify dwarf_expr_context class interface To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-15-Zoran.Zaric@amd.com> <87r1lqdyuu.fsf@tromey.com> From: Zoran Zaric Message-ID: <18ec46ff-bb23-9499-4ed5-eef5da1179c1@amd.com> Date: Tue, 23 Feb 2021 14:38:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87r1lqdyuu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:3c68:1988:3c97:9289] X-ClientProxiedBy: LNXP265CA0076.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::16) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:3c68:1988:3c97:9289] (2a00:23c7:5a85:6801:3c68:1988:3c97:9289) by LNXP265CA0076.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.31 via Frontend Transport; Tue, 23 Feb 2021 14:38:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 92336c78-f88d-4374-c3de-08d8d808bce8 X-MS-TrafficTypeDiagnostic: DM6PR12MB4974: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVG5LS4yrSl9SD1APBmehGw2+8yizLFy/1XsCm/uj6EOjGlbIgnyvsvxN/aJyYnuCa83fU3dhx7EnDCrVhJGgGsd0AyDrvhQ315WEMguzsPhkklWi8rmhqok1l8JtGDLJEqFCO4DzV3sKK+QpdnSsiQGBfaXc1JWlfC7JaykUjtFQ8UK3PWxAK+TgtpesBjwoo9xZnq782Wl3OpJOJEI5Rq8dAi2Sw7fKnZP9JH2glF10MawnLu+GKQTNabO84aSYfDqFdB2kYH3j7UUvX/Pa4DBM9v/t8TDViTkT3HP2b9xSuuvoe6F+Br/Fn4fKR9iK5Ou+TL0tj6jKGiPGVNnQlK19Ijwn0Wj94ga07YyvyWFp14xxA74kNGv9Ma36LUTVEc/B7gJ2FOIF4JDrZebmX31uxrRMJg1w/SRGzlr+CztzBEPso5/qB2xO5rjx0md16E0ZsbNVun7nlngvBO2DN7kYnZtq2nIohJ+h8Y1RumtQvPULbZQJnZgP7fJzMqIIcVp1iPM2t/6jwQHawTQT7HdNGC9vkkiidSR0YWEhSWR+oYzHgDz/whSL4vVqPegCKy+BZUHsSiUx2zfJHqjTIIsH4ktJA6CvIw2iACudmk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(2616005)(66556008)(2906002)(31686004)(8676002)(8936002)(316002)(16526019)(31696002)(52116002)(66476007)(66946007)(86362001)(4744005)(186003)(478600001)(110136005)(6666004)(6486002)(36756003)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SUlSWmxnL3lpRW4rVGZiZE1YQmZRaFFHSDNTM1FKOXFFVjFKVU4zKzh5OElU?= =?utf-8?B?aTR4WmEzK0VtV01xeHVxZlJrcTlqRFB2aTJ0dDQ0eVlwcUV2aG5PdnFYOTVv?= =?utf-8?B?WTBxWkRtTFMzSCtQeTMyaHRxK0hFY0tOc1VoaVpuTTFSVlJIeUhQbWxMbStP?= =?utf-8?B?RzNYMVk3Mk56T0oxVEV4bGtnMStudkF6QnkyZWptUUoyeXlVcnRFa0FqTS9C?= =?utf-8?B?YUhscThIYTl4M1hiMncrVnprTjRmVm9pVk02NG1HLzluTmNOVU9RczVqQmp4?= =?utf-8?B?UkNFSDBuMkp2SG44QklsRzY1S2JXTGZ2WUwzcVpzL2dsSCs1UERQQ3cvaHBW?= =?utf-8?B?Y2FDMjd4b1F3V21HVVp1eWtQaDRHOEt1ZGRTbDZvZmNpRER2WUhsVDhKdGEz?= =?utf-8?B?VXNtL1J0QmNmaDhycGJMVE5SKzM5SmI1MExXTGhDMGFaSW90RzdxTGZxREZD?= =?utf-8?B?eVA0N2JaOUk3TWxkNVl5a1o0ZXgycHZJdU5wMUdOQkNPVEJlSUZ2NFVENGVE?= =?utf-8?B?NVNvL3duYWdmem9GaThHN084ZEdmWFhDMndUSjVoekZnQjRMU01QRzg1cHJz?= =?utf-8?B?OE1yN1FZcEs0ZVJiMGVUalJLalMxSWF4TlozaWlFNkJ1dEhiSU5PamNSaHI0?= =?utf-8?B?aDlUM2d6cUF6RkJlTUxvVTVmd21Nd2s2T1NvWVBLYTA2N2dxTTV5bzNOa1NF?= =?utf-8?B?Mk5MQVF3Ym5DK3VxM0J4ZGdXTmJFdldTcE11MFF6YzJSUHpyYUZ3ckJSL09r?= =?utf-8?B?dngwK2pIRWpQb1YvZXNMY21KY0FRamR1eUtKWWJCNSt6aExrajhSYXRRNnF3?= =?utf-8?B?dTlSNENKQXkzb3pLLzVtZEFxM0Zxb25penFwQzJNTzk3alJRL2Q0V1QvakR0?= =?utf-8?B?NW1vUGUrL3dGemdDSG00QnJhWm1uemxpMXFRRW83WGk5NUFuQzlibzJYTXpQ?= =?utf-8?B?N0FrWmdZOHppNHNZUnFobEkveDJHTjJNZVF4UHlsQkdaSWlPZkwwc25KU0Rr?= =?utf-8?B?K3F0TUYyRWo5SGwwSXNNQUNLV09oMnJQSVpNT3FwKzA5c0dUUlg5cHhrN25U?= =?utf-8?B?YWdDUVJ6UnJOWjJkenhoSE1ra0FCUGNVMXR6UHoxM1N0OFZQNmRWcnV1YTFK?= =?utf-8?B?YnRhSU1ydmgzSzl4Y1F1dUozR0RFWmR0WVY3ZWFLdGZPWlU1VkY0ZGRvUSto?= =?utf-8?B?NkJ5Vmw2NXRGSzlNb3c5dUExUTFsN1M5RlU4QWxGT3VMTVRDWFZtYnhoZVR2?= =?utf-8?B?aC9SZ2N2Qm43UnlqY2EzWGl1WnBuSUs0SXN3Z1Nvd2tHTzBjNHVIK2dPYXpH?= =?utf-8?B?a0xsTW9oNGhDemF6ZFlIUWRWTDI2Z2Uzei8wZlYvSGJ0dDlGREVZbHNNWWJ3?= =?utf-8?B?UTlucFFta0c1UllwM3dWdzg3Rnk4MnZ1RDAzSHBzcS92cVVXOEJ0Rm45QVJY?= =?utf-8?B?SEJTL0ZEdzY2RDlKS3dwWWhZZVc4Tm40UU9ubTZ5ZExPNnFSMlpsa0NFR0lB?= =?utf-8?B?OWk2T0RydlF6MlpoL1RYcVJwTnVxTCtacVc4bHp4eFM5L1FwdkswQjZSWlNs?= =?utf-8?B?cWlYRlNONlRLTkYrTHgrWmEyMFRqRTBEalQxZTFHaFFqTytvallucDd6OEhS?= =?utf-8?B?cUJLQTdEQnMzQWVWN0MwWVljUXBEL1p6QnRJTk02Qm1FZjZRVURXYTRNZWxa?= =?utf-8?B?OTJyZENoekg4TFE4bkFQTHcva2w3QmMyZWUrVlF2Zm05Mlo5akE1b0k4RjdD?= =?utf-8?B?b3FxMktFRDhQN0I2a2JGTUVId0dRMmtuTUlwYlY5U1M3b1ZURGtZaEdKdFRD?= =?utf-8?B?RTJUanNFMlFXMVBwUGVBZFZ5TWM5TjJvSi9PSzgzRVhPNVFDa0t6UlE0OWEw?= =?utf-8?Q?zE2rDyzhVaebt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92336c78-f88d-4374-c3de-08d8d808bce8 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 14:38:51.5633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z14wN9JJV7qA4NCaivKKz5JCqQyHkMvKe9cWjdUzv1WTG6zeOELiwplUWzziT7qSGpG8fa27bydw8TDE7pLArg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4974 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 14:38:55 -0000 > > Zoran> The eval_exp method is the method that evaluates a DWARF expression > Zoran> and provides the evaluation result, in a form of a single struct > Zoran> value object that describes a location. > > How about just calling this method "evaluate"? > Same length, but no abbreviations. > > Otherwise this looks good to me. > > Tom > Will be changed in the next patch series. Zoran