From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: pedro@palves.net, aburgess@redhat.com
Subject: [Ping][PATCH v3 0/2] Fix reverse nexting over recursions
Date: Wed, 14 Sep 2022 15:16:39 +0200 [thread overview]
Message-ID: <1908ddbc-75ed-c0ad-e07e-0567c7e0bea6@redhat.com> (raw)
In-Reply-To: <20220831120727.2742360-1-blarsen@redhat.com>
ping!
Cheers,
Bruno
On 31/08/2022 14:07, Bruno Larsen wrote:
> This patch series fixes gdb record/16678, GDB being unable to
> reverse-next over a recursive function. However, the simple way to fix
> it hit a snag when I discovered that the amd64 epilogue unwinder would
> give a different frame id than the dwarf2 unwinder would in the rest of
> the function. This patch series first change this discrepancy, then
> fixes the bug.
>
> Changelog for v3:
> * fix some comments on the amd64_epilogue_unwinder
> * fix style for the step-reverse test
>
> Changelog for v2:
> * Implemented Pedro Alves's suggestion to simplify the fix
> * Added the first patch to fix a regression that the simple fix
> would introduce.
>
> Bruno Larsen (2):
> Change calculation of frame_id by amd64 epilogue unwinder
> gdb/reverse: Fix stepping over recursive functions
>
> gdb/amd64-tdep.c | 10 +-
> gdb/infrun.c | 2 +-
> .../gdb.base/unwind-on-each-insn-foo.c | 22 +++
> gdb/testsuite/gdb.base/unwind-on-each-insn.c | 25 +++
> .../gdb.base/unwind-on-each-insn.exp | 154 ++++++++++++++++++
> gdb/testsuite/gdb.reverse/step-precsave.exp | 6 +-
> gdb/testsuite/gdb.reverse/step-reverse.c | 18 +-
> gdb/testsuite/gdb.reverse/step-reverse.exp | 58 ++++++-
> 8 files changed, 282 insertions(+), 13 deletions(-)
> create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn-foo.c
> create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.c
> create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.exp
>
next prev parent reply other threads:[~2022-09-14 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 12:07 [PATCH " Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 1/2] Change calculation of frame_id by amd64 epilogue unwinder Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 2/2] gdb/reverse: Fix stepping over recursive functions Bruno Larsen
2022-09-30 18:28 ` Pedro Alves
2022-10-04 16:40 ` Bruno Larsen
2022-09-14 13:16 ` Bruno Larsen [this message]
2022-09-22 14:13 ` [PINGv2][PATCH v3 0/2] Fix reverse nexting over recursions Bruno Larsen
2022-09-29 7:02 ` [PINGv3][PATCH " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1908ddbc-75ed-c0ad-e07e-0567c7e0bea6@redhat.com \
--to=blarsen@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).