From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3148F3857C46 for ; Wed, 14 Sep 2022 13:16:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3148F3857C46 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-592-w8XFOsbUOUajiVCQR2C8mg-1; Wed, 14 Sep 2022 09:16:48 -0400 X-MC-Unique: w8XFOsbUOUajiVCQR2C8mg-1 Received: by mail-qv1-f69.google.com with SMTP id dw19-20020a0562140a1300b004a8eee124b4so10487292qvb.21 for ; Wed, 14 Sep 2022 06:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=GC8HLC2vBV907vFKxD8EFClnCw3NuhAP2/SIU7m5GyQ=; b=fmpdlAw/Ntw9WCYVU6/g43SvAW5Z6ZP0ZNlzsZVF0bnFJk7qttxpZ+jkgYmtZWnIsC BU9m3Vw94xMGo+1oQH0QQL/ZR72jYVPw3UCY0ulhBD6Oz2lGpmAjvPLfLi5bmItnW+5C DPEqxTbL+aoa5grSAVo5ICae0dRTRUQU+XOe8gYm/Zwru2LC2/1O44mFon00jVN4a87U +kO56MmYwXG6RwOImqEKFcOUKE7Pr52HQDbo25F1icc1rM4dUd0zYbSHB6djf050ecXs gQCc3ARvBPPyaKWAzp5xWn0vM7Sp1enCKogiqwzDbzT1XYktbANhRHYcWBAdG1gjEtBe WZpA== X-Gm-Message-State: ACgBeo01aMajVGn8wuOTZWUfOYctZSIoKVO0F5/fihL7cAJSjNClO2di 1F4d11dFRFy2oZfpCpukAJBFLf8hVt2OrneSIdoLnfb0GmJa0lxX8zdPSk0wTtnJ2rO+Hx7eomI UzFeNwCNsFNHlBO92Yz0WFl24OYf1AMXQOTO2s1k0EXMwAKugc+w2hu4sfCLVhK7Vgn0HRJWS X-Received: by 2002:a05:622a:1393:b0:35c:bddc:129d with SMTP id o19-20020a05622a139300b0035cbddc129dmr1251797qtk.399.1663161402971; Wed, 14 Sep 2022 06:16:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR6AOibo1mWkifEZQuzZycRUMPWy+lTPIYOsPTDHFIdiAxuAjRB+ZYjuaV+WSEOBazVyngtk3g== X-Received: by 2002:a05:622a:1393:b0:35c:bddc:129d with SMTP id o19-20020a05622a139300b0035cbddc129dmr1251745qtk.399.1663161402524; Wed, 14 Sep 2022 06:16:42 -0700 (PDT) Received: from [192.168.0.45] (ip-213-220-232-121.bb.vodafone.cz. [213.220.232.121]) by smtp.gmail.com with ESMTPSA id m22-20020a05620a291600b006bba46e5eeasm1924574qkp.37.2022.09.14.06.16.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 06:16:41 -0700 (PDT) Message-ID: <1908ddbc-75ed-c0ad-e07e-0567c7e0bea6@redhat.com> Date: Wed, 14 Sep 2022 15:16:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: [Ping][PATCH v3 0/2] Fix reverse nexting over recursions To: gdb-patches@sourceware.org Cc: pedro@palves.net, aburgess@redhat.com References: <20220831120727.2742360-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: <20220831120727.2742360-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 13:16:58 -0000 ping! Cheers, Bruno On 31/08/2022 14:07, Bruno Larsen wrote: > This patch series fixes gdb record/16678, GDB being unable to > reverse-next over a recursive function. However, the simple way to fix > it hit a snag when I discovered that the amd64 epilogue unwinder would > give a different frame id than the dwarf2 unwinder would in the rest of > the function. This patch series first change this discrepancy, then > fixes the bug. > > Changelog for v3: > * fix some comments on the amd64_epilogue_unwinder > * fix style for the step-reverse test > > Changelog for v2: > * Implemented Pedro Alves's suggestion to simplify the fix > * Added the first patch to fix a regression that the simple fix > would introduce. > > Bruno Larsen (2): > Change calculation of frame_id by amd64 epilogue unwinder > gdb/reverse: Fix stepping over recursive functions > > gdb/amd64-tdep.c | 10 +- > gdb/infrun.c | 2 +- > .../gdb.base/unwind-on-each-insn-foo.c | 22 +++ > gdb/testsuite/gdb.base/unwind-on-each-insn.c | 25 +++ > .../gdb.base/unwind-on-each-insn.exp | 154 ++++++++++++++++++ > gdb/testsuite/gdb.reverse/step-precsave.exp | 6 +- > gdb/testsuite/gdb.reverse/step-reverse.c | 18 +- > gdb/testsuite/gdb.reverse/step-reverse.exp | 58 ++++++- > 8 files changed, 282 insertions(+), 13 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn-foo.c > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.c > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.exp >