From: JuYoung Kim <j0.kim@samsung.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: 김주영 <j0.kim@samsung.com>
Subject: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
Date: Mon, 15 Nov 2010 01:21:00 -0000 [thread overview]
Message-ID: <19193243.6341289784074300.JavaMail.weblogic@epml17> (raw)
Hello, My name is Kim, Juyoung at TmaxCore co. in south korea.
I've sent this email last week but haven't receive any reply or inform.
Today I found the email was encoded in korean and maybe you could not read it.
So, I send this mail again, and I hope you reply me as possible as you can, please.
It is about subfile for DWARF.
When you see the function dwarf2_start_subfile() in the source, there is a comment about source's file name.
Some compiler ( like RCVT3.1 ) include '/' at the end of dir name.
For example,
in case, DW_AT_name: /srcdir/list0.c
you expect
files.files[0].name: list0.h
files.files[0].dir: /srcdir
but, the DWARF made by RVCT3.1 is like this.
files.files[0].name: list0.h
files.files[0].dir: /srcdir/
then the function dwarf2_start_subfile(); make the fullname "/srcdir//list0.c"
, which result in the gdb cannot find the source's debugging information.
The function dwarf2_start_subfile() is at gdb/dwarf2read.c:8650.
The original source code is
.........
if (!IS_ABSOLUTE_PATH (filename) && dirname != NULL) {
fullname = concat (dirname, SLASH_STRING, filename, (char *)NULL);
}
else
fullname = filename;
........
I changed it as below.
........
if (!IS_ABSOLUTE_PATH (filename) && dirname != NULL) {
if (dirname[strlen(dirname)-1] == '/' || dirname[strlen(dirname)-1] == '')
fullname = concat (dirname, filename, (char *)NULL);
else fullname = concat (dirname, SLASH_STRING, filename, (char *)NULL);
}
else
fullname = filename;
..........
This is my first time to report the patch.
So please, inform me if my way of reporting is not proper.
Thanks.
next reply other threads:[~2010-11-15 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 1:21 JuYoung Kim [this message]
2010-11-15 4:09 ` Eli Zaretskii
2010-11-15 6:25 JuYoung Kim
2010-11-15 16:58 ` Joel Brobecker
2010-11-15 18:05 ` Nathan Froyd
2010-11-15 18:34 ` Eli Zaretskii
2010-11-23 20:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19193243.6341289784074300.JavaMail.weblogic@epml17 \
--to=j0.kim@samsung.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).