Re: [PATCH 1/3] gdb/testsuite: Fix broken regexp in gdbstub case

[Pedro Alves <palves@redhat.com>]

On 05/03/2018 08:41 PM, Andrew Burgess wrote:
> * Pedro Alves <palves@redhat.com> [2018-04-13 13:12:30 +0100]:
> 
>> On 04/09/2018 04:15 PM, Andrew Burgess wrote:
>>> When $use_gdb_stub is true then, when we start an MI target there's a
>>> regexp to match GDB's startup pattern.  Unfortunately the pattern is
>>> broken, and we're also missing a timeout case in the match list (which
>>> would have helped point out that the regexp was broken).
>>
>> That seems to have been added by:
>>  https://sourceware.org/ml/gdb-patches/2015-12/msg00357.html
>>
>> curious how it seems to have worked back then.  I wonder whether
>> it was GDB's CLI-in-MI output that changed meanwhile?
>>
>> I'd have appreciated a bit more detail on what is actually broken in
>> the pattern.  The git log above gives no clue, and the diff is not
>> exactly easy to read.  I trust that it's now correct though.  Thus, OK.
> 
> I aim to please, 

:-)

> so here's a revised commit message detailing what
> changed.  The actual patch content hasn't changed.  I'll wait a few
> days, but if I don't hear anything I'll assume your approval above
> still stands and apply the patch.

Perfect.  This is OK.

Thanks,
Pedro Alves