From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50488 invoked by alias); 11 Jul 2017 16:26:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50361 invoked by uid 89); 11 Jul 2017 16:26:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:913, H*F:D*freebsd.org X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Jul 2017 16:26:12 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 2CEAC10AF09; Tue, 11 Jul 2017 12:26:09 -0400 (EDT) From: John Baldwin To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Include the fs_base and gs_base registers in amd64 target descriptions. Date: Tue, 11 Jul 2017 16:26:00 -0000 Message-ID: <1947436.992bOZrjK6@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <86shi3qu5m.fsf@gmail.com> References: <20170627224948.99138-1-jhb@FreeBSD.org> <20170627224948.99138-2-jhb@FreeBSD.org> <86shi3qu5m.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00100.txt.bz2 On Tuesday, July 11, 2017 09:01:25 AM Yao Qi wrote: > John Baldwin writes: > > > This permits these registers to be used with non-Linux targets. > > Some GDBserver uses these target description files, like > x86_64-*-mingw*, after this change, GDBserver will reply GDB the target > description including "64bit-segments.xml". Then, GDB will request the > contents of 64bit-segments.xml from GDBserver, looks 64bit-segments.xml > is already builtin in GDBserver, so there isn't an issue here. > > The patch is good to me. > > P.S. this is a good example to show the inflexibility in current target > description. After we change it to my new approach of target > description, this change will be just two or three lines :) Agreed. :) The combinatorics with XSAVE on x86 is especially bad. -- John Baldwin