From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <kamil@netbsd.org>,
Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Propose GDB 10 branch this Fri-Sun (Sep 11-13) [2020-09-05 Update]
Date: Thu, 10 Sep 2020 11:01:42 -0400 [thread overview]
Message-ID: <1967229a-df6a-cc8f-8228-b4ae63858298@simark.ca> (raw)
In-Reply-To: <71a16911-121e-6d8f-5b6e-6f1ebf5cfeff@netbsd.org>
On 2020-09-08 9:51 a.m., Kamil Rytarowski wrote:
> On 08.09.2020 15:49, Joel Brobecker wrote:
>>> I think that's reasonable. I just finished taking a look, I did review it
>>> as best as I could. There's not much risk in merging it, and the sooner this
>>> is available upstream, the better, so I think we should just go ahead with it.
>>>
>>> Of course, the more pair of eyes on the code the better, so if somebody else
>>> wants to take a look, go ahead.
>>>
>>> I would also consider including the gdbserver support for ARC, with the same
>>> logic. But I don't think that has to block the branch creation, we can easily
>>> cherry-pick it.
>>
>> I'm not opposed to these going into GDB 10 on the basis that they
>> are isolated pieces of code that can't affect the rest. On the other
>> hand, if those can be safely pushed at the last minute, they should
>> also be cherry-pickable on the branch, so given the very large delay
>> the branching has already suffered, I would not delay branching
>> for this new feature further. We can simply cherry-pick those later.
>> Would that be acceptable?
>>
>
> Personally, I consider the patchset to be ready to merge, but it depends
> on the reviewers with approval privilege.
>
This is now merged (any post-merge review is welcome, but I believed it looked good enough that we didn't need to delay it further).
Simon
next prev parent reply other threads:[~2020-09-10 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 20:53 Joel Brobecker
2020-09-07 0:07 ` Kamil Rytarowski
2020-09-07 20:02 ` Simon Marchi
2020-09-08 13:49 ` Joel Brobecker
2020-09-08 13:51 ` Kamil Rytarowski
2020-09-10 15:01 ` Simon Marchi [this message]
2020-09-08 15:40 ` Christian Biesinger
2020-09-08 17:06 ` Joel Brobecker
2020-09-10 15:03 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1967229a-df6a-cc8f-8228-b4ae63858298@simark.ca \
--to=simark@simark.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kamil@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).