From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8A8193858401 for ; Wed, 12 Oct 2022 17:02:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A8193858401 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29CGiiGd022816 for ; Wed, 12 Oct 2022 17:02:04 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k61c88k3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Oct 2022 17:01:58 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29CGjXTj025124 for ; Wed, 12 Oct 2022 17:01:58 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k61c88k3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Oct 2022 17:01:58 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29CGpML6028961; Wed, 12 Oct 2022 17:01:57 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma02wdc.us.ibm.com with ESMTP id 3k30uaajvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Oct 2022 17:01:57 +0000 Received: from smtpav05.wdc07v.mail.ibm.com ([9.208.128.117]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29CH1u5d6423180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Oct 2022 17:01:57 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B882458053; Wed, 12 Oct 2022 17:01:56 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14F3C5805D; Wed, 12 Oct 2022 17:01:56 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.71.228]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 12 Oct 2022 17:01:55 +0000 (GMT) Message-ID: <1967a540449e5f91a8735e77a82a8b2714a49db4.camel@us.ibm.com> From: Carl Love To: Kevin Buettner , "gdb-patches@sourceware.org" Cc: Ulrich Weigand , Will Schmidt , cel@us.ibm.com Date: Wed, 12 Oct 2022 10:01:55 -0700 In-Reply-To: <20221007213651.7519c80b@f35-zws-1> References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <191f5826b228a7614c084c9704b086851d418c78.camel@us.ibm.com> <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> <1d55efe113cdcf96b812055ee45196a554c4ca78.camel@us.ibm.com> <20221007213651.7519c80b@f35-zws-1> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: m9eAXSAi_E9hgnEo9Z4PzxhAhMtMeXiE X-Proofpoint-GUID: D1PJrVD5cZz1xEYPJ30wKj3dcETC2SSV Subject: RE: [PATCH 2/2] PowerPC, fix support for printing the function return value for non-trivial values. X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-12_07,2022-10-12_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=855 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210120108 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2022 17:02:14 -0000 Kevin: On Fri, 2022-10-07 at 21:36 -0700, Kevin Buettner wrote: > Hi Carl, > > I'm still working through the patch, but I noticed what I believe > to be incorrect terminology while reading the intro / commit log... > > On Thu, 06 Oct 2022 09:37:40 -0700 > Carl Love via Gdb-patches wrote: > > ... > > This patch adds a new gdb ABI to allow PowerPC to access the value > > of r3 > > on entry to a function. The new gdb ABI attempts to use the > > DW_OP_entry > ... > > Rather than saying "gdb ABI", I think you meant to say "gdbarch > method". > > Also, I'd say something like "On PowerPC, the new gdbarch method > attempts > to use DW_OP_entry...". (I.e., this new method doesn't attempt to > access r3 > on all architectures.) Thanks for the feedback on the terminology. I was wondering if you had finished working thru the patch? Do you have any additional thoughts on the patch, particularly on the functional part of the patch before I post an updated version of the patch. Thanks for looking at the patch. Carl Love