From: Luis Machado <luis.machado@linaro.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Find tailcall frames before inline frames
Date: Mon, 9 Mar 2020 14:55:09 -0300 [thread overview]
Message-ID: <19708130-1937-2e7f-0beb-7fdcc481b3aa@linaro.org> (raw)
In-Reply-To: <665eda59-ae52-42f4-b3b2-e3a070036ca8@linaro.org>
On 3/5/20 7:21 AM, Luis Machado wrote:
> Hi Tom,
>
> On 3/3/20 6:45 PM, Tom Tromey wrote:
>> Tom> gdb/ChangeLog
>> Tom> 2020-02-20 Tom Tromey <tromey@adacore.com>
>>
>> Tom> * dwarf2/frame.c (struct dwarf2_frame_cache)
>> Tom> <checked_tailcall_bottom, entry_cfa_sp_offset,
>> Tom> entry_cfa_sp_offset_p> : Remove members.
>> Tom> (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
>> Tom> (dwarf2_frame_prev_register): Don't call
>> Tom> dwarf2_tailcall_sniffer_first.
>> Tom> (dwarf2_append_unwinders): Don't append tailcall unwinder.
>> Tom> * frame-unwind.c (add_unwinder): New fuction.
>> Tom> (frame_unwind_init): Use it. Add tailcall unwinder.
>>
>> I'm going to check this in now.
>>
>> Tom
>>
>
> This has caused quite a few failures in the following tests for
> aarch64-linux:
>
> gdb.opt/inline-break.exp
> gdb.opt/inline-cmds.exp
> gdb.python/py-frame-inline.exp
> gdb.reverse/insn-reverse.exp
>
> I see the following:
>
> info frame^M
> ../../../repos/binutils-gdb/gdb/frame.c:579: internal-error: frame_id
> get_frame_id(frame_info*): Assertion `fi->level == 0' failed.^M
> A problem internal to GDB has been detected,^M
> further debugging may prove unreliable.^M
> Quit this debugging session? (y or n) FAIL:
> gdb.python/py-frame-inline.exp: info frame (GDB internal error)
> Resyncing due to internal error.
> n^M
> ^M
> This is a bug, please report it. For instructions, see:^M
> <http://www.gnu.org/software/gdb/bugs/>.^M
>
>
> (gdb) up^M
> ../../../repos/binutils-gdb/gdb/inline-frame.c:172: internal-error: void
> inline_frame_this_id(frame_info*, void**, frame_id*): Assertion
> `frame_id_p (*this_id)' failed.^M
> A problem internal to GDB has been detected,^M
> further debugging may prove unreliable.^M
> Quit this debugging session? (y or n) FAIL:
> gdb.python/py-frame-inline.exp: up (GDB internal error)
> Resyncing due to internal error.
> n^M
> ^M
> This is a bug, please report it. For instructions, see:^M
> <http://www.gnu.org/software/gdb/bugs/>.^M
>
>
> I can help get more information on it if you need.
Reported as https://sourceware.org/bugzilla/show_bug.cgi?id=25649 so we
can track it.
next prev parent reply other threads:[~2020-03-09 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:58 Tom Tromey
2020-03-03 21:45 ` Tom Tromey
2020-03-05 10:21 ` Luis Machado
2020-03-05 16:56 ` Tom Tromey
2020-03-09 17:55 ` Luis Machado [this message]
2020-03-12 21:34 ` Tom Tromey
2020-03-13 13:31 ` Luis Machado
2020-03-24 21:24 ` Luis Machado
2020-03-26 1:59 ` Tom Tromey
2020-03-26 2:47 ` Luis Machado
2020-06-18 18:25 ` Andrew Burgess
2020-06-18 21:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19708130-1937-2e7f-0beb-7fdcc481b3aa@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).