From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11726 invoked by alias); 20 Aug 2014 09:24:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11716 invoked by uid 89); 20 Aug 2014 09:24:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 09:24:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6E95B33FE13; Wed, 20 Aug 2014 09:24:06 +0000 (UTC) From: Mike Frysinger To: Nicholas Clifton Cc: gdb-patches@sourceware.org Subject: Re: MSP430 SIM: Add support for hardware multiply Date: Wed, 20 Aug 2014 09:24:00 -0000 Message-ID: <1989214.OngbQW6OOB@vapier> User-Agent: KMail/4.13.3 (Linux/3.14.2; KDE/4.13.3; x86_64; ; ) In-Reply-To: <53F328B4.5040502@redhat.com> References: <87zjislnam.fsf@redhat.com> <5804568.hLA7fg3VQR@vapier> <53F328B4.5040502@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1469840.H6vlEnqXq2"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00386.txt.bz2 --nextPart1469840.H6vlEnqXq2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Content-length: 584 On Tue 19 Aug 2014 11:36:36 Nicholas Clifton wrote: > > the global static vars really look like they should be part of the cpu = or > > sim state and not just global variables. otherwise you can't easily > > reset them ? > > Done: > sim/msp430/ChangeLog >=20 > 2014-08-19 Nick Clifton >=20 > * msp430-sim.c: Move static hardware multiply support variables > from here... > * msp430-sim.h (msp430_cpu_state): ... into here ... > * msp430-sim.c (get_op, put_op): ... and update references to use > the msp430_cpu_state structure. looks sane. thanks! -mike= --nextPart1469840.H6vlEnqXq2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABAgAGBQJT9Gk2AAoJEEFjO5/oN/WBlroQAIu1eLU8viZVyor35Cajfoam JtCz2/DiGFrkByyScZtwqr2hfag6rQ+YiMNgSN3tvlAponEoa3ixaNj9NLyVfabH VeyVx6mlw5d2aRwF+ut/4ToNUmPD8vYxXwQsFAB2d6TP2ZwCPiEqipwkDB2qxXL4 2G0l7eA2DTSFHg3wUU/oEz0wA+5M4WywMvcoVI7jwaT1ylsaVzOiJplaQVGjxAQH v01Dc16Wotywz2eR95DhF1VuHOBejRvgkE+84DC+WSHM4vn2G6vNdCCWM70/dBMs ldteJCnXpedavVMUntcMsjnAc8IOKQ5EXiabp8VTu7g8z/SeKfubGjw6M2A+2/Eo JAp1aXXpiWj8bRrlK+GAugsFqMn6+RFlsFMSVLKCwov4fynDrc+2k+9NLySnIndS Un2c9Ab744rVzhiEYiMWCmv7CIZj8itc4zfbP68Os6q4F0woUhAUCa7F0QVNmP1q BJ7vrwjIzb7Q5jGwCvrsKfNb3zxO6k0B2pM2bW55RL7sjUnXolPcGQ9hElcJ0uoW FFGAUsxN4zbEZ2f3hWYOhFO9tAHT8UQ7zr0GcrDsIkrSQAY0Ya8DVuEAfrtFu8vH kW2HxaGZl4Tw5C4C4TYFASzi6ZdmkQ0Om1SuyQS7yVyBw9vvvvUAN5nPH44pu3iX yU2DXcQG/y3pBeurzXgl =wyNL -----END PGP SIGNATURE----- --nextPart1469840.H6vlEnqXq2--