From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87402 invoked by alias); 4 Jun 2018 14:36:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87390 invoked by uid 89); 4 Jun 2018 14:36:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 14:36:45 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD07540201A5; Mon, 4 Jun 2018 14:36:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69F9363F59; Mon, 4 Jun 2018 14:36:43 +0000 (UTC) Subject: Re: [PATCH] Add configure.nat as a dependency of config.status To: Simon Marchi , gdb-patches@sourceware.org References: <1528122903-16122-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <19b3ed7b-172c-4763-8ebb-4faa26c224fa@redhat.com> Date: Mon, 04 Jun 2018 14:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528122903-16122-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00067.txt.bz2 On 06/04/2018 03:35 PM, Simon Marchi wrote: > After pulling Alan's change that added aarch64-sve-linux-ptrace.o to > configure.nat, I got an undefined reference to aarch64_sve_get_vq when > doing a "make clean && make". It turns out that re-running configure > (./config.status --recheck) was needed to re-generate the Makefile with > aarch64-sve-linux-ptrace.o included in the object list. Putting > configure.nat in the dependencies of config.status would make sure that > when we modify configure.nat, the configure script is re-ran. I think > it also makes sense because configure.tgt and configure.host are also > there. > > gdb/ChangeLog: > > * Makefile.in (config.status): Add configure.nat as a > dependency. Makes sense. Thanks, Pedro Alves