From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 54E1E3858C3A
 for <gdb-patches@sourceware.org>; Thu,  9 Dec 2021 19:06:36 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54E1E3858C3A
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B9J6UpW031599
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Thu, 9 Dec 2021 14:06:35 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B9J6UpW031599
Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id A5C911EDEE;
 Thu,  9 Dec 2021 14:06:30 -0500 (EST)
Subject: Re: [PATCH 1/2] gdb/csky-tdep.c: fix -Wunused-but-set-variable error
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
References: <20211203213128.1426208-1-simon.marchi@polymtl.ca>
 <871r2l1vzq.fsf@tromey.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <19eacfae-7ea0-b9f3-919c-2146706a50a3@polymtl.ca>
Date: Thu, 9 Dec 2021 14:06:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <871r2l1vzq.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 9 Dec 2021 19:06:30 +0000
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2021 19:06:38 -0000

On 2021-12-09 1:19 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Fix these, seen when building with clang 14:
> Simon>       CXX    csky-tdep.o
> Simon>     /home/simark/src/binutils-gdb/gdb/csky-tdep.c:332:7: error: variable 'need_dummy_stack' set but not used [-Werror,-Wunused-but-set-variable]
> Simon>       int need_dummy_stack = 0;
> Simon>           ^
> Simon>     /home/simark/src/binutils-gdb/gdb/csky-tdep.c:805:12: error: variable 'offset' set but not used [-Werror,-Wunused-but-set-variable]
> Simon>                   int offset = 0;
> Simon>                       ^
> 
> FWIW I think both of these are fine.
> 
> Tom
> 

Pushed both, thanks.

Simon