From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id A1717385B835 for ; Sun, 29 Mar 2020 20:37:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A1717385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585514190; bh=0LPRSBDqc0fBGzycq7b5YDMm5zHAUyibm5L/bMqgcnY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hmi8XtOCWO9p6+XoowJr5Wx9UJmQoB+4lp7nnIQSeOtEoxnx7uxQsEAEIHps63+Ty Tq0dX+PIzL5EgUMfvvMG5wly3ZvGx/1nKY5bqTGAFAHjqwecgaHi1BboYk8V80rIK2 ZER4pmVeY3bTVvatm7mo2CDoTTXUXuMAOBAtH52M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MgNct-1iraaH0BEF-00hsqx; Sun, 29 Mar 2020 22:36:30 +0200 Subject: Re: [PATCH v3] Add support for "info auxv" on NetBSD To: John Baldwin , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200316181710.7542-1-n54@gmx.com> <20200320172739.26705-1-n54@gmx.com> <0e8e2d3c-aaa7-7a1f-6685-cf15753e8bca@gmx.com> <39c2ef17-89b2-7c7e-e806-0085de678c5b@FreeBSD.org> <09e82a84-db6d-3fed-cf4e-67208cb14ff3@gmx.com> <5047afd8-487b-5084-b3ea-1f95e75bca0d@FreeBSD.org> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <1a0ad6f8-238c-bf9d-6c7c-1847f0df45e0@gmx.com> Date: Sun, 29 Mar 2020 22:35:23 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <5047afd8-487b-5084-b3ea-1f95e75bca0d@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:quUGSfVYe3fho4Fgttv/HFMkKhXL+5HtZgPQImN65vIjr0K0Qyq coygNYJdyBM1D8r6xTMD+MLGPIejALSYT7thHhq7P1RaRdEPXXFtNJ8BUbmwAvqqwh9nHuX ROjnZdgxJcm4ssojyz2JlGcI/Tkt++jffcdxkHOrbUeEaVuzdC7+uvHw1Wlgqtq2p5JcpQx M2aXhmx90x9DDElBJgI8Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:nIkhXrNczfw=:IDzfnoPUS/3q6jT4mVdcXH 855Lo3DNpILECvorpqDvEewHvNVM0hSc9WePU9qz52PY1GMBqTqAj4zmvP4wF/RzZTbATr9rT ervHIpKLf0mecHl2BT8eLkCOd7kYAsno1XYl9Nmywrm5jyBTURb/ztjfqA38dvN42pUuGi1ow 6QXtcuOgd7+5JZ2d0t/DgqtuUd4XCN2poBN6UiS3H7Rf+nWLoc9l/z6WYdvUNVHSDdoHgqr6e AMu7VIrHJ+TASR5uLojs8RPsX1Lv2whzoyZ3XL49Q90vKayVO0toJpDC5dDV6ZfQUUBvBkg8+ uXD+8UvBIN9rgxx7+HembwMjSCI/bv6KQQAT3GDcXpo5L5hgfidjp1vpIkNbwi6ScKZNukHoX TAPnCnAAsjGtRUYySYvKtk9R7gbNrDrrkwTMh/cr/wA0nKhm0mGA4zWFES0nt67eXfVp2SVhm ChJjJYx3MCblFC+Whn+N/sCNGtEU8PpS/iWfpbMZYZx9sPFPevbhcHudaWr2TlumsqM/DVWhd 62YoxX+w4ntsHuhSEmeY1F15wELpZ6V3HYb852/kXjE0CDTfdRqI1cu/UMzC1nE7IJtk5aepP VjhSA+oczlpJp/XM70WpMHpHLw3FDbNrZmNII/Qfxo4Yth3KjKyuAMNDNXazhPaNZGJyUSkAl cjqp8B1YAJEbKxop1XCDsRHFBLPPRYAUD6U8wfiFRs2M66oM5Zh32ZihuwV9nYlwEJRq82b/O T+xRPiA9+TcTQYNX3fw1Sms8fF5vP2vp0kFr5EcfsXPMomr+xgxFEwXgPWjUc2MMeDgLwP8iz ohFcUcRTi5QK5rBB5XPX2VNZFIJ7SXfEAp5dTGgHObxRFUz/KvAMCy3yll0QQ9cophC3ni1UV hPTizZFOns+uUGmoHQ0at/R3Ys5ppUZ+7VaqvZN5MNhEDbXjSX+23U9/y50ql4suymbAQGKyv 5H7Arsxkydtim4+Kuy1xFPHzx0YSRnusnbtcUUmZXaS5rd6z7rRU5VYsbtB5Qjy32JhVh96CZ JckWzw2666gVGvzgD1TCpqypIXcSqnbd3IkUxCAZZL+StkKQb+t1BlOxJnHK7XfddpxbqllSQ hI7GO0EAyrXvy7NSFMx3WVfFeHYCNY7m3w/GqSTegB7zL37y5SuajmIAj+BcZIDuiDNtO/lIy JiB3TlVNaXiptFPyJl12w7a/5jlE7Zv7RM2eV/0Fof7L18EjQW5uiPAiz+IlnK8uHV75Q= X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 20:37:10 -0000 On 27.03.2020 20:22, John Baldwin wrote: > On 3/27/20 10:04 AM, Kamil Rytarowski wrote: >> On 27.03.2020 17:31, John Baldwin wrote: >>> On 3/26/20 4:26 PM, Kamil Rytarowski wrote: >>>> Ping? >>>> >>>> On 20.03.2020 18:27, Kamil Rytarowski wrote: >>>>> Register nbsd_auxv_parse() that overloads the default (Linux-style) >>>>> AUXV parsing. On NetBSD the type parameter is defined as int32_t >>>>> for all architectures. >>> >>> I would tone down some of the rhetoric. FreeBSD uses the default AUXV >>> parsing, and I think Solaris does as well, so describing it as Linux-o= nly >>> isn't very accurate. >>> >> >> It is phrases as Linux-style, not Linux-only. > > I would still perhaps drop the paranthetical part as it reads that way > I think even with -style vs -only. > >>> (Similarly, I think the earlier reviews I saw around ptrace() claimed = that >>> NetBSD was the only OS to use LWPs with ptrace() in the log messages i= n >>> effect which isn't really true as both Solaris and FreeBSD use LWPs >>> happily with ptrace(), just using a different convention.) >>> >> >> The pair of (PID+LWP) for getters and setters of registers (among >> certain other ptrace operations) is NetBSD style ptrace(2) API design. >> This leads to the point that NetBSD is currently the only OS where >> get_ptrace_pid() is not compatible (at leat in the current form). > > It might be a bit of how it was said, the actual text: > > > Unlike most other Operating Systems, NetBSD tracks both pid and lwp. > The process id on NetBSD is stored always in the pid field of ptid. > > > If by "track" you mean "the kernel keeps track of LWPs as distinct > from processes" (which is how I read "track"), then I think it is > inaccurate. > > >>> I would also tone this down a bit, and at least reference the correct >>> specification. The ELF spec doesn't define the layout of auxv_t. The >>> per-architecture psABI documents do. Also, just saying that you follo= w >>> the spec doesn't help. I would suggest something like: >>> >>> /* NetBSD-specific parser for AUXV entries. NetBSD always uses an int >>> to store the type as defined in the SVR4 psABI specifications rathe= r >>> than long as assumed by the default parser. */ >>> >> >> This is toned down compared to obsd-tdet.c, that says: >> >> /* Unlike Linux, OpenBSD actually follows the ELF standard. */ > > That may be, but that probably isn't who I would choose as a model to > follow. > >> OK, is this patch fine after rephrasing the above texts? > > It looks fine to me, but it probably needs an approver such as Tom to ok= it. > (I can approve FreeBSD-related things, but not really other bits.) > OK. I will rephrase the texts as I understand that the wording is sensitiv= e.