From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0992238FD9AE for ; Thu, 6 Jun 2024 13:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0992238FD9AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0992238FD9AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717681541; cv=none; b=w8sfDUAbcezKC/5p+5fLFz2de93AyHuEW+xHxVqAbE+dJbYcHEb7Sg6afa9QdTVa1wSE4CtbJoc+IMZAKY+9ZcunsHzeLI0Mugt9A9x/Ec4aaugOxJ2BZ/KWR6KDou9VtyDSTH5sPOJqwbJpL2Gy1AdSfXX7DzlXsWl6qLV4jTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717681541; c=relaxed/simple; bh=PHG6aC9Kjg12ReFgsWNvKemauPA4VcGtI5AjG6knZtw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DaIu5AbD8jI8qVlcLkx3TvlyZHS7Ly+k6Vvad22baMJy06QcJf3eHYlFDAZfLo2RujB3WV248c5JY6/mM3/PWqncky1zNsgF0iio8pxD80whJoQlhRAs+nRimFx03L7N/LkpkdS6oJNkzqj/I/kZqJNwg4IScYkdSLttptoBWJs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717681539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZW1riOW0/aqyzp4GWbeSwey9QWEkknS2vMHeeehPmo=; b=Yncz+vW4hjCRPMMEJlW5std3w1yWYigPgZPGvjEwJEXJvA1FfL67bnuLU1K1YAQC75moqe gr+ju97UtGLsi+noAh/8THsEMZR1paaD0eHpWLlNm8d7ZOCKjDtr7qRp0YbLY6I7Lkp/lQ cScIoB3DeYdMPtDCNbqzHxB9l/Snrr0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-mYSfU5lpMIKcdbNVewTuUA-1; Thu, 06 Jun 2024 09:45:38 -0400 X-MC-Unique: mYSfU5lpMIKcdbNVewTuUA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6ae4a53a6fbso9867796d6.2 for ; Thu, 06 Jun 2024 06:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717681537; x=1718286337; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZW1riOW0/aqyzp4GWbeSwey9QWEkknS2vMHeeehPmo=; b=vJCocl/ikwM3nEsyNrEOdbPgHhIB/Qe+kerRXdajy0M81sHlAXix0LZ2Y0KDniKBMx HjYWsh9Wy3P08VMWaJXDk2h0bA9QMG5c0Cekc3SYd5PckIUTT1iYZSw+167aBFVvJylg 7iapgo/MneW+PTQXAwmjEPuh4U8fEEFY6s3LCci3RvIUpbb2z/03vvFxycFjPznoq3ug JuSAtxbOgesAfFJOPVZYMuluUePZ18D47zpvpHKGL+oYMUBCyyfHmx97uc31hO5avp5y xPt+ywBiyzPUj54S4NtWd9NX05Vfy5TIcjDWRMiC88g/vjkSSTULLhMxWHu48+8NIa68 Nn7w== X-Forwarded-Encrypted: i=1; AJvYcCWXg9SX+P7R5Fg3AJAvxJt89A+gfelDoP5nBL+EGlJ2xkbmyhwoeZTC4e15bi09TQ+BiRgqWYNWYCREjqJazR+at7/2P7VTW9WcEw== X-Gm-Message-State: AOJu0YwvtWsgQ52JT37w+s/X57JBjfMR2MQx+cPLg11rxWx0HlW72Rfy qkIRKtrbfbXPPJv2mTn8CnO4x7HLk5BBzc+7oWSFti3MRwyu/7dSEdiT80+ZPlJQJ/tV6dXbs8e v2FNv9hHOmfSyZATuTac+A315Du28U1/FHdWG0wAiHc6ZVQ7eT2SwfeSyMCG4V5uWW+o= X-Received: by 2002:a05:6214:3b89:b0:6af:5262:7651 with SMTP id 6a1803df08f44-6b02bf95488mr54614976d6.34.1717681537251; Thu, 06 Jun 2024 06:45:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErXhBdowNonA/VZa5+a9Yz0nW3F8ti4pV/B76UKhoeT+RHK0c8pF8xbfLJLR7J7A3kaj6Mfw== X-Received: by 2002:a05:6214:3b89:b0:6af:5262:7651 with SMTP id 6a1803df08f44-6b02bf95488mr54614706d6.34.1717681536732; Thu, 06 Jun 2024 06:45:36 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f9d1d42sm6266286d6.110.2024.06.06.06.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 06:45:36 -0700 (PDT) Message-ID: <1a3f7ddf-3593-4df6-b7f5-bc332801856f@redhat.com> Date: Thu, 6 Jun 2024 10:45:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH 0/3] Small step in supporting AVX instructions To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: <20240521202800.2865871-1-blarsen@redhat.com> <4352e37e-f194-4fe5-83fa-f1fafc598afb@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/6/24 10:36, Willgerodt, Felix wrote: >>> What I did is run some testing on your patches. I found this failure on two >> nodes >>> (Fedora 39 and Ubuntu 22.04, just using gcc and unix.exp and parallel >> testing): >>> (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main >>> continue^M >>> Continuing.^M >>> Process record does not support VEX instruction 0x78 at address >> 0x7ffff7e53315.^M >>> Process record: inferior program stopped.^M >>> ^M >>> Program stopped.^M >>> 0x00007ffff7e53315 in __memset_avx2_unaligned_erms () from >> /lib64/libc.so.6^M >>> (gdb) FAIL: gdb.reverse/step-precsave.exp: run to end of main >>> >>> >>> Though I didn't see this when I ran it manually on a different Ubuntu 22.04 >> node. >>> There I saw this: >>> >>> (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main >>> continue^M >>> Continuing.^M >>> Process record does not support instruction bound.^M >>> Process record does not support instruction 0x62 at address >> 0x7ffff7f289c7.^M >>> Process record: failed to record execution log.^M >>> ^M >>> Program stopped.^M >>> 0x00007ffff7f289c7 in __memset_evex_unaligned_erms () at >> ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:182^M >>> warning: 182 ../sysdeps/x86_64/multiarch/memset-vec-unaligned- >> erms.S: No such file or directory^M >>> (gdb) KFAIL: gdb.reverse/step-precsave.exp: run to end of main (PRMS: >> record/30807) >>> I didn't have the time to investigate further. Not sure if the error messages >> tell you enough. >> >> Yeah, that's enough to give me a sense of what's up. These are the >> motivators for this series (though the second one is further in the >> future). GDB doesn't know how to disassemble AVX, AVX2 and AVX512 >> instructions, which is what leads to "process record does not support >> (...)". >> >> The KFAIL (second error) is with regard to AVX-512, identified by the >> prefix 0x62. The first one used to have a KFAIL too, but I changed the >> output message so now it just shows up as FAIL (used to point to >> https://sourceware.org/bugzilla/show_bug.cgi?id=23188). I will update >> the step-precsave regexp to identify the current issue and emit a KFAIL >> again. >> >>> I can help if you want to know more about the CPUs or libraries. >>> Note that the two machines where it failed, it didn't fail for master. >> I don't understand how it could have passed on the same machines. I'm >> more curious about the output when it did pass, if you still have it. >> Did it use a different path for memset? >> > I think the PATH difference is just a Fedora/Ubuntu difference. > I copied the Fedora 39 one above for the FAIL case. > And I think I might have confused you with "it didn't fail for master." > Sorry if that was the case. I meant that it KFAIL'ed on master. > I didn't mean to say it produced a PASS. Oh ok, yes I was confused by it not failing on master. I will fix the precsave test case and do another pass on the gdb.reverse subdirectory to see if there are any other tests I missed. Thanks for checking! -- Cheers, Guinevere Larsen She/Her/Hers > > This is Fedora 39 with our master: > > (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main > continue^M > Continuing.^M > Process record does not support instruction 0xc5 at address 0x7ffff7e53304.^M > Process record: failed to record execution log.^M > ^M > Program stopped.^M > 0x00007ffff7e53304 in __memset_avx2_unaligned_erms () from /lib64/libc.so.6^M > (gdb) KFAIL: gdb.reverse/step-precsave.exp: run to end of main (PRMS: record/23188) > > So 3 different hex values seem to be the difference. > > > For completeness sake, here is the failing Ubuntu 22.04 log (your patches): > > (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main > continue^M > Continuing.^M > Process record does not support VEX instruction 0x78 at address 0x7ffff7f25f8b.^M > Process record: inferior program stopped.^M > ^M > Program stopped.^M > 0x00007ffff7f25f8b in __memset_avx2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:182^M > warning: 182 ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S: No such file or directory^M > (gdb) FAIL: gdb.reverse/step-precsave.exp: run to end of main > > Regards, > Felix > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928