From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 14D8D385840A for ; Fri, 22 Oct 2021 11:18:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14D8D385840A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 19MBIaId008767 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 07:18:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 19MBIaId008767 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4815B1ECEB; Fri, 22 Oct 2021 07:18:36 -0400 (EDT) Message-ID: <1a7d0fcd-5fe0-8f9d-c722-31d56325a913@polymtl.ca> Date: Fri, 22 Oct 2021 07:18:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCHv3 3/3] gdb/python: add gdb.RemoteTargetConnection.send_packet Content-Language: en-US To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <0c46d41dc2e463269e84e6ac389e2a7f9a42d2cd.1634638441.git.andrew.burgess@embecosm.com> <68b53235-469c-e791-1eb2-d51cc5fc798f@polymtl.ca> <20211022110825.GB19507@embecosm.com> From: Simon Marchi In-Reply-To: <20211022110825.GB19507@embecosm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 22 Oct 2021 11:18:36 +0000 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 11:18:44 -0000 On 2021-10-22 07:08, Andrew Burgess wrote:> This is what I originally wanted to do. The problem is that this > requires that the remote_target type be visible inside > py-connection.c, and currently remote_target is defined in remote.c. > > We could move the declaration of remote_target, but in the end I > figured that the string comparison was just as good, and I didn't see > the names changing - and even if they did, we can fix py-connections.c > with the new names, and this wouldn't break the external API. Well, you could add a: bool is_remote_target (process_stratum_target *target); function implemented in remote.c. Simon