From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15396 invoked by alias); 21 Jan 2020 04:21:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15382 invoked by uid 89); 21 Jan 2020 04:21:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Heres, Here's X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2020 04:21:00 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2BE121E5F3; Mon, 20 Jan 2020 23:20:59 -0500 (EST) Subject: Re: [PATCH] Move gdbserver to top level To: Tom Tromey , gdb-patches@sourceware.org References: <87d0bf45up.fsf@tromey.com> From: Simon Marchi Message-ID: <1a97e456-8dc8-48bb-20d0-ce8b746c8066@simark.ca> Date: Tue, 21 Jan 2020 05:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <87d0bf45up.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00622.txt.bz2 On 2020-01-19 2:13 p.m., Tom Tromey wrote: > Here's the next patch in the ongoing effort to move gdbserver to the top > level. > > I've edited this patch before sending to ensure it won't be too large to > be accepted by the list. In particular, I used "git show" to create the > patch (this seems to handle moves better than "git send-email"), and I > removed the generated files. Top-level configure.ac says that configs: - or1k*-*-linux* - score-*-* should build gdbserver, but I don't think they have a gdbserver port (despite them having build_gdbserver=yes prior to this patch), do they? When autoconf-ing gdbserver, I get: gdbserver$ autoconf /usr/bin/m4:acinclude.m4:20: cannot open `../../config/lib-ld.m4': No such file or directory /usr/bin/m4:acinclude.m4:21: cannot open `../../config/lib-prefix.m4': No such file or directory /usr/bin/m4:acinclude.m4:22: cannot open `../../config/lib-link.m4': No such file or directory autom4te: /usr/bin/m4 failed with exit status: 1 I presume these paths need to be updated? Other than that it LGTM. I fixed the paths above, re-generated everything, and I was able to build fine. Simon