From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simon.marchi@efficios.com>,
will schmidt <will_schmidt@vnet.ibm.com>,
Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org, John Baldwin <jhb@FreeBSD.org>
Subject: Re: [PATCH] gdb: fix gdbarch_tdep ODR violation
Date: Mon, 15 Nov 2021 20:19:14 -0300 [thread overview]
Message-ID: <1af2a07d-43ee-20ff-4a6c-0d422503c2e0@linaro.org> (raw)
In-Reply-To: <3eb3037d-2d40-d156-a8df-1c0447a9efaf@efficios.com>
On 11/15/21 5:43 PM, Simon Marchi wrote:
> On 2021-11-15 3:42 p.m., will schmidt wrote:
>> On Mon, 2021-11-15 at 11:29 -0500, Simon Marchi wrote:
>>> On 2021-11-15 5:45 a.m., Luis Machado via Gdb-patches wrote:
>>>> LGTM
>>>
>>> Thanks to you and John for taking a look, I pushed the patch.
>>>
>>> Simon
>>>
>>
>> Hi,
>>
>> I'm now seeing a build failure on powerpc. (specifically ppc64le, but
>> i'm not sure it will matter which powerpc variant).
>>
>> First failure is
>>
>> ...
>> CXX ppc-linux-nat.o
>> ppc-linux-nat.c: In function ‘int ppc_register_u_addr(gdbarch*, int)’:
>> ppc-linux-nat.c:658:22: error: ‘struct gdbarch_tdep’ has no member
>> named ‘ppc_gp0_regnum’
>> 658 | if (regno >= tdep->ppc_gp0_regnum
>> ...
>>
>>
>> Assorted other no-such-member errors follow.
>>
>>
>>
>> Thanks,
>> -Will
>>
>
> Yeah, I kind of forgot to look for uses of gdbarch_tdep in native files,
> which are not built by default on x86-64 :(. I'm working on a patch to
> fix all of them.
Yeah. I do see some breakage for native arm/aarch64 as well. Do you
think it might be easier to revert then re-validate the new patch. I
suppose some targets are tricky to build native files for.
next prev parent reply other threads:[~2021-11-15 23:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 20:42 Simon Marchi
2021-11-12 21:55 ` John Baldwin
2021-11-15 10:45 ` Luis Machado
2021-11-15 16:29 ` Simon Marchi
2021-11-15 20:42 ` will schmidt
2021-11-15 20:43 ` Simon Marchi
2021-11-15 23:19 ` Luis Machado [this message]
2021-11-16 2:02 ` Simon Marchi
2021-11-15 16:47 ` Pedro Alves
2021-11-15 16:53 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af2a07d-43ee-20ff-4a6c-0d422503c2e0@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).