From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32892 invoked by alias); 19 Oct 2017 14:27:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32830 invoked by uid 89); 19 Oct 2017 14:27:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:06ca X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 14:27:46 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 156634A702; Thu, 19 Oct 2017 14:27:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 156634A702 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 438F5D3C72; Thu, 19 Oct 2017 14:27:44 +0000 (UTC) Subject: Re: [PATCH] xml_fetch_content_from_file: Read in whole file in one go (Re: [pushed] Fix double-free corruption) To: John Baldwin , gdb-patches@sourceware.org References: <1508240517-15322-1-git-send-email-palves@redhat.com> <199a50c3-4f55-c40e-7dcf-47db0ef27798@redhat.com> <2811735.d9V1pPNBEL@ralph.baldwin.cx> From: Pedro Alves Message-ID: <1b144b7d-cd72-16b0-06ca-c368f53499d6@redhat.com> Date: Thu, 19 Oct 2017 14:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2811735.d9V1pPNBEL@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00617.txt.bz2 On 10/18/2017 06:43 PM, John Baldwin wrote: > On Tuesday, October 17, 2017 01:20:14 PM Pedro Alves wrote: >> Looking a bit deeper, I can't seem to find a reason this code is >> reading in chunks in the first place? Why not read it all in one >> go? Like patch below. > > Seems sensible. It's unlikely that an XML file will be stored directly > on a tape such that seek() is non-optimal. :) > :-) Thanks much for the review. I pushed this in now. -- Pedro Alves