From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124827 invoked by alias); 10 Jun 2018 21:16:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124721 invoked by uid 89); 10 Jun 2018 21:16:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 21:16:00 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5ALFZl9002581 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 10 Jun 2018 17:15:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 1E9FC1EF28; Sun, 10 Jun 2018 17:15:35 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 642CE1E059; Sun, 10 Jun 2018 17:15:34 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 10 Jun 2018 21:16:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Remove a VEC from record-full.c In-Reply-To: <87o9gi7hyp.fsf@tromey.com> References: <20180608025636.14640-1-tom@tromey.com> <87o9gi7hyp.fsf@tromey.com> Message-ID: <1b1a05c47192dd4dde60bcf3f58d229a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 10 Jun 2018 21:15:35 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00256.txt.bz2 On 2018-06-10 11:57, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> You can use one of the overloads of unordered_remove in > Simon> common/gdb_vecs.h to try to preserve the exact same behavior as > with > Simon> the VEC. > > Thanks, I didn't know about these. > > How's this? Maybe I'm missing something, but it seems like the record_full_breakpoint objects are never freed. That's not related to your patch though, so your patch LGTM. Simon