From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 9F8C43858D32 for ; Mon, 16 Oct 2023 11:27:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F8C43858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F8C43858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697455667; cv=none; b=x/ywYlmcNWJ5/OoAvTboHfsaGpmIP/b4hN0x9fwwzR/4t3uRfD0rbg60bMK4an9PV41wo3IZOVzw9+QcX7tINMwFpJP3mwOXM1pqspB/LFwXIy2beZX7617/Foos/RTObJHue+6jDGlSY9ZjqRJcVy5ANTnkFGSHf9bhiZVCcew= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697455667; c=relaxed/simple; bh=cNRz9TCsevPw6z+9+tH7GppefwU/ysdQf/8P7P7bveQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=ndv7IlbZAQP+cJuA4jNnG8ZESOygDRmEdN/kS9v2Ko4rwGI+ZN7MSrqKnwvZjPYYUXPQgrlqWJ0AdblRMJt709dVjaHMRmodIflHczE8hLoaJ+erfxhgmPbWxUCXoNLNU9OvxBP4UqMh7ZLQrAMq3wZdBFvnlLmpm45aB/9NXdk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 927641FEBA; Mon, 16 Oct 2023 11:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697455665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CctfJ3bPnm+EsmwC0yEDep6e6lTo61tOgoHv9RJ1dv0=; b=U4EbzUoTlJb/6wq3YWTILikm7Q6Mig0rxDR2rl4DM175ejvnuFL8NG2PJOioZ0elHElAMz 6AQ43aIZHy7pfawoiycyh8JFBFIBnjZjZaRH9OBjCffR0fkGqRIH+QkPRGc416lCtxD7qt hR2peYZk33IipIw7KyCIMHFxdauuuVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697455665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CctfJ3bPnm+EsmwC0yEDep6e6lTo61tOgoHv9RJ1dv0=; b=oZv4oSBvMt2AGPpaxizl5hESiwDuCj2KDAXnm6EGJQm6sJKX6F8ImBehK7CTtFH71huLb+ 1x/xv2ktsmTeNfAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E516138EF; Mon, 16 Oct 2023 11:27:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cMwfHDEeLWUpdwAAMHmgww (envelope-from ); Mon, 16 Oct 2023 11:27:45 +0000 Message-ID: <1b23092c-0899-44ea-9e0a-a1ab94482754@suse.de> Date: Mon, 16 Oct 2023 13:28:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] [gdb/cli] Allow source highlighting to be interrupted Content-Language: en-US To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20231016091748.26247-1-tdevries@suse.de> <20231016102306.e5fd3accy3br2aqd@octopus> From: Tom de Vries In-Reply-To: <20231016102306.e5fd3accy3br2aqd@octopus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 1.72 X-Spamd-Result: default: False [1.72 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.20)[71.09%]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.99)[-0.993]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(3.00)[1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/16/23 12:23, Lancelot SIX wrote: > Hi, > > I went through the series, and except for one minor formatting detail in > the last patch, it LGTM. > > Reviewed-By: Lancelot Six > Great, thanks for the reviews. I'll wait for feedback from Pedro on the ^C handling. Thanks, - Tom > Best, > Lancelot. > > On Mon, Oct 16, 2023 at 11:17:44AM +0200, Tom de Vries wrote: >> I wrote this patch series to fix PR cli/30934. >> >> The 1st patch is an unrelated optimization, which I added to this series >> because it touches the same code. >> >> The 2nd patch factors out a function. >> >> The 3rd patch adds a means to keep track of styling failures in the >> source cache, as suggested here ( >> https://sourceware.org/pipermail/gdb-patches/2023-October/203164.html ). >> >> The 4th patch fixes the PR cli/30934. >> >> Changes in v3: >> - dropped the "#if __cplusplus >= 202002L" in the first patch. >> - added a reset of the highlighter's EventListener to prevent a dangling >> pointer. >> >> Changes in v2: >> - fixed a build problem with --disable-source-highlight, reported by the linaro >> CI. >> - temporarily installs the default_quit_handler to be able to use QUIT >> - added a question whether to interrupt highlighting or not >> (in the RFC, I had a warning, in v1 I dropped it) >> - added "gdb_assert (target_terminal::is_ours ())" >> >> Adding the question was inspired by the v3 patch "gdb/debuginfod: Ctrl-C ask >> to cancel further downloads" ( >> https://sourceware.org/pipermail/gdb-patches/2023-March/197679.html ). >> >> Submission history: >> - RFC: >> https://sourceware.org/pipermail/gdb-patches/2023-October/203157.html >> - v1: >> https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html >> - v2: >> https://sourceware.org/pipermail/gdb-patches/2023-October/203199.html >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30934 >> >> Tom de Vries (4): >> [gdb/cli] Skip string copy in source_cache::ensure >> [gdb/cli] Factor out try_source_highlight >> [gdb/cli] Keep track of styling failures in source_cache >> [gdb/cli] Allow source highlighting to be interrupted >> >> gdb/source-cache.c | 175 +++++++++++++++++++++++++++++++++++---------- >> gdb/source-cache.h | 4 ++ >> 2 files changed, 143 insertions(+), 36 deletions(-) >> >> >> base-commit: 6674b23fe6409e08de9c36f640bd58127eff9dda >> -- >> 2.35.3 >>