From: Simon Marchi <simark@simark.ca>
To: Eli Zaretskii <eliz@gnu.org>, Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv6 3/3] gdb/python: add gdb.RemoteTargetConnection.send_packet
Date: Mon, 15 Nov 2021 14:38:40 -0500 [thread overview]
Message-ID: <1b23a863-cbf9-1c14-7b51-67d471269859@simark.ca> (raw)
In-Reply-To: <837dd92rcu.fsf@gnu.org>
On 2021-11-15 1:42 p.m., Eli Zaretskii via Gdb-patches wrote:
>> +This method sends @var{packet}, which should be a non-empty string or
>> +bytes array, to the remote target and returns the response. If
> ^^^^^^^^^^^
> You meant "byte array", right? Or "array of bytes", perhaps.
I didn't point it out, out of fear of being too nitpicky, but since you
mention it...
I don't think we should say array at all. We expect a `bytes object`
where `bytes` is literally the class name:
https://docs.python.org/3/library/stdtypes.html#bytes
So, "... which should be a non-empty string or bytes object", something
like that. The `bytes` could be in @code{...} to make it clear we refer
to the type name.
Simon
next prev parent reply other threads:[~2021-11-15 19:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 16:03 [PATCH 0/3] Python API for target connections, and packet sending Andrew Burgess
2021-09-11 16:03 ` [PATCH 1/3] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-09-11 16:19 ` Eli Zaretskii
2021-09-11 16:03 ` [PATCH 2/3] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-09-11 16:03 ` [PATCH 3/3] gdb/python: add TargetConnection.send_remote_packet method Andrew Burgess
2021-09-11 16:10 ` Eli Zaretskii
2021-10-18 9:45 ` [PATCHv2 0/3] Python API for target connections, and packet sending Andrew Burgess
2021-10-18 9:45 ` [PATCHv2 1/3] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-10-18 12:44 ` Eli Zaretskii
2021-10-18 15:53 ` Simon Marchi
2021-10-18 9:45 ` [PATCHv2 2/3] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-10-18 9:45 ` [PATCHv2 3/3] gdb/python: add TargetConnection.send_remote_packet method Andrew Burgess
2021-10-18 12:57 ` Eli Zaretskii
2021-10-18 15:46 ` Simon Marchi
2021-10-19 10:17 ` [PATCHv3 0/3] Python API for target connections, and packet sending Andrew Burgess
2021-10-19 10:17 ` [PATCHv3 1/3] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-10-19 12:26 ` Eli Zaretskii
2021-10-20 22:33 ` Lancelot SIX
2021-10-21 2:00 ` Simon Marchi
2021-10-19 10:17 ` [PATCHv3 2/3] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-10-21 2:23 ` Simon Marchi
2021-10-19 10:17 ` [PATCHv3 3/3] gdb/python: add gdb.RemoteTargetConnection.send_packet Andrew Burgess
2021-10-19 12:28 ` Eli Zaretskii
2021-10-21 2:43 ` Simon Marchi
2021-10-22 11:08 ` Andrew Burgess
2021-10-22 11:18 ` Simon Marchi
2021-10-22 17:11 ` Andrew Burgess
2021-10-22 10:58 ` [PATCHv4 0/4] Python API for target connections, and packet sending Andrew Burgess
2021-10-22 10:58 ` [PATCHv4 1/4] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-10-22 10:58 ` [PATCHv4 2/4] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-10-22 10:58 ` [PATCHv4 3/4] gdb/python: add gdb.RemoteTargetConnection.send_packet Andrew Burgess
2021-10-22 10:58 ` [PATCHv4 4/4] gdb: handle binary data in 'maint packet' and RemoteTargetConnection.send_packet Andrew Burgess
2021-10-22 17:10 ` [PATCHv5 0/4] Python API for target connections, and packet sending Andrew Burgess
2021-10-22 17:10 ` [PATCHv5 1/4] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-10-22 17:10 ` [PATCHv5 2/4] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-10-22 17:10 ` [PATCHv5 3/4] gdb/python: add gdb.RemoteTargetConnection.send_packet Andrew Burgess
2021-11-15 2:08 ` Simon Marchi
2021-11-15 9:25 ` Andrew Burgess
2021-11-15 13:16 ` Simon Marchi
2021-10-22 17:10 ` [PATCHv5 4/4] gdb: handle binary data in 'maint packet' and RemoteTargetConnection.send_packet Andrew Burgess
2021-11-15 2:44 ` Simon Marchi
2021-11-09 10:04 ` [PATCHv5 0/4] Python API for target connections, and packet sending Andrew Burgess
2021-11-15 17:40 ` [PATCHv6 0/3] " Andrew Burgess
2021-11-15 17:40 ` [PATCHv6 1/3] gdb/python: introduce gdb.TargetConnection object type Andrew Burgess
2021-11-15 17:40 ` [PATCHv6 2/3] gdb: make packet_command function available outside remote.c Andrew Burgess
2021-11-15 17:40 ` [PATCHv6 3/3] gdb/python: add gdb.RemoteTargetConnection.send_packet Andrew Burgess
2021-11-15 18:42 ` Eli Zaretskii
2021-11-15 19:38 ` Simon Marchi [this message]
2021-11-15 19:29 ` Simon Marchi
2021-11-16 12:48 ` Andrew Burgess
2021-11-16 15:10 ` Simon Marchi
2021-11-30 12:15 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b23a863-cbf9-1c14-7b51-67d471269859@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).