From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 9EE843857034 for ; Thu, 31 Mar 2022 19:28:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9EE843857034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id h16so440395wmd.0 for ; Thu, 31 Mar 2022 12:28:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=waKandQmj9+ZMuhv0JQ7xh2QmHwZJTDjqbScadlryzg=; b=0hEYrjgfJtt8MqJmmzje0umHyJbuD98N9AF/KfhJZ9ptOT+0wrdt18ZYOzCN8QHFq/ Gs6wOKKbIGSQRkMnLFHisNIpJT6tr9dWs7nM0a0KVIYfElDn2SZilue9Ihidt6BGTHMs +7GVWdBJt5gcVNl2gjzUwb4v95U+UYp+RC39T7wMjq1ueGfyHkMJH74pRJqs5Z7AENMR q5rKSelZ5cvLDIeD9hG58tpQfHBAU6fO5PUnkvljLOrNt1a4QyuD71z9uJEfEIzNZjkR HjM/S1Meb/0cJMkrc8IZ0sIFOXSdh3YHdask/srtNhY2kYpg/Mu4oIBirTI78X0KWETt TewA== X-Gm-Message-State: AOAM532DwKRP6MbtLIw3tEKfqE/ykMz6B5/QYhwSofK5T22UKN2+w8Gd maxSQGkL15/49StL9wBJc98= X-Google-Smtp-Source: ABdhPJyu2xsgLnU4MrK43AGCL2D09CigEVWi1lSU/UQEcTkU6BTVkFA/knlQRR+ZuLayT0YmpzYrfQ== X-Received: by 2002:a05:600c:1552:b0:38c:de92:6a2f with SMTP id f18-20020a05600c155200b0038cde926a2fmr5863145wmg.152.1648754895725; Thu, 31 Mar 2022 12:28:15 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id i206-20020a1c3bd7000000b0038bfc3ab76csm114574wma.48.2022.03.31.12.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 12:28:14 -0700 (PDT) Message-ID: <1b4f77f0-b1a5-2642-b02c-5ddeaec4d567@palves.net> Date: Thu, 31 Mar 2022 20:28:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 9/9] gdb: resume ongoing step after handling fork or vfork Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi References: <20220118040937.730282-1-simon.marchi@polymtl.ca> <20220118040937.730282-10-simon.marchi@polymtl.ca> From: Pedro Alves In-Reply-To: <20220118040937.730282-10-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 19:28:19 -0000 On 2022-01-18 04:09, Simon Marchi via Gdb-patches wrote: > From: Simon Marchi > > New in v2: > > - updated the check in handle_inferior_event from > > if (parent->inf->thread_waiting_for_vfork_done != nullptr > || !switch_back_to_stepped_thread (ecs)) > > to > > if ((!follow_child > && detach_fork > && parent->inf->thread_waiting_for_vfork_done != nullptr) > || !switch_back_to_stepped_thread (ecs)) > > The `parent` pointer is stale when not following the parent, so that > broke some follow-fork-mode=child tests. I changed this expression last > minute before sending and did not re-test :(. > OK with the nits I pointed out in v1 addressed.