From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 850E23858411 for ; Wed, 1 Sep 2021 13:53:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 850E23858411 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 181DrW1j032636 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Sep 2021 09:53:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 181DrW1j032636 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F335F1ECEB; Wed, 1 Sep 2021 09:53:31 -0400 (EDT) Subject: Re: [PATCH 1/3] gdb: make thread_info::executing private To: Andrew Burgess , gdb-patches@sourceware.org References: <0fc4a9e754ad23dad99afdbeafa1388791135408.1630353626.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <1b625bf0-9a43-801c-4a5a-a880de986106@polymtl.ca> Date: Wed, 1 Sep 2021 09:53:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <0fc4a9e754ad23dad99afdbeafa1388791135408.1630353626.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 1 Sep 2021 13:53:32 +0000 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 13:53:48 -0000 > @@ -841,24 +851,11 @@ set_running (process_stratum_target *targ, ptid_t ptid, bool running) > gdb::observers::target_resumed.notify (ptid); > } > > - > -/* Helper for set_executing. Set's the thread's 'executing' field > - from EXECUTING, and if EXECUTING is true also clears the thread's > - stop_pc. */ That comment should probably be moved to the set_executing declaration, in the thread_info class. The part about clearing stop_pc is relevant to have there, I think. Otherwise, LGTM. Simon