From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3DA0C3858423 for ; Wed, 25 Jan 2023 19:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DA0C3858423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30PJLa5K024014; Wed, 25 Jan 2023 19:39:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=jQvyCOCKrY+ZsYiHWD880D8AFFnJBUFZ/vaKnqAFJdY=; b=Zm0OtpyMTLvA0HWZdFqXJQZ2Jg/w0k7pib1NPw50V5VswHQYTY3c3eU88ss82zOpJoPl kGevIhDmUnXTEF/EKM/A9u//1BFQO1tWKF/6RHMpHc5dce4fnCl6NGpc/9aLzUxltVEy HLD0vUXx7OK3Q0XaBHmaAMi0ltAoiWix2Q07WUnt0QyzdaZKrdB8aQKjn+pnZD9rp+WH WA1Yo6c5KTNwQgMVkLv02ZUjUlbeYC5MOwskWtx4g/zPJ/7k91BvQyjdpDFhy4iXk5hl Nq5N8feJ8Wetka76j1Jfs/GCTq5gqNAdp4PedMD+CMiSYZLkUamZxRqiuGrP8V7oYFXO Jg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3na839e2t4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 19:39:03 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30PJRZC6030487; Wed, 25 Jan 2023 19:39:03 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3na839e2sq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 19:39:02 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30PHAAvE007349; Wed, 25 Jan 2023 19:39:01 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([9.208.129.116]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3n87p7hjqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 19:39:01 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30PJd07N8913432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jan 2023 19:39:00 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 317A058052; Wed, 25 Jan 2023 19:39:00 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF7E75804E; Wed, 25 Jan 2023 19:38:59 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.12.142]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 25 Jan 2023 19:38:59 +0000 (GMT) Message-ID: <1b92e14808690b952491f2b2597aa3eb16df133f.camel@us.ibm.com> From: Carl Love To: Pedro Alves , Ulrich Weigand , "gdb-patches@sourceware.org" , Bruno Larsen Cc: cel@us.ibm.com, luis.machado@arm.com Date: Wed, 25 Jan 2023 11:38:59 -0800 In-Reply-To: <2e7ed874-0d1f-6c28-010c-6dab7641ed73@palves.net> References: <3e3c9c40f07ab01c79fe10915e76ffa187c42ad9.camel@us.ibm.com> <122f5d2d3db9ef1979b0f8da927d005f32bba82c.camel@us.ibm.com> <011768e8-2b76-f8ed-1174-fbaa020b15e7@redhat.com> <58cebd1a-7883-fbc6-ac94-c67293f8fc8d@redhat.com> <5e5dc4a49aa8feb370419a1efecf277673b7dfc7.camel@us.ibm.com> <610d5f171d5f4baeb94887217e69d0e6d70e9d66.camel@us.ibm.com> <873eb58a-a6ab-08b2-0827-ca6e0c8088ae@palves.net> <8c4ebc33-f7b5-14a3-3bb0-155fe03e92d8@redhat.com> <837e302b-3ac3-67bd-5314-55194ab35421@redhat.com> <1b995d4378b1e656caffc8682b1f3d66317ab92e.camel@de.ibm.com> <2e7ed874-0d1f-6c28-010c-6dab7641ed73@palves.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3GPVC2aIFiv4mP0MMiGe5Q2no6WRsRS4 X-Proofpoint-ORIG-GUID: Wgyh-fxNcSgb38A6ZF4pg9Tvb0E84l2p Subject: RE: [PATCH 1/2 version 3] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_13,2023-01-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 mlxscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301250174 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro, Ulrich, Tom, Bruno: On Wed, 2023-01-25 at 17:24 +0000, Pedro Alves wrote: > On 2023-01-25 5:13 p.m., Ulrich Weigand wrote: > > > Breakpoint 1, func2 (i=1) at finish.c:8 > > > 8 return i + 1; > > > (gdb) step > > > 9 } > > > <<< stopped a line bounary, and stepped over the func1 > > > call as well! > > > (gdb) p $pc > > > $3 = (void (*)()) 0x55555555514d > > So this is still at the return in func2, > > Whoops, the example that I quickly typed up didn't actually have an > explicit return > line when I first tried it (it returned void), and then I thought of > adding one and I added it > I missed that I now needed one extra step to get out of func, > thinking I was at the last > line of main already. > > > but you're right, > > the next step brings us directly to func1 without stopping > > in main at all. This is indeed unlike finish. > > > > Exactly. > > > > I disagree. > > OK, you've convinced me as well. Sorry for the confusion ... > > No worries! OK, so there seems to be agreement that we do not want to move forward with this patch to change the behavior of the reverse-finish command. The consensus is the reverse-finish command is working as expected. So, I formally withdraw patch 1 of 2 from consideration. I worked on a patch with Luis, who is now busy with other things, to fix the issue of two "simple" executable statements on a line not working. The patch fixed that issue, but does not fix the example from Pedro of two function calls in the same source line. So, I will pickup this patch again and see if I can get the patch to correctly handle column debug info and the is-stmt entry stuff and not break clang. The second patch in this series address the reverse-finish command on PowerPC which does not work due to the multiple entry points used in PowerPC. I will rework the PowerPC patch to apply on mainline to address the PowerPC issues so the reverse-finish command will behave the same as on X86. This is probably the simpler/easier of the two patches to do. Thanks for all the discussion and help with this issue. Carl