From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 579743858D39 for ; Wed, 2 Mar 2022 06:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 579743858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.130.0.135] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9BxAM_KER9ifykBAA--.6048S3; Wed, 02 Mar 2022 14:42:19 +0800 (CST) Subject: Re: [PATCH v5 0/2] Modify can_spawn_for_attach To: Simon Marchi , gdb-patches@sourceware.org References: <1645584316-5375-1-git-send-email-yangtiezhu@loongson.cn> <724bfb12-1301-1763-58b2-7a166ee9b22d@loongson.cn> <52930d69-2534-6c6d-e716-e256020bc4a2@polymtl.ca> <26ffd2e4-4aab-4367-96fb-bb8330b8eff8@polymtl.ca> From: Tiezhu Yang Message-ID: <1be805f7-42a1-d8f6-e553-913ac3f1b4b2@loongson.cn> Date: Wed, 2 Mar 2022 14:42:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <26ffd2e4-4aab-4367-96fb-bb8330b8eff8@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf9BxAM_KER9ifykBAA--.6048S3 X-Coremail-Antispam: 1UD129KBjvJXoW7GFWDtFWxtryDJF47XF43ZFb_yoW8Jr4kpF WxJF4YyF4UXF12ya4ayw1rXr1ftw4ftryDWry3Aw18CFn09rn8JryFkw409Fn7Xr1rCr1a k3WxJasxur1jyaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE14v_GF1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y 6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa 7IU5NmR5UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 06:42:25 -0000 On 03/01/2022 10:12 PM, Simon Marchi wrote: > > > On 2022-02-28 09:36, Simon Marchi via Gdb-patches wrote: >> On 2022-02-28 01:59, Tiezhu Yang wrote: >>> >>> >>> On 02/23/2022 10:45 AM, Tiezhu Yang wrote: >>>> v5: >>>> -- Use "unsupported" instead of "untested" in patch #1, >>>> suggested by Simon Marchi, thank you. >>>> >>>> v4: >>>> -- Add patch #1 to print explicit test result for some test. >>>> -- Modify patch #2 suggested by Simon Marchi, thank you. >>>> >>>> Tiezhu Yang (2): >>>> gdb: testsuite: print explicit test result in can_spawn_for_attach >>>> gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp >>>> >>>> gdb/testsuite/lib/gdb.exp | 46 +++++++++++++++++++++++++++++++++++++++------- >>>> 1 file changed, 39 insertions(+), 7 deletions(-) >>>> >>> >>> Hi, >>> >>> I modified the patches as you suggested. >>> Any more comments? >>> Can I push this patchset to the master? >> >> Yeah, please go ahead, thanks. >> >> Simon > > Actually, this causes the following test failures: > > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt) > > Can you please take a look? OK, I will look into it. Thanks, Tiezhu > > Thanks, > > Simon >