From: Pedro Alves <palves@redhat.com>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v7 5/5] gdb/infrun: handle already-exited threads when attempting to stop
Date: Thu, 14 May 2020 12:32:13 +0100 [thread overview]
Message-ID: <1bf3eb3d-7ace-441f-6141-d29a227f49b3@redhat.com> (raw)
In-Reply-To: <SN6PR11MB28932743570332EBA6076734C4BC0@SN6PR11MB2893.namprd11.prod.outlook.com>
On 5/14/20 9:50 AM, Aktemur, Tankut Baris via Gdb-patches wrote:
> Thank you for checking and updating the broader impact! This revision looks
> very good to me. I had minor comments about 3 patches and I emailed them.
> I pushed the suggested changes to this branch for convenience:
>
> https://github.com/barisaktemur/gdb/commits/thread-exit-in-stop-all-threads-v9
>
> I repeated the regression testing with this branch, too.
Great, thanks for doing that! Other than the small comments I made in response
to the patches in v8, I agree with all your changes. This looks good to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-05-14 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1587563226.git.tankut.baris.aktemur@intel.com>
2020-04-22 15:00 ` [PATCH v7 3/5] gdb/remote: do not delete a thread if it has a pending exit event Tankut Baris Aktemur
2020-05-04 14:43 ` Pedro Alves
2020-05-04 15:33 ` Aktemur, Tankut Baris
2020-05-13 14:20 ` Pedro Alves
2020-04-22 15:00 ` [PATCH v7 5/5] gdb/infrun: handle already-exited threads when attempting to stop Tankut Baris Aktemur
2020-04-22 16:07 ` Aktemur, Tankut Baris
2020-05-03 15:38 ` Aktemur, Tankut Baris
2020-05-13 21:15 ` Pedro Alves
2020-05-14 8:50 ` Aktemur, Tankut Baris
2020-05-14 11:32 ` Pedro Alves [this message]
2020-05-14 11:42 ` Aktemur, Tankut Baris
2020-05-14 11:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf3eb3d-7ace-441f-6141-d29a227f49b3@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).