Re: [PATCH] [gdb/python] Throw MemoryError in inferior.read_memory if malloc fails

[Tom de Vries <tdevries@suse.de>]

On 4/15/24 18:16, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> But I couldn't come up with a good rationale as to why I should handle
> Tom> MemoryError differently from BaseException, so I decided to catch it
> Tom> locally and turn it into a DAPException.
> 
> Yeah, makes sense.
> 
> Tom> +    try:
> Tom> +        buf = gdb.selected_inferior().read_memory(addr, count)
> Tom> +    except MemoryError:
> Tom> +        raise DAPException("Out of memory")
> 
> Here I meant something like:
> 
> except MemoryError as e:
>     raise DAPException(...) from e
> 
> There's an example of this in startup.py.

I see, I didn't know that possibility.

Anyway, AFAICT it doesn't seem to make a difference, it just makes the 
chaining explicit, which I prefer.

Pushed with that change.

Thanks,
- Tom