From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 744DB38438D5 for ; Fri, 11 Nov 2022 12:37:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 744DB38438D5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7604A201A7; Fri, 11 Nov 2022 12:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668170252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGUJVT3ggYaQLdBzsZFi2t5Z1qUUq/yVYyIFme7BwJY=; b=a1ql/C4iJUtoNFYlwK5b17gVlM6Glj5kuyQ4RiLE7ir8isGljr/GgeVT6J907V216N621m FSrfKqjrShkjDtCoymB0h0Ma7W83be3yZ5qnituMRDHcLXiTsrRxhGsbd6slSf1CLO7PnT Hjr138srlNJuAI5MVjHtzGJ2ne1o9cY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668170252; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGUJVT3ggYaQLdBzsZFi2t5Z1qUUq/yVYyIFme7BwJY=; b=l+jwtewPIWotx6SWG4r6rFn+X1nKOUqeE+O5LiwMZeKn3CbrTdTlHR35v5J19je5uX2uAX zJ10bEN+VRV3Q5CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 61DA513357; Fri, 11 Nov 2022 12:37:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id H727FgxCbmMyTwAAMHmgww (envelope-from ); Fri, 11 Nov 2022 12:37:32 +0000 Message-ID: <1c02e882-c19e-483e-e50c-634fbe282988@suse.de> Date: Fri, 11 Nov 2022 13:37:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] gdb: make "start" breakpoint inferior-specific Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <691c5a58-68ae-5fe9-2f3d-34fb7af69ad0@palves.net> <20221108212008.1792090-1-simon.marchi@efficios.com> From: Tom de Vries In-Reply-To: <20221108212008.1792090-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 22:20, Simon Marchi via Gdb-patches wrote: > - std::string arg = string_printf ("-qualified %s", main_name ()); > + std::string arg = string_printf ("-qualified %s if $_inferior == %d", main_name (), > + current_inferior ()->num); Hi, it seems ada doesn't like the syntax, we get: ... (gdb) start ^M Error in expression, near `1'.^M (gdb) UNTESTED: gdb.ada/start.exp: start failed to land inside the right procedure ... Thanks, - Tom (gdb) bt #0 0x00007ffff4c3dad2 in __cxxabiv1::__cxa_throw (obj=0x2d8cef0, tinfo=0x1471210 , dest=0xb70b06 ) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:78 #1 0x000000000141eb12 in throw_it(return_reason, errors, const char *, typedef __va_list_tag __va_list_tag *) (reason=RETURN_ERROR, error=GENERIC_ERROR, fmt=0x14789a8 "Error in expression, near `%s'.", ap=0x7fffffffb258) at /home/vries/gdb_versions/devel/src/gdbsupport/common-exceptions.cc:200 #2 0x000000000141eb8e in throw_verror (error=GENERIC_ERROR, fmt=0x14789a8 "Error in expression, near `%s'.", ap=0x7fffffffb258) at /home/vries/gdb_versions/devel/src/gdbsupport/common-exceptions.cc:208 #3 0x0000000000cce1d2 in verror (string=0x14789a8 "Error in expression, near `%s'.", args=0x7fffffffb258) at /home/vries/gdb_versions/devel/src/gdb/utils.c:164 #4 0x0000000001423811 in error (fmt=0x14789a8 "Error in expression, near `%s'.") at /home/vries/gdb_versions/devel/src/gdbsupport/errors.cc:46 #5 0x000000000043b90d in ada_yyerror (msg=0x147623a "syntax error") at /home/vries/gdb_versions/devel/src/gdb/ada-exp.y:1169 #6 0x000000000043793f in ada_yyparse () at ada-exp.c.tmp:2905 #7 0x000000000043b818 in ada_parse (par_state=0x7fffffffcca0) at /home/vries/gdb_versions/devel/src/gdb/ada-exp.y:1155 #8 0x000000000047b418 in ada_language::parser (this=0x29937d0 , ps=0x7fffffffcca0) at /home/vries/gdb_versions/devel/src/gdb/ada-lang.c:13855 #9 0x00000000009bdcd2 in parse_exp_in_context (stringptr=0x7fffffffce08, pc=4202360, block=0x37c2280, comma=0, void_context_p=false, tracker=0x7fffffffcd20, completer=0x0) at /home/vries/gdb_versions/devel/src/gdb/parse.c:515 #10 0x00000000009bda5f in parse_exp_1 (stringptr=0x7fffffffce08, pc=4202360, block=0x37c2280, comma=0, tracker=0x0) at /home/vries/gdb_versions/devel/src/gdb/parse.c:428 #11 0x0000000000567921 in find_condition_and_thread (tok=0x376f439 "$_inferior == 1", pc=4202360, cond_string=0x7fffffffcec8, thread=0x7fffffffcec4, task=0x7fffffffcec0, rest=0x7fffffffceb8) at /home/vries/gdb_versions/devel/src/gdb/breakpoint.c:8649 #12 0x0000000000567c78 in find_condition_and_thread_for_sals ( sals=std::vector of length 1, capacity 1 = {...}, input=0x376f436 "if $_inferior == 1", cond_string=0x7fffffffcf78, thread=0x7fffffffcf34, task=0x7fffffffcfbc, rest=0x7fffffffcf80) at /home/vries/gdb_versions/devel/src/gdb/breakpoint.c:8728 #13 0x0000000000568389 in create_breakpoint (gdbarch=0x2d8d1e0, locspec=0x376f500, cond_string=0x0, thread=0, extra_string=0x376f436 "if $_inferior == 1", force_condition=false, parse_extra=1, tempflag=1, type_wanted=bp_breakpoint, ignore_count=0, pending_break_support=AUTO_BOOLEAN_AUTO, ops=0x14afec0 , from_tty=0, enabled=1, internal=0, flags=0) at /home/vries/gdb_versions/devel/src/gdb/breakpoint.c:8909 #14 0x0000000000568be2 in break_command_1 (arg=0x376f436 "if $_inferior == 1", flag=1, from_tty=0) at /home/vries/gdb_versions/devel/src/gdb/breakpoint.c:9027 #15 0x0000000000568eb6 in tbreak_command ( arg=0x376f420 "-qualified _ada_dummy if $_inferior == 1", from_tty=0) at /home/vries/gdb_versions/devel/src/gdb/breakpoint.c:9104 #16 0x000000000084f040 in run_command_1 (args=0x0, from_tty=0, run_how=RUN_STOP_AT_MAIN) at /home/vries/gdb_versions/devel/src/gdb/infcmd.c:433 #17 0x000000000084f555 in start_command (args=0x0, from_tty=0) at /home/vries/gdb_versions/devel/src/gdb/infcmd.c:537 #18 0x00000000005e9bd6 in do_simple_func (args=0x0, from_tty=0, c=0x2bcc0a0) at /home/vries/gdb_versions/devel/src/gdb/cli/cli-decode.c:95 #19 0x00000000005ee986 in cmd_func (cmd=0x2bcc0a0, args=0x0, from_tty=0) at /home/vries/gdb_versions/devel/src/gdb/cli/cli-decode.c:2543 #20 0x0000000000c3648f in execute_command (p=0x7fffffffe14f "", from_tty=0) at /home/vries/gdb_versions/devel/src/gdb/top.c:692 #21 0x00000000008faa55 in catch_command_errors ( command=0xc35ec2 , arg=0x7fffffffe14a "start", from_tty=0, do_bp_actions=true) at /home/vries/gdb_versions/devel/src/gdb/main.c:513 #22 0x00000000008fac2d in execute_cmdargs (cmdarg_vec=0x7fffffffd7a0, file_type=CMDARG_FILE, cmd_type=CMDARG_COMMAND, ret=0x7fffffffd77c) at /home/vries/gdb_versions/devel/src/gdb/main.c:608 #23 0x00000000008fbfbd in captured_main_1 (context=0x7fffffffd9e0) at /home/vries/gdb_versions/devel/src/gdb/main.c:1299 #24 0x00000000008fc1c0 in captured_main (data=0x7fffffffd9e0) at /home/vries/gdb_versions/devel/src/gdb/main.c:1320 #25 0x00000000008fc22b in gdb_main (args=0x7fffffffd9e0) at /home/vries/gdb_versions/devel/src/gdb/main.c:1345 #26 0x000000000041a24e in main (argc=13, argv=0x7fffffffdaf8) at /home/vries/gdb_versions/devel/src/gdb/gdb.c:32