From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Use std::max and std::min throughout
Date: Mon, 19 Sep 2016 13:44:00 -0000 [thread overview]
Message-ID: <1c195105-42bc-eb71-d35a-143325786fac@redhat.com> (raw)
In-Reply-To: <d19e8756-4748-bfe1-2f26-8c725525a0c1@redhat.com>
On 09/19/2016 02:35 PM, Pedro Alves wrote:
> # define gettext(Msgid) (Msgid)
> # define dgettext(Domainname, Msgid) (Msgid)
> # define dcgettext(Domainname, Msgid, Category) (Msgid)
> # define textdomain(Domainname) while (0) /* nothing */
> # define bindtextdomain(Domainname, Dirname) while (0) /* nothing */
> # define _(String) (String)
> # define N_(String) (String)
> #endif
Alternatively, simply remove the troublesome *gettext and *textdomain
macros, leaving only the _ and N_ ones. I can't seem to find any
directly reference to gettext in the tree. The textdomain calls
in main.c would need to be wrapped in #ifdef ENABLE_NLS, but
likes like that is all.
I don't have a strong preference either way.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-09-19 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 16:52 Pedro Alves
2016-09-15 17:47 ` Simon Marchi
2016-09-16 19:01 ` Pedro Alves
2016-09-18 23:26 ` [pushed] gdb: Fix std::{min, max}-related build breakage on 32-bit hosts Pedro Alves
2016-09-18 23:37 ` [pushed] gdb/s390: Fix build breakage due to std::min/std::max usage without header Pedro Alves
2016-09-19 11:47 ` [PATCH] gdb: Use std::max and std::min throughout Ulrich Weigand
2016-09-19 13:36 ` Pedro Alves
2016-09-19 13:44 ` Pedro Alves [this message]
2016-09-19 14:02 ` Pedro Alves
2016-09-19 14:56 ` Ulrich Weigand
2016-09-19 15:23 ` Pedro Alves
2016-09-19 15:59 ` [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls Pedro Alves
2016-09-19 16:18 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c195105-42bc-eb71-d35a-143325786fac@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).