From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94478 invoked by alias); 19 Sep 2016 13:44:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94458 invoked by uid 89); 19 Sep 2016 13:44:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=likes, alternatively, preference X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Sep 2016 13:44:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12C5F3D945; Mon, 19 Sep 2016 13:44:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8JDiEwW025321; Mon, 19 Sep 2016 09:44:15 -0400 Subject: Re: [PATCH] gdb: Use std::max and std::min throughout To: Ulrich Weigand References: <20160919114724.A00EC10B7EF@oc8523832656.ibm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1c195105-42bc-eb71-d35a-143325786fac@redhat.com> Date: Mon, 19 Sep 2016 13:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00206.txt.bz2 On 09/19/2016 02:35 PM, Pedro Alves wrote: > # define gettext(Msgid) (Msgid) > # define dgettext(Domainname, Msgid) (Msgid) > # define dcgettext(Domainname, Msgid, Category) (Msgid) > # define textdomain(Domainname) while (0) /* nothing */ > # define bindtextdomain(Domainname, Dirname) while (0) /* nothing */ > # define _(String) (String) > # define N_(String) (String) > #endif Alternatively, simply remove the troublesome *gettext and *textdomain macros, leaving only the _ and N_ ones. I can't seem to find any directly reference to gettext in the tree. The textdomain calls in main.c would need to be wrapped in #ifdef ENABLE_NLS, but likes like that is all. I don't have a strong preference either way. Thanks, Pedro Alves