public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/4] Fix .gdb_index with Ada
Date: Mon, 17 Oct 2022 06:01:40 +0200	[thread overview]
Message-ID: <1c21ebc1-db8b-d348-a858-5adeb16a873c@suse.de> (raw)
In-Reply-To: <20221014160849.919621-1-tromey@adacore.com>

On 10/14/22 18:08, Tom Tromey via Gdb-patches wrote:
> This is v2 of my series to fix .gdb_index support with Ada.
> 
> I believe this fixes the issues pointed out by Tom de Vries in the
> last version -- in particular, c-linkage-name.exp passes now.
> 
> This version also adds another patch to remove type linkage names from
> the cooked index (and thus also .gdb_index).  I believe when I wrote
> the new reader, I thought it was necessary to preserve these -- but
> since they aren't demangled anywhere, this never had any effect
> anyway.
> 
> I regression tested this on x86-64 Fedora 34, using both the default
> and the cc-with-gdb-index board.


Hi,

I've tested this on openSUSE Leap 15.4 and openSUSE Tumbleweed.

All is looking good apart from the 12.1 regression I found on Tumbleweed 
( https://sourceware.org/bugzilla/show_bug.cgi?id=29694 ), which this 
series doesn't fix for me.

Thanks,
- Tom

  parent reply	other threads:[~2022-10-17  4:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 16:08 Tom Tromey
2022-10-14 16:08 ` [PATCH v2 1/4] Fix regression in c-linkage-name.exp with gdb index Tom Tromey
2022-10-14 16:08 ` [PATCH v2 2/4] Don't add type linkage names to cooked index Tom Tromey
2022-10-14 16:08 ` [PATCH v2 3/4] Improve Ada support in .gdb_index Tom Tromey
2022-10-14 16:08 ` [PATCH v2 4/4] Change .gdb_index de-duplication implementation Tom Tromey
2022-10-17  4:01 ` Tom de Vries [this message]
2022-10-17 16:03   ` [PATCH v2 0/4] Fix .gdb_index with Ada Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c21ebc1-db8b-d348-a858-5adeb16a873c@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).