From: Wei-min Pan <weimin.pan@oracle.com>
To: Tom Tromey <tom@tromey.com>,
Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] CTF: fix incorrect function return type
Date: Fri, 5 Feb 2021 11:12:48 -0800 [thread overview]
Message-ID: <1c478bb7-c757-d766-5f79-0ba6e7c6100f@oracle.com> (raw)
In-Reply-To: <87ft2a5y2g.fsf@tromey.com>
On 2/5/2021 7:33 AM, Tom Tromey wrote:
>>>>>> ">" == Weimin Pan via Gdb-patches <gdb-patches@sourceware.org> writes:
> This patch needs ChangeLog entries.
Thanks for the comments, Tom. I had ChangeLog entry in each patch originally
but decided to summarize them (both gdb/ChangeLog and testsuite/ChangeLog)
in the last patch. I can switch back to including them in each patch if
that is the
way to go.
>>> gdb/ctfread.c | 5 +-
>>> gdb/testsuite/gdb.base/ctf-funcreturn.exp | 190 ++++++++++++++++++++++++++++++
> How about we make gdb/testsuite/gdb.ctf and put new CTF tests there?
I think what Andrew Burgess did to merge CTF tests into single test scripts,
e.g. whatis.exp, is what we want to eventually be for the rest of the
CTF tests.
But it's also fine to put all the CTF tests under a new directory.
> Tom
prev parent reply other threads:[~2021-02-05 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 1:48 [PATCH 0/5] CTF: bug fixes and new features Weimin Pan
2021-02-02 1:48 ` [PATCH 1/5] CTF: fix incorrect function return type Weimin Pan
2021-02-02 1:48 ` [PATCH 2/5] CTF: set up debug info for function arguments Weimin Pan
2021-02-02 1:48 ` [PATCH 3/5] CTF: handle forward reference type Weimin Pan
2021-02-02 1:48 ` [PATCH 4/5] CTF: add all members of an enum type to psymtab Weimin Pan
2021-02-02 1:48 ` [PATCH 5/5] CTF: multi-CU and archive support Weimin Pan
2021-02-05 15:42 ` [PATCH 3/5] CTF: handle forward reference type Tom Tromey
2021-02-05 19:33 ` Wei-min Pan
2021-02-05 15:40 ` [PATCH 2/5] CTF: set up debug info for function arguments Tom Tromey
2021-02-05 19:21 ` Wei-min Pan
2021-02-05 15:33 ` [PATCH 1/5] CTF: fix incorrect function return type Tom Tromey
2021-02-05 19:12 ` Wei-min Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c478bb7-c757-d766-5f79-0ba6e7c6100f@oracle.com \
--to=weimin.pan@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).